Ubuntu
user-setup package

[PATCH] Only allow ascii characters in oem-config password fields

Bug #495695 reported by Debbie Beliveau on 2009-12-11

6

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	user-setup (Ubuntu)	New	Undecided	Unassigned

Bug Description

Binary package hint: ubiquity

Currently, oem-config does not complain if the user includes a non-ascii character in their password. This is generally not a problem because there usually is not an easy way for the user to enter a non-ascii character during oem-config. However, it is still possible for the user to enter a non-ascii character and some oem projects actually require that scim be enabled in oem-config (so, for example, the user's real name can be entered in Japanese).

Attached is a patch to ubiquity that has oem-config check the password for non-ascii characters. If any such characters are detected, oem-config will complain and the user is forced to enter a new password.

Tags:

Related branches

lp:~lool/ubiquity/lp-495695-ascii-passwords

Rejected for merging into lp:ubiquity

Evan (community): Needs Information on 2010-01-22

lp:~mterry/user-setup/only-ascii-passwords

Ready for review for merging into lp:~ubuntu-core-dev/user-setup/ubuntu

Colin Watson: Needs Information on 2010-11-24

Revision history for this message

Debbie Beliveau (debbie-beliveau) wrote on 2009-12-11:

#1

ubiquity_2.0.10netbook2.debdiff Edit (4.7 KiB, text/plain)

tags:

added: oem-services

Revision history for this message

Loïc Minier (lool) wrote on 2009-12-14:

#2

The patch changes the automatically downloaded user-setup copy in ubiquity; re-assigning to user-setup

affects:

ubiquity (Ubuntu) → user-setup (Ubuntu)

Revision history for this message

Loïc Minier (lool) wrote on 2009-12-14:

#3

Note for self: I'm not sure busybox is built with "expr"'s support for regexps in Debian.

Revision history for this message

Loïc Minier (lool) wrote on 2009-12-14:

#4

"graph" in the regexp doesn't allow for space; is this on purpose?

Revision history for this message

Loïc Minier (lool) wrote on 2009-12-14:

#5

I unpacked Debian sid's busybox-udeb and could run bin/busybox expr foo : foo, so it seems it has sufficient support.

Revision history for this message

Loïc Minier (lool) wrote on 2009-12-14:

#6

It's not clear to me how this is specific to oem-config? it doesn't seem to be

Revision history for this message

Loïc Minier (lool) wrote on 2009-12-14:

#7

I prepared a merge proposal for this as I'm not sure I understand these bits well enough.

Revision history for this message

Evan (ev) wrote on 2010-01-15:

#8

What's wrong with a UTF-8 password?

Revision history for this message

Evan (ev) wrote on 2010-01-15:

#9

To elaborate, I've done some testing on this and found no issues, nor outstanding bugs, with non-ascii passwords. That said, it's a big Internet, and I'm sure I could've missed something.

Revision history for this message

Colin Watson (cjwatson) wrote on 2010-03-05:

#10

It would be helpful to re-prepare the merge review against lp:~ubuntu-core-dev/user-setup/ubuntu, so that it's possible to see the effective change being proposed.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-11-04:

#11

Debbie is that still something that applies to the current version? Could you do what Colin asked for in the previous comment?

Revision history for this message

Michael Terry (mterry) wrote on 2010-11-24:

#12

I rebased the patch onto user-setup, in lp:~mterry/user-setup/only-ascii-passwords.

I can't speak to Evan's comment about what the problem is with utf-8 passwords these days. I believe they used to cause problems, but I'm not sure what the state of art is.

Revision history for this message

Martin Pitt (pitti) wrote on 2010-11-26:

#13

I'm unsubscribing the sponsors team. This was discussed between Debbie and Colin, and so far the result is that this should be sent to Debian and then merged back.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

ubiquity_2.0.10netbook2.debdiff Edit

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.