No way to disable quoting playable uris
Bug #491874 reported by
Michał Sawicz
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Moovida |
Fix Released
|
Critical
|
Olivier Tilloy |
Bug Description
When giving the player a uri, it is always quoted. This is fine for most cases, but there are those that break. For example:
is quoted into
and Vimeo servers respond to that with a 403 error.
This quoting is performed in elisa-plugins/
Related branches
lp:~osomon/moovida/fix_uri_quoting
Merged
into
lp:moovida
- Guillaume Emont: Approve (code functional)
-
Diff: 131 lines (+83/-8)3 files modifiedelisa-plugins/elisa/plugins/gstreamer/decodebin2_pipeline.py (+24/-2)
elisa-plugins/elisa/plugins/gstreamer/old_pipeline.py (+24/-2)
elisa-plugins/elisa/plugins/poblesec/player_video.py (+35/-4)
Changed in moovida: | |
assignee: | nobody → Olivier Tilloy (osomon) |
milestone: | none → bug-fixing-day |
status: | Confirmed → In Progress |
Changed in moovida: | |
status: | In Progress → Fix Committed |
Changed in moovida: | |
status: | Fix Committed → Fix Released |
Changed in moovida: | |
milestone: | bug-fixing-day → 1.0.10 |
To post a comment you must log in.
I cannot reproduce with Vimeo videos specifically, although I can observe that quoting the example URI that you give indeed fails.
Here is what happens when I try to play e.g. the first video of the HD channel ("Phoenix - 1901 - A Take Away Show"): vimeo.com/ moogaloop/ play/clip: 7942520/ 063aa13b9e53ae2 fa551a8f7cdeca3 3b/1259933400/ ?q=hd vimeo.com/ moogaloop/ play/clip: 7942520/ 063aa13b9e53ae2 fa551a8f7cdeca3 3b/1259933400/ %3Fq%3Dhd
- unquoted URL: http://
- quoted URL: http://
which is then successfully redirected to http:// bitcast. vimeo.com/ vimeo/v2/ 125/878/ 12587819. mp4?e=125993441 0&h=c94226a1f86 6b49aaf12be4cf7 f4a3f2