UNIFY FILEMAN CODE FOR SAVING ROUTINES

Joel, it appears that you have modified ^DD("OS",19,"ZS") to call D SAVE^%ZOSV2(X,1), but have we coordinated this change with George? (^DD("OS",19,"ZS") is set by FileMan, right?) I suppose we have to update ^ZOSV2GTM to support the second argument to SAVE before FileMan can be updated, but what about folks who are running FileMan but not our GT.M Integration stuff?

We can still release the ZOSV2GTM change. I'll contact George but the Fileman change can be later or we can document that the field in MUMPS operating system file can be modified manually.

OK I'm putting this up for review then.

George wanted this done differently.
Have the "ZS" Node call ^%ZOSV("SAVE") and have SAVE^ZOSV2 maintain a single parameter and determine if the array has an ending zero subscript.

^DD("OS",19,"ZS")
N DIE,XCN S XCN=0,DIE="^UTILITY($J,0," X ^%ZOSF("SAVE")

^%ZOSF("SAVE")
D SAVE^%ZOSV2(X)

Jon I've made a change to ZOSV2GTM in production if you want to submit that for review.

I've updated the branch with your revised version. I have to admit I'm not familiar enough with the structure of DIE and XCN to really review the patch, but I did notice you seem to be NEWing %S even though it's not used?

Also, are there easy ways to test this code from both the FileMan (^DD("OS",19,"ZS")) route and the ^%ZOSF("SAVE") route?

Compiling a template D ^DIPZ for print templates uses the "ZS" logic

Importing a routine in KIDS uses the ^%ZOSF("SAVE")

%S (wont hurt GFT seemed to recall it as needed)