add Apport hook to libmtp

Bug #430261 reported by Sense Egbert Hofstede
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libmtp (Ubuntu)
Fix Released
Low
Brian Murray

Bug Description

Add the Apport hook I'm going to attach to the libmtp package, so newly reported bugs with Apport will include at least some basic information for us to work with.

Related branches

Revision history for this message
Sense Egbert Hofstede (sense) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks for writing this however, the first line still says:

'''apport package hook for compiz

Additionally, libusb in attach_related_packages in unnecessary as it is a dependency of libmtp. Finally, mtp-detect, which is provided by mtp-tools, won't necessarily be installed on every system. Subsequently that output will likely be empty. Is that okay or is there some other tool we can use?

Thanks!

Changed in libmtp (Ubuntu):
status: New → Incomplete
Revision history for this message
Sense Egbert Hofstede (sense) wrote :

Thank you for the suggestions. I must have forgotten to adapt the comment line.
I've removed the function call that includes more information about libusb, but I'd let mtp-detect in it. Output of that command is required by upstream when reporting new devices and in most cases is asked for all other bug reports as well.
The downside is of course that most people don't have mtp-utils installed and therefore the result will mostly be blank. However, if they do have mtp-utils installed, its output will be tremendously helpful for solving the bug.
We could always ask people to install mtp-utils and then run an apport-collect (it would be nice if there would come a GUI for that as well).

I also think it would be good to include MTP in a storage symptom with other music players because it is an often used protocol, but not one that's advertised to the general public.

Revision history for this message
Brian Murray (brian-murray) wrote :

This looks great but I might also add in something like the following:

if command_available("mtp-detect"):
    report['MTPDetect'] = command_output("mtp-detect")
else:
    ui.information("Please install the package mtp-tools so we can gather more detailed debugging information and rerun ubuntu-bug libmtp8")

Revision history for this message
Sense Egbert Hofstede (sense) wrote :

According to your suggestion I replaced the call of the 'mtp-detect' command with the following code:

    if command_available("mtp-detect"):
        report['MTPDetect'] = command_output("mtp-detect")
    else:
        ui.information("Please install the package 'mtp-tools' so we can gather "\
                        "more detailed debugging information. Afterwards, rerun " \
                        "the command 'ubuntu-bug libmtp' or add more information "\
                        "to an existing bug report by running the command "\
                        "'apport-collect -p libmtp '<bugnumber>', replacing "\
                        "<bugnumber> with the number of the bug report.")

Do you agree with my extension of the message? I though it could be useful until a proper GUI has been written for 'apport-collect' and 'ubuntu-bug', but maybe it only adds confusion.

What about localisation? Shouldn't we call gettext for the strings displayed in the information dialogue?

Changed in libmtp (Ubuntu):
status: Incomplete → In Progress
importance: Undecided → Low
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libmtp - 1.0.1-0ubuntu2

---------------
libmtp (1.0.1-0ubuntu2) lucid; urgency=low

  * Adding an apport package hook thanks to Sense Hofstede (LP: #430261)
 -- Brian Murray <email address hidden> Thu, 28 Jan 2010 14:55:56 -0800

Changed in libmtp (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.