debchange distribution default for Ubuntu broken

Bug #429288 reported by Colin Watson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devscripts (Ubuntu)
Fix Released
High
James Westby

Bug Description

Binary package hint: devscripts

A recent merge broke debchange's distribution default for Ubuntu. 'dch -r' is meant to use karmic rather than the most recent distribution in the changelog; this is because, unlike Debian, uploading to "unstable" (common case where the package was synced from Debian) or "jaunty" etc. (common case where the package was last uploaded to a previous Ubuntu release) is unlikely to be correct.

The diff between 2.10.48ubuntu2 and 2.10.53ubuntu1 shows:

@@ -1226,10 +1246,12 @@
        $distribution =~ s/^\s+//;
        if ($opt_r) {
            # Change the distribution from UNRELEASED for release
- if ($distributor eq 'Ubuntu') {
- $distribution = $opt_D || "karmic";
- } elsif ($distribution eq "UNRELEASED") {
- $distribution = $opt_D || $lastdist || "unstable";
+ if ($distribution eq "UNRELEASED") {
+ if ($dist_indicator and not $opt_D) {
+ $distribution = $dist_indicator;
+ } else {
+ $distribution = $opt_D || $lastdist || "unstable";
+ }
            } elsif ($opt_D) {
                warn "$progname warning: ignoring distribution passed to --release as changelog has already been released\n";
            }

The "if ($distributor eq 'Ubuntu')" bit should not have been dropped, although it would make sense for the new $dist_indicator to override it.

Colin Watson (cjwatson)
tags: added: regression-potential
James Westby (james-w)
Changed in devscripts (Ubuntu):
status: New → In Progress
assignee: nobody → James Westby (james-w)
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package devscripts - 2.10.53ubuntu2

---------------
devscripts (2.10.53ubuntu2) karmic; urgency=low

  * debchange: Don't use the last distribution in debian/changelog
    when doing "dch -r" on Ubuntu. "Just because it was last uploaded to
    jaunty doesn't mean that's the right thing to do now." Thanks
    to Colin Watson. (LP: #429288)

 -- James Westby <email address hidden> Mon, 14 Sep 2009 15:57:43 +0100

Changed in devscripts (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.