TheTVDb provider fails for unknown locales

Dnia 2009-09-07, pon o godzinie 07:36 +0000, Martin Isak Jansen pisze:
> Public bug reported:
>
> 1. Tv Shows -> Unclassified videos -> <select episode to to be
> classified>
> 2. Select tv show.
> 3. Sometimes the episode gets recognized correctly and some does not.
> The result is the same both times.
> 4. Press confirm.
> 5. Get screen saying it is compleate. Press continue browsing.

Could you give an example as to what show is not recognized and which
one is?

> (I have no idea if that is helpfull).

Unfortunately, no. Nothing interesting there.

--
Michał Sawicz <email address hidden>

>Could you give an example as to what show is not recognized and which one is?

CSI.S09E01.720p.etc.etc.mkv is recognized fine.
Firefly.2002.Ep01.720p.etc.etc.mkv is not recognized but with a refined search it is found.
Mythbusters.S07E01.Titel.etc.avi is recognized fine.
Oz and James big wine adventure.S02E01.etc.avi is not recognized.
Planet.Earth.EP01.titel.avi is not recognized.

I'm not sure I made myself clear. All the tv show files show up in the unclassified list (except from iso files but I understand thats another story). The problem is with the "tagging" you could say. With recognized I mean that moovida can find out which episode it is automatically.

Finding the information that should be "tagged" is not a problem, that works quite fine. But making the information "stick" in the database is not working. Finds the tv show files fine. Finds information about the shows (sometimes with a little bit help) fine. Press confirm that it is correct and it is back to scratch as you had not done anything.

>> (I have no idea if that is helpfull).
> Unfortunately, no. Nothing interesting there.

Is there anything I can do to get a debug log or something that could help?

We (myself and Mozillion) managed to track this down to the situation where there already is an episode classified (probably wrongly so) as the one you try to reclassify and this triggers a NotImplementedError in "elisa/plugins/database/video_categorizer.py", line 1461, in check_duplicate.

Martin, can you confirm that indeed you're experiencing these issues for episodes that are duplicates of ones that have already been categorized?

The bug this seems to be a duplicate of: https://bugs.launchpad.net/elisa/+bug/384704

>Martin, can you confirm that indeed you're experiencing these issues for episodes that are duplicates of ones that have already been categorized?

That is a negative. I do not have any tv shows categorized. None gets categorized automatically (as some of my movies did) so the only way to get them categorized gets stopped by this "strange behavior". I tried removing the .moovida preferences folder, but that did not help ether.

Well the weirdest thing is that you're not getting any errors there.

One other thing I've noticed - you're running from quite an old release (1.0.1) updated through eggs.

Is there any way you could upgrade your system wide installation?

Oh and btw. if you want, you might experiment with the ELISA_DEBUG environment variable, setting it to "video*:5" for more verbose output in the console, maybe that will shed some light on your issues.

Ok, here is what I get with ELISA_DEBUG=video*:5

When I click to categorize the tv show:
INFO MainThread video_parser sep. 09 09:17:44 original video name: u'firefly' (elisa/plugins/database/video_parser.py:74)
INFO MainThread video_parser sep. 09 09:17:44 cleanup name: u'firefly' (elisa/plugins/database/video_parser.py:97)

When I click refine search:
WARN MainThread widget sep. 09 09:17:52 elisa.plugins.pigment.widgets.panel.PiecePanel.bg_color: attribute not found. (elisa/plugins/pigment/widgets/widget.py:347)

I type in the name and season etc with no error message.

When I end up at the "Video recategorization" window and it says that it went fine:
DEBUG MainThread video_parser sep. 09 09:19:25 Could not find a match (('http://www.thetvdb.com/api/F3BC89000AEB8902/series/78874/nb.xml',)) (elisa/plugins/database/video_parser.py:296)

When I get back to the uncategorized list:
WARN MainThread widget sep. 09 09:20:48 elisa.plugins.pigment.widgets.panel.PiecePanel.bg_color: attribute not found. (elisa/plugins/pigment/widgets/widget.py:347)
WARN MainThread widget sep. 09 09:20:49 elisa.plugins.pigment.widgets.panel.PiecePanel.bg_color: attribute not found. (elisa/plugins/pigment/widgets/widget.py:347)

I installed moovida through the ubuntu ppa so the version I have is the latest that is there. If anyone could push through a newer version to the repository I could update.

OK thanks for that, I finally see what's going on.

The resource provider tries to download information in language 'nb' which TheTVDB does not know.

The resource provider should try and get the info in current locale and if not found - use english as a fallback.

Thanks Martin, as a temporary solution run Moovida with 'en_EN' locale or some other that'd more suit yourself (we currently support pt_BR, fr, it, pl, es).

Just to clarify for anyone who's going to pick this bug up:

Martin had locale 'nb' and thetvdb provider tried to download data for this language but failed.

http://bazaar.launchpad.net/~elisa-developers/elisa/relook/annotate/head%3A/elisa-plugins/elisa/plugins/database/video_parser.py#L317

The resource provider should, in a case like this, fall back to English (or some other language TheTVDb actually knows).

Agreed, it should fall back to English.

Note that you have to set LANG for this, since LC_MESSAGE is still ignored by Moovida.
See: https://bugs.launchpad.net/elisa/+bug/425544

I think Paul meant https://bugs.launchpad.net/elisa/+bug/326838

Fix is awaiting review.

I am using 1.0.8 and the confirm button generally does nothing unless I use manual entry. I get some debug info like this:

--- <exception caught here> ---
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 328, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
  File "/home/jelofson/.moovida/plugins/elisa_plugin_themoviedb-0.5.egg/elisa/plugins/themoviedb/resource_provider.py", line 283, in _response_read

exceptions.AttributeError: 'NoneType' object has no attribute 'find'

This also happens with TV shows. I have done a few complete re installs. Nothing yet. It originally worked, most of the time, but then all of a sudden it stopped. I have even removed the .moovida folder etc.

Any suggestions?

Jon

@Jon: what you were experiencing was bug #441011, and a fix was released in Moovida's plugin repository, it should update itself automatically. Can you please confirm this solves your issue?

I'm going to add this suggestion here.
I'm running moovida 1.0.9 from packman on opensuse 11.2

The "succes" dialog on recategorzing is unecessary.

 What i expect is that when I click "confirm", the dialog disappears, and whatever needs to be done afterwards moves to another thread, since it doesn't require my input anymore anyway.

I DO want to be notified it something goes wrong, but i don't need to wait until the process is done to move on, especially when i have a large collection of unclassified.

I'm not sure which one will be easier to implement: a better scanner to reduce the unclassified, or a threaded categorizer, to reduce UI delays, but i thinnk both are a must for Moovida to get accepted in the HTPC big league (which it deserves!)