FFe: update valgrind to 2.5.0 to fix many errors with glibc 2.10 on x86_64

This bug was fixed in the package valgrind - 1:3.4.1-1ubuntu2

---------------
valgrind (1:3.4.1-1ubuntu2) karmic; urgency=low

  * Rebuild to include suppressions for libc6 2.10.x (LP: #423485).

 -- Colin Watson <email address hidden> Fri, 04 Sep 2009 15:12:18 +0100

This doesn't seem to be fixed in 1:3.4.1-1ubuntu2. /usr/lib/valgrind/default.supp appears to have suppressions in it:
# Errors to suppress by default with glibc 2.10.x

but the following on amd64 on Karmic is very noisy:
$ valgrind /bin/echo hello

i386 works fine; I don't have an amd64 to hand right now. Could somebody
investigate?

Thank you Colin. This is working well on my i386 system.

Also confirming it's broken on amd64 for me:
==26252== ERROR SUMMARY: 5434 errors from 299 contexts (suppressed: 1156 from 2)

More information is found in:
http://bugs.archlinux.org/task/14786
http://bugs.kde.org/show_bug.cgi?id=190429

Fedora 11 patches are here:
http://cvs.fedoraproject.org/viewvc/rpms/valgrind/F-11/

I can say that just the added suppressions was not enough. Upstream seems to have settled on a strlen redirection in r10689 that may fix this. From svn:
r10689 | sewardj | 2009-08-02 07:21:31 -0500 (Sun, 02 Aug 2009) | 14 lines

Reinstating a heavily modified version of r10402. This is to do
with #190429.

This patch (originally from Jakub Jelinek) makes the redir of strlen
in ld.so on amd64-linux ld.so mandatory, but only for glibc 2.10 and
above. For glibc-2.2 (our earliest supported version) to glibc-2.9
it is still optional.

Also, makes more verbose, the message that is printed if a mandatory
ld.so redirection on Linux cannot be set up.

Is believed to fix #190429.

I ran out of time to look at r10689 closely. I can say that it does not apply cleanly to our version of valgrind. I won't have time to look at this until next week, so if anyone else wants to grab it, go for it.

It would be incredibly useful to have this fixed for the "beta to final" bugfixing phase.

Just FYI: Upgrading to Debian's 3.5.0-1 package (+ Ubuntu patches) and installing libc6-dbg fixes this problem.

I applied "valgrind-3.4.1-x86_64-ldso-strlen.patch" ( http://bugsfiles.kde.org/attachment.cgi?id=33034 ) to the karmic's valgrind and the errors went away. However, if I uninstall libc6-dbgsym valgrind becomes totally broken (because it fails to find strlen in ld.so), basically just what Nicholas Nethercote explained in the upstream bug: http://bugs.kde.org/show_bug.cgi?id=190429

So this patch is not good for Ubuntu as-is (I wonder if that bug also happens in Fedora 11 because they seem to carry exactly that patch, maybe they have libc6-dbg listed as an explicit dependency of their valgrind package or something though?).

It seems that valgrind devs recommend not stripping ld.so or adding libc6-dbg as a dependency of the valgrind package. For details see the file README_PACKAGERS inside the valgrind package.

I also tried the upstream patch that Julian Seward added to valgrind svn as r10689. Hunk #11 in this patch fails to apply but it's an irrelevant "coding style" change for darwin/mac code anyway so I think it can be ignored. The problem though is that the upstream patch also gives me the error "Fatal error at startup: a function redirection which is mandatory for this platform-tool combination cannot be set up" so this patch is also not good enough to be applied as-is.

On Jaunty I can run "valgrind true" with zero errors even if I have libc6-dbg uninstalled.

It looks like 3.5.0 with libc-dbg as a dep fixes everything. I would like to propose a FFe to get this merged, since as-is it is a regression against jaunty, and the changes are limited to a single binary package.

FFe granted.

This bug was fixed in the package valgrind - 1:3.5.0-2ubuntu1

---------------
valgrind (1:3.5.0-2ubuntu1) karmic; urgency=low

  * Merge from debian unstable, remaining changes:
    - Refresh 91_build_with_fno_stack_protector.dpatch.
    - Add lpia to Architecture.
  * Move libc6-dbg to Recommends (LP: #423485).

valgrind (1:3.5.0-2) unstable; urgency=low

  * debian/control:
    - Added libc6-dev-i386 to build-dependencies on amd64.
      May reopen #507752 but closes: #548067.

valgrind (1:3.5.0-1) unstable; urgency=low

  * New upstream version. (Closes: #545700)
  * debian/patches/02_version:
    - Updated to fit this new version (Thanks to Andreas Beckmann)
  * debian/patches/01_pcm-ioctl.patch:
    - Updated
  * debian/patches/01_more-vg-n-threads.dpatch:
    - Added to increas VG_N_THREADS to 500. (Closes: #514133)
  * debian/docs:
    - ACKNOWLEDGEMENTS file is gone
  * debian/watch:
    - Added (Again, thanks to Andreas Beckmann)
  * debian/control:
    - Removed Uploaders field (Closes: #519380, #540834)
  * debian/valgrind.bash:
    - Provides a first bash completion script for valgrind. (Closes: #539137)
      Thanks to Jerome Reybert
  * debian/debian.supp:
    - Updated to fit Debian's libc6 2.10.x

 -- Kees Cook <email address hidden> Fri, 02 Oct 2009 15:51:36 -0700

Thanks Kees, I really appreciate this fix! Karmic is going to be sweet.