Ubuntu
pidgin-libnotify package

best_name function should be using pidgin's functionality

Bug #408624 reported by Stephen Ostrow
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pidgin-libnotify (Ubuntu)
Fix Released
Low
Unassigned
Declined for Lucid by Sebastien Bacher
Declined for Maverick by Sebastien Bacher

Bug Description

Binary package hint: pidgin-libnotify

Rather than using the logic in the best_name functionality. libnotify
should be using the built-in functionality of pidgin. There is already a
function purple_buddy_get_contact_alias which returns the correct alias.

The reason I found this is because the notification is returning the
screenname rather than the Contact's alias which should have precedence.
The documentation for this function can be found here including the order
of precedence on the display name.
http://developer.pidgin.im/doxygen/2.5.2/html/blist_8h.html#b22ef857cab96ceb9ddef8fde9e47199

This has been submitted on sourceforge as well at:
https://sourceforge.net/tracker/?func=detail&aid=2831741&group_id=144907&atid=760303

Related branches

lp:~isleshocky77/pidgin-libnotify/best_name
Martin Pitt: Disapprove
Diff: 22 lines (+2/-8)
1 file modified
src/pidgin-libnotify.c (+2/-8)
Sebastien Bacher: Pending requested
Marc Deslauriers: Pending requested
Ted Gould: Pending requested
Diff: 22 lines (+2/-8)
1 file modified
src/pidgin-libnotify.c (+2/-8)
lp:ubuntu/natty/pidgin-libnotify
Revision history for this message
Stephen Ostrow (isleshocky77) wrote :

The last attachment contained an error. This one is correct

Revision history for this message
Stephen Ostrow (isleshocky77) wrote :

To apply and install the patch

cd ~
mkdir src
cd src

mkdir pidgin-libnotify
cd pidgin-libnotify

apt-get source pidgin-libnotify
sudo chown `whoami`:`whoami` -R pidgin-libnotify-0.14/
dpkg-source -x pidgin-libnotify_0.14-1ubuntu11.dsc

wget http://launchpadlibrarian.net/35113800/pidgin-libnotify_bug408624.diff
dpkg-source -x pidgin-libnotify_0.14-1ubuntu11.dsc

cd pidgin-libnotify-0.14
dpkg-buildpackage -rfakeroot -uc -b

cd ..
sudo dpkg -i pidgin-libnotify_0.14-1ubuntu11_amd64.deb

Revision history for this message
Stephen Ostrow (isleshocky77) wrote :
Revision history for this message
Stephen Ostrow (isleshocky77) wrote :
Stephen Ostrow (isleshocky77)
Changed in pidgin-libnotify (Ubuntu):
status: New → Fix Committed
Revision history for this message
Stephen Ostrow (isleshocky77) wrote :

I now have a build of Lucid along with this bug fix in my PPA. To install you can do the following.

sudo add-apt-repository ppa:isleshocky77/ppa
sudo aptitude update
sudo aptitude safe-upgrade

Revision history for this message
Nigel Babu (nigelbabu) wrote :

Marking the patch as patch-forwarded-upstream. Thanks for forwarding!

tags: added: patch-forwarded-upstream
Revision history for this message
Stephen Ostrow (isleshocky77) wrote :

Nigel, not sure what you mean. Have you forwarded this to someone upstream, or are you just referring to the fact that I've put in a merge request?

Revision history for this message
Nigel Babu (nigelbabu) wrote :

The sourceforge bug in the description, didn't you forward the bug and patch there?

Revision history for this message
Stephen Ostrow (isleshocky77) wrote :

Yes, but it looks like no one is maintaining the upstream code anymore. All changes to this package have come from add-ons and changes in the ubuntu package for it.

Sebastien Bacher (seb128)
Changed in pidgin-libnotify (Ubuntu):
importance: Undecided → Low
status: Fix Committed → Triaged
Revision history for this message
Jani Monoses (jani) wrote :

Hi Stephen,

how come this merge was declined for lucid and maverick but would make sense for natty?

Revision history for this message
Stephen Ostrow (isleshocky77) wrote :

I don't believe that they were declined for lucid and maverick, it looks as if they're pending. But I was thinking that it may not have been merged into those versions because they were already out. This is the reason I'm recommending it for natty, it is still in development.

Thank you for taking a look.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pidgin-libnotify - 0.14-4ubuntu4

---------------
pidgin-libnotify (0.14-4ubuntu4) natty; urgency=low

  [ Stephen Ostrow ]
  * Add best_name.patch: Rather than using the logic in the best_name
    functionality. libnotify should be using the built-in functionality of
    pidgin. There is already a function purple_buddy_get_contact_alias which
    returns the correct alias. (LP: #408624)
 -- Martin Pitt <email address hidden> Wed, 02 Mar 2011 11:01:30 +0100

Changed in pidgin-libnotify (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Stephen Ostrow (isleshocky77) wrote :

Looks like your correct.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.