Javascript web service client parses HTML representations as entries, even if they're not
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Leonard Richardson | ||
Bug Description
Edwin wrote a function called parse_xml_entry which tears apart a default XHTML representation of an entry and makes a Javascript object out of it, the same way that the web service client currently turns a JSON representation of an entry into a Javascript object.
The problem is that the default XHTML representation is just that--a default. It's not necessarily a <dl> tag with a bunch of <dt> tags underneath it. It could be any HTML at all. And even if it is a <dl> tag, it doesn't make sense to tear it apart. If you need an Entry object, you can just request a JSON representation. XHTML representations are intended for display as part of web pages. So parse_xml_entry shouldn't even exist. The response, or its responseText, or responseXML (I'm not sure which) should be passed directly into the callback method, which is responsible for integrating the HTML data into the web page.
But, I'm guessing Edwin didn't write this code for no reason. So I'm filing this bug so that we can work it out. We need to 1) figure out how to do what Edwin wants to do, 2) figure out whether we should be passing the callback the response object itself, response.
| Leonard Richardson (leonardr) wrote | #1 |
| Björn Tillenius (bjornt) wrote | #2 |
| Leonard Richardson (leonardr) wrote | #3 |
| Edwin Grubbs (edwin-grubbs) wrote | #4 |
| Björn Tillenius (bjornt) wrote | #5 |
| Francis J. Lacoste (flacoste) wrote | #6 |
| Changed in launchpad: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| affects: | launchpad → launchpad-foundations |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Leonard Richardson (leonardr) |
| Edwin Grubbs (edwin-grubbs) wrote | #7 |
| mouahed2010 (mouahed-elnahali) wrote Re: [Bug 380959] Re: Javascript web service client parses HTML representations as entries, even if they're not | #8 |
| Leonard Richardson (leonardr) wrote | #9 |
| Leonard Richardson (leonardr) wrote | #10 |
| Changed in launchpad-foundations: | |
| assignee: | Leonard Richardson (leonardr) → Björn Tillenius (bjornt) |
| Leonard Richardson (leonardr) wrote | #11 |
| Changed in launchpad-foundations: | |
| status: | Triaged → Fix Committed |
| assignee: | Björn Tillenius (bjornt) → Leonard Richardson (leonardr) |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
I've associated a branch with this bug which changes wrap_resource_
In IRC Edwin explained that he created parse_xml_entry because he was sending a PATCH request that modified a single field, and he needed the HTML representation of that specific field. This is exactly the use case for bug 369887, which will let you PATCH a single field and get a representation of just that field. Once I fix 369887, we can get rid of parse_xml_entry.