All the strings from evolution-indicator shows untranslated

Bug #352657 reported by Ricardo Pérez López
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
evolution-indicator (Ubuntu)
Fix Released
Low
Ted Gould
Nominated for Jaunty by Ricardo Pérez López
Nominated for Lucid by Lê Kiến Trúc
indicator-applet (Ubuntu)
Invalid
Undecided
Unassigned
Nominated for Jaunty by Ricardo Pérez López
Nominated for Lucid by Lê Kiến Trúc

Bug Description

Binary package hint: evolution-indicator

The new indicator applet displays an untranslated message in my Spanish desktop when Evolution receives a new e-mail.

The untranslated message is "1 New Message".

The string is translated in the Launchpad template:

https://translations.launchpad.net/ubuntu/jaunty/+source/evolution-indicator/+pots/evolution-indicator/es/+translate

I attach an screenshot to illustrate the problem.

Revision history for this message
Ricardo Pérez López (ricardo) wrote :
Revision history for this message
Ricardo Pérez López (ricardo) wrote :

The message is in the evolution-indicator template:

https://translations.launchpad.net/ubuntu/jaunty/+source/evolution-indicator/+pots/evolution-indicator/es/5/+translate

It was translated since 2009-03-19, and the translation is inside the evolution-indicator.mo file installed in my system:

strings -eS /usr/share/locale-langpack/es/LC_MESSAGES/evolution-indicator.mo | grep Nuevo
%d Nuevo mensaje
%d Nuevos mensajes

So where's the problem? Is it in evolution-indicator, or maybe in indicator-applet?

Revision history for this message
j.scott.gwin@gmail.com (j.scott.gwin) wrote :

Thank you for reporting this issue, it helps make Ubuntu better. Confirmed.

Changed in evolution-indicator:
status: New → Confirmed
Changed in indicator-applet:
status: New → Confirmed
Changed in evolution-indicator (Ubuntu):
assignee: nobody → ted-gould
importance: Undecided → Low
milestone: none → ubuntu-9.04
Ted Gould (ted)
Changed in indicator-applet (Ubuntu):
status: Confirmed → Invalid
summary: - "1 New Message" shows untranslated, and can't be translated
+ "1 New Message" shows untranslated
Revision history for this message
Ricardo Pérez López (ricardo) wrote : Re: "1 New Message" shows untranslated

That message is not the only one from evolution-indicator which is displayed untranslated. As you can see in the screenshot, there're more untranslated messages which belongs to evolution-indicator:

- "When New Mail Arri_ves In"
- "Any Folder"
- "Pla_y a sound"
- "_Display a notification"
- "_Indicate new messages in the panel"

All these messages are translated in Launchpad:

  https://translations.launchpad.net/ubuntu/jaunty/+source/evolution-indicator/+pots/evolution-indicator/es/+translate?batch=13

and the translations are included into the evolution-indicator.mo file.

summary: - "1 New Message" shows untranslated
+ All the strings from evolution-indicator shows untranslated
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I don't think this is a "Low" priority bug because it's visible to everyone using Evolution for e-mail. I'm sure this would easily get notified as an ugly spot when eg. non-English medias would be doing reviews.

As the translations are included but not used, it could be that translation domain (evolution-indicator) is not set or is not set correctly. Or alternatively, as I don't know how the indications are passed, if the translation should be fetched by the indicator applet itself somehow.

(added this to https://wiki.ubuntu.com/TranslatingUbuntu/JauntyTranslationIssues)

Revision history for this message
Sebastien Bacher (seb128) wrote :

let's not discuss settings, it's not a crasher, not destroying datas, not a security issue you can start arguing for days about the settings that will not make the bug fixed any faster there, let's rather try to get a patch so that can be fixed before jaunty

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Attached is a patch that fixes it, it was indeed a simple issue.

(I know this is not the forum, but since you also couldn't resist continuing a bit, I can't either to continue with the controversial claim that visible I18N issues should be more important than crashers, but I will elaborate on it elsewhere:))

Revision history for this message
Ricardo Pérez López (ricardo) wrote :

@Timo:

Does your patch fixes all the messages as I commented above? (comment: https://bugs.edge.launchpad.net/ubuntu/+source/indicator-applet/+bug/352657/comments/4 )

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

@Ricardo:

Right, my patch only fixed the original notification issue. I managed to dwell into it a bit more and fixed those messages as well. Attached is another patch, which would fix both problems (I'm not certain about using "/usr/share/locale", but it seems to work even though the actual .mo files are under locale-langpack dirs).

In this version I also changed the first part to use the PACKAGE variable available.

Revision history for this message
Mark Shuttleworth (sabdfl) wrote : Re: [Dx-team] [Bug 352657] Re: All the strings from evolution-indicator shows untranslated

Thanks for the patch, Timo!

Revision history for this message
Ricardo Pérez López (ricardo) wrote :

Great, thanks a lot, Timo :)

Revision history for this message
Sebastien Bacher (seb128) wrote :

the change looks good to me, is the codeset call required though? other pygtk applications don't seem to do that

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Sebastien: (not pygtk but C) Most probably it's by default UTF-8. I checked how the gettext setup is done from update-notifier, where it's done like this (except that there is a Makefile -DPACKAGE_LOCALE_DIR which evolution-indicator doesn't have). I now quickly checked that it also works without that line just fine.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package evolution-indicator - 0.1.12-0ubuntu1

---------------
evolution-indicator (0.1.12-0ubuntu1) jaunty; urgency=low

  * New upstream version.
    * Patch from Neil Patel to fix LP: #342429 that looks to X to figure
      out if an Evolution window is open before sending notifications.
    * Patch from Timo Jyrinki which fixes LP: #352657 where the plugin
      was using the wrong gettext domain.

 -- Ted Gould <email address hidden> Mon, 06 Apr 2009 12:09:23 -0500

Changed in evolution-indicator (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Ricardo Pérez López (ricardo) wrote :

Ted, your fix has a very bad side-effect: now, ALL strings are untranslated EXCEPT the ones from evolution-indicator!

Steps to reproduce:

1. Open Evolution
2. Click on Edit->Preferences, and then on Mail Preferences

You can see some untranslated strings: "Automatic Contacts", "Calendar and Tasks"...

3. Click on Close
4. Click again on Edit->Preferences, and then on Mail Preferences

Now, ALL the strings shows untranslated EXCEPT the ones from evolution-indicator!

Revision history for this message
Ricardo Pérez López (ricardo) wrote :
Changed in evolution-indicator (Ubuntu):
status: Fix Released → Confirmed
Revision history for this message
Ted Gould (ted) wrote :

Okay, so I think I fixed the fix :)

Could people try the release in my PPA and confirm that it works as expected before we publish this to everyone again :)

   https://edge.launchpad.net/~ted-gould/+archive/ppa

Version is:

    evolution-indicator - 0.1.12-0ubuntu2~ppa1

Thank you!

Revision history for this message
Ricardo Pérez López (ricardo) wrote :

Ted, thanks for taking care of this bug.

I've just tested your 0.1.12-0ubuntu2~ppa1 version, and the localization problem was gone. Congrats!

However:

I just realized that the "%d New messages" OSD notification no longer appears when new messages arrives! I can confirm that:

  - Using evolution-indicator_0.1.11-0ubuntu1, the notification appears.
  - Using evolution-indicator_0.1.12-0ubuntu1, the notification does NOT appear, and I suffer the translations issue.
  - Using evolution-indicator_0.1.12-0ubuntu2~ppa1, the notification does NOT appear, and I don't suffer the translations issue.

I tried running Evolution using:

  $ LANG=C evolution

with the same results.

If you think I can help you in any way, please tell me. Thanks in advance.

description: updated
description: updated
Revision history for this message
Ted Gould (ted) wrote : Re: [Bug 352657] Re: All the strings from evolution-indicator shows untranslated

On Tue, 2009-04-07 at 17:34 +0000, Ricardo Pérez López wrote:
> I just realized that the "%d New messages" OSD notification no longer
> appears when new messages arrives! I can confirm that:
>
> - Using evolution-indicator_0.1.11-0ubuntu1, the notification appears.
> - Using evolution-indicator_0.1.12-0ubuntu1, the notification does NOT appear, and I suffer the translations issue.
> - Using evolution-indicator_0.1.12-0ubuntu2~ppa1, the notification does NOT appear, and I don't suffer the translations issue.

Hmm, I definitely still getting the notification. One of the things
that improved in 0.1.12 is that it detects the window with focus more
more strictly. And no notification will be displayed if it things that
Evolution is open. Can you make sure to have another window focused and
see if that changes the behavior?

Revision history for this message
Ricardo Pérez López (ricardo) wrote :

Yes, Ted, you are right: the notification appears when I focus in another window other than Evolution. I was testing the notification issue with the Evolution opened and focused, so it doesn't appear. If this is the desired behavior, then it works perfectly for me.

Thanks a lot for the fix, Ted! Can you include the fix in Jaunty, please?

BTW, a rather offtopic question: is there a way to "hide" the Evolution window inside the indicator-applet, as is been done with Pidgin?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Not yet. We'll consider how to present that in Karmic.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package evolution-indicator - 0.1.13-0ubuntu1

---------------
evolution-indicator (0.1.13-0ubuntu1) jaunty; urgency=low

  * New upstream version.
    * Updating patch to fix internationalization issues so that Evolution
      translations work along with the indicator's. LP: #352657

 -- Ted Gould <email address hidden> Tue, 07 Apr 2009 11:06:47 -0500

Changed in evolution-indicator (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Lê Kiến Trúc (le-kien-truc) wrote :

This bug haven't fixed yet in Lucid.
I've allready checked the translate string in Launchpad and
strings -eS /usr/share/locale-langpack/vi/LC_MESSAGES/evolution-indicator.mo

The bug effect when i setup a new account with "Set Up Mail...". Then there is no translation for
Compose New Email or Contacts if I haven't started the Evolution yet. Even when I click to the Compose New Email,
But when I clicked to Contacts or "Thư điện tử" then the Evolution will start, and these String will change to Vietnamese.
This bug is not from translation, it's from the application itself.
There are screenshots:
http://lh3.ggpht.com/_aLbiI7q0F1c/S8Lsy2epp0I/AAAAAAAADZI/4cVrA0ZZ7IE/Man_h%C3%ACnh.png

http://lh6.ggpht.com/_aLbiI7q0F1c/S8LtZ8OgX2I/AAAAAAAADZU/wCbdPhLxtx4/Man_h%C3%ACnh-2.png

http://lh5.ggpht.com/_aLbiI7q0F1c/S8Lszt9A9LI/AAAAAAAADZQ/KVmkwHQke7A/s640/Man_h%C3%ACnh-2.png

Changed in evolution-indicator (Ubuntu):
status: Fix Released → In Progress
status: In Progress → Incomplete
Revision history for this message
Ted Gould (ted) wrote :

What you're describing is a different bug. It's been fixed and is being
uploaded. It should be in the archives shortly.

  affects ubuntu/evolution-indicator
  status fixreleased

Changed in evolution-indicator (Ubuntu):
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.