Ubuntu
notify-sharp package

notify-sharp inappropriately swallows all notification actions

Bug #349550 reported by David Barth on 2009-03-27

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	notify-sharp	New	Unknown	galago #185
	notify-sharp (Ubuntu)	Fix Released	Low	Ken VanDine

Bug Description

Binary package hint: giver

Giver is currently using notifications to present the recipient of a transfer with an option to accept or deny a file.

However, implementations like notify-osd do not let applications use notifications for such interactions, and instead encourage the use of better interaction mechanisms, like a dialog box or a morphing application window.

Note: this bug started as #347081. It was triggered by a change in notify-sharp that silently omits actions in a notification request if the remote server does not support the capability.

See https://wiki.ubuntu.com/NotifyOSD#Giver and https://wiki.ubuntu.com/NotificationDevelopmentGuidelines#Avoiding%20actions for suggestions on how to fix giver.

Tags:

Related branches

lp:ubuntu/karmic/notify-sharp

Revision history for this message

David Barth (dbarth) wrote on 2009-03-27:

Cody, can you remove the check in notify-sharp? The library should really not make such decisions for the application.

Changed in giver:
assignee:	nobody → bratsche
importance:	Undecided → Low
status:	New → Triaged

Revision history for this message

David Barth (dbarth) wrote on 2009-03-27:

notify-sharp.patch Edit (631 bytes, text/plain)

Here is the patch for notify-sharp

Matthew Paul Thomas (mpt) on 2009-03-30

affects:

giver (Ubuntu) → notify-sharp (Ubuntu)

Matthew Paul Thomas (mpt) on 2009-03-30

summary:

- giver should check the notification server capabilities
+ notify-sharp inappropriately swallows all notification actions

Ken VanDine (ken-vandine) on 2009-03-30

Changed in notify-sharp:
assignee:	bratsche → ken-vandine

Revision history for this message

Darrin Ritter (darrinritter) wrote on 2009-03-30: Re: [Bug 349550] Re: notify-sharp inappropriately swallows all notification actions

Hi There,

Just a comment on the accept/reject problem in Giver with the new
notification system in Jaunty. Logically the action to receive or reject a
file/folder should be via the systray icon or from within the actual
application window.

Darrin Ritter

On Tue, Mar 31, 2009 at 3:38 AM, Ken VanDine <email address hidden>wrote:

> ** Changed in: notify-sharp (Ubuntu)
> Assignee: Cody Russell (bratsche) => Ken VanDine (ken-vandine)
>
> --
> notify-sharp inappropriately swallows all notification actions
> https://bugs.launchpad.net/bugs/349550
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in “notify-sharp” source package in Ubuntu: Triaged
>
> Bug description:
> Binary package hint: giver
>
> Giver is currently using notifications to present the recipient of a
> transfer with an option to accept or deny a file.
>
> However, implementations like notify-osd do not let applications use
> notifications for such interactions, and instead encourage the use of better
> interaction mechanisms, like a dialog box or a morphing application window.
>
> Note: this bug started as #347081. It was triggered by a change in
> notify-sharp that silently omits actions in a notification request if the
> remote server does not support the capability.
>
> See https://wiki.ubuntu.com/NotifyOSD#Giver and
> https://wiki.ubuntu.com/NotificationDevelopmentGuidelines#Avoiding%20actionsfor suggestions on how to fix giver.
>

Revision history for this message

Cody Russell (bratsche) wrote on 2009-03-31:

http://trac.galago-project.org/ticket/185

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2009-03-31:

349550.debdiff Edit (2.2 KiB, text/plain)

attached debdiff

Changed in notify-sharp:
status:	Triaged → In Progress

Revision history for this message

Daniel Holbach (dholbach) wrote on 2009-04-01:

Looking good. Added upstream bug link.

Ken: two small things: 1) can you try to credit the people who wrote the patch in debian/changelog from now on and 2) run update-maintainer (from ubuntu-dev-tools) if necessary (first version that diverges from Debian). Made those changes for you :-)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-04-01:

This bug was fixed in the package notify-sharp - 0.4.0~r3032-1ubuntu1

---------------
notify-sharp (0.4.0~r3032-1ubuntu1) jaunty; urgency=low

  * debian/patches/02_reverse_cap_check.patch:
    - Reverse the patch merged upstream which swallows actions in·
      notification. It is more appropriate for applications to make·
      that decision rather than a library. Thanks David Barth. (LP: #349550)

-- Ken VanDine <email address hidden> Tue, 31 Mar 2009 16:51:06 -0400