Ubuntu
language-selector package

[UIFE] gnome-language-selector doesn't have a "close" button

Bug #345113 reported by Guillaume Desmottes
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
language-selector (Ubuntu)
Fix Released
Medium
Martin Pitt

Bug Description

Binary package hint: language-selector

The gnome-language-selector installed with Jaunty doesn't have any close button making it looking realy weird. It should have such button as the other GNOME admin tools.

Vojtěch Trefný (vojtech.trefny)
Changed in language-selector (Ubuntu):
status: New → Confirmed
Revision history for this message
Ricardo Pérez López (ricardo) wrote :

Confirmed in Jaunty and Karmic, too. Seems to be an ugly issue (probably even a GNOME HIG violation) but trivial to fix. Even more, the language selector dialog looks like if were designed with the space needed for the Close button at the bottom right corner of the dialog. Maybe the developer "forgot" to include the button in the dialog?

Could the developer say any words about this?

Revision history for this message
Arne Goetje (arnegoetje) wrote :

This has been done intentionally and hopefully Gnome 3 will follow this convention. It is quite useless to have 2 close buttons in a window, one is enough. And that one is in the upper right corner of the window frame. If you look around in Ubuntu, you will notice that more and more applications (especially those written for Ubuntu) don't have the explicit close button in the bottom right corner anymore.

Revision history for this message
Loïc Minier (lool) wrote :

It doesn't match my experience in GNOME at all; I clicked on 7 - 8 configuration tools in System > Preferences and all had a Close button. I also checked jockey which is a case of "written for Ubuntu" and it has a Close button. Even our recently written gdmsetup rewrite has a Close button,

Revision history for this message
Loïc Minier (lool) wrote :

I had complaints that this is hard to close under UNR; bumping to medium

Changed in language-selector (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Tony Espy (awe) wrote :

I agree with Loic, I usually only use the close window button when an application is unresponsive.

Martin Pitt (pitti)
summary: - gnome-language-selector doesn't have a "close" button in Jaunty
+ gnome-language-selector doesn't have a "close" button
Changed in language-selector (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
status: Confirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

I added a GTK stock "close" button, see attached screenshot. This doesn't introduce any new string, and makes the UI HIG compliant. Release team, can I please get an UIF exception for this?

The patch is at http://bazaar.launchpad.net/~ubuntu-core-dev/language-selector/ubuntu/revision/379 . It looks a bit large-ish because it inserts a vbox into the top level of the dialog, which causes all the children to move one nesting level down.

summary: - gnome-language-selector doesn't have a "close" button
+ [UIFE] gnome-language-selector doesn't have a "close" button
Martin Pitt (pitti)
Changed in language-selector (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package language-selector - 0.6.3

---------------
language-selector (0.6.3) maverick; urgency=low

  [ Martin Pitt ]
  * data/LanguageSelector.ui, LanguageSelector/gtk/GtkLanguageSelector.py: Add
    a Close button. (LP: #345113)

  [ Michael Vogt ]
  * fix aptdaemon install/update (LP: #612825)
 -- Michael Vogt <email address hidden> Fri, 03 Sep 2010 18:54:47 +0200

Changed in language-selector (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.