Do Plugins

Fix for Google Maps when using newlines and other special characters

Bug #324667 reported by Philipp Wolfer
2
Affects Status Importance Assigned to Milestone
Do Plugins
Fix Released
Low
Chris S.

Bug Description

The Google Maps plugin does not properly encode the URI parameters which prevents it to allow addresses with e.g. newlines in it. This makes the plugin useless for most copy'n'paste work.

Attached is a patch to fix this by using UrlEncode.

Revision history for this message
Philipp Wolfer (phw) wrote :
Revision history for this message
Philipp Wolfer (phw) wrote :

After a quick look it seems that several plugins have the same bug. Is there a special reason why only Replace (" ", "+") was used instead of UrlEncode()?

If not and if nobody minds I will inspect all plugins and fix this if necessary.

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote : Re: [Do-plugins] [Bug 324667] Re: Fix for Google Maps when using newlines and other special characters

Philipp, I'm sure UrlEncode was not used simply because plugin authors
didn't know about it. I would love a patch to fix this if you would be so
kind.

Revision history for this message
Philipp Wolfer (phw) wrote :

It wasn't that bad as I first thought, most plugins already use UrlEncode properly :) See the attached fixurlencode.bundle, it fixes the URL encoding for the plugins Google Maps, Google Calculator and Launchpad. You should be able to merge that into trunk. And ignore the first patch I attached yesterday, this new bundle includes all you need.

I hope I did not miss a plugin.

Cheers,
Philipp

Chris S. (cszikszoy)
Changed in do-plugins:
assignee: nobody → cszikszoy
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Chris S. (cszikszoy) wrote :

do-plugins/trunk revno 530 fixes this.

Changed in do-plugins:
status: In Progress → Fix Committed
Chris S. (cszikszoy)
Changed in do-plugins:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.