Do Plugins

Open improperly escapes URLs.

Bug #317416 reported by Chris S.
2
Affects Status Importance Assigned to Milestone
Do Plugins
Fix Released
Low
Unassigned

Bug Description

This behavior is new, and should be considered a regression. To reproduce, launch do with debugging in terminal. Enable translate plugin and select some text and attempt to translate.

In the console, Do will show this:
[Info 01:53:50.767] Executing "http://translate.google.com/translate_t?hl=en\#auto|de|this\ is\ a\ test"

and open this link: http://translate.google.com/translate_t?hl=en\#auto|de|this\ is\ a\ test

It should produce this command: http://translate.google.com/translate_t?hl=en#auto|de|this is a test

I'm not sure when this particular behavior started to occur, but I do know that this was working in version 0.6.1.

Alex Launi (alexlauni)
Changed in do:
importance: Undecided → Low
milestone: none → 0.8
status: New → Confirmed
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Well, I'm pretty sure the UrlEncode method in mono does not know about Google's crazy use of | characters.

Revision history for this message
Chris S. (cszikszoy) wrote :

You can close this. I believe with the change to 0.8, the method for opening URLs in Do was changed. I looked at the translate plugin and forgot that I was using my own function to escape bad characters in a URL. This got passed to Do, which would escape the escape characters.

I've fixed this with my updates to the translate plugin and the newest, working version is already committed to do-plugins/trunk.

Note that in the related branches here it lists the two branches that I committed using --fixes=lp:317416. I wish the --fixes= bzr command would mark these bugs as 'fix committed'.

David - you can close this, it isn't an issue or bug anymore.

David Siegel (djsiegel-deactivatedaccount)
Changed in do:
status: Confirmed → Fix Committed
Robert Dyer (psybers)
affects: do → do-plugins
Changed in do-plugins:
milestone: 0.8 → none
Chris S. (cszikszoy)
Changed in do-plugins:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.