Useful backports for 1.34

Fixed in jaunty.

The changes look reasonable, thanks for putting those together.

So whoever wants to do this SRU, please go ahead.

I can work on this if nobody else wants too, but it might have to be Monday or Tuesday.

charles - I'm currently building a new version with your patches in at the moment.

I think changeset 7286 is incomplete though - the reference to tr-io.c also needs to be removed from po/POTFILES.in. Without this, the build fails (presumably because we call intltool-update to generate the pot file), and it also requires recreating the build system with autoreconf (I think). This one might be too much for a SRU.

> This one might be too much for a SRU.

That's okay. None of these are a high priority, and that one is even lower than the others. :)

Here's a debdiff with all but the last patch (7286)

Sponsored to intrepid-proposed, thanks!

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Any testers?

Any particular tests one is supposed to run?
7276 was tested ok (using info from http://trac.transmissionbt.com/ticket/1544), others seem more peculiar to test.
Also simply checking that a torrent can be opened and dowloading can be done was succesfull for me.

BTW, any particular reason why transmission and transmission-cli are in universe and transmission-gtk, transmission-common are in main?!
I was a bit stumped when I tried to update to -proposed and (having only main or universe enabled) I couldn't.

Hi Cesare,

Cesare Tirabassi [2009-01-03 18:34 -0000]:
> Also simply checking that a torrent can be opened and dowloading can
> be done was succesfull for me.

Indeed regression testing is most important here.

> BTW, any particular reason why transmission and transmission-cli are
> in universe and transmission-gtk, transmission-common are in main?!

Just because -cli is not seeded anywhere, it's not deliberately kept
out of main.

Thanks Martin,

I played some more with it and couldn't find any obvious regression. As far as I can see it works fine.

This bug was fixed in the package transmission - 1.34-0ubuntu2.2

---------------
transmission (1.34-0ubuntu2.2) intrepid-proposed; urgency=low

  * Applied patches backported from 1.4x series (LP: #305653).
    Patches cherry-picked by Charles Kerr:
    - 30_changeset-7276-from-upstream: Case insensitivity search does
      not work on cyrillic alphabet.
    - 31_changeset-7277-from-upstream: CLI client uses memory after
      it's been free()d.
    - 32_changeset-7278-from-upstream: libtransmission crashes from invalid
      RPC query.
    - 33_changeset-7279-from-upstream: Peer count on web interface is wrong.
    - 34_changeset-7280-from-upstream: When making new torrents, don't
      allow 0-byte files.
    - 35_changeset-7281-from-upstream: Constantly maps and unmaps the
      NAT-PMP port.
    - 36_changeset-7282-from-upstream: Handshake peer-id doesn't match
      the peer-id sent in the tracker announce.
    - 37_changeset-7284-from-upstream: 1.40 sends unnecessary `cancel'
      messages when choked.
    - 38_changeset-7285-from-upstream: Better heuristics for which peers
      to unchoke.

 -- Chris Coulson <email address hidden> Mon, 08 Dec 2008 22:39:20 +0000