empty notification bubbles

Bug #296953 reported by Mpampis
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Gwibber
Fix Released
High
Unassigned

Bug Description

When the tweet contains "special characters" (such as &), it does not appear in the notification bubble, which is totally empty.
(screenshot included)

Related branches

Revision history for this message
Mpampis (saperduper) wrote :
Revision history for this message
Matt McKeon (mmckeon) wrote :

I'm seeing the same blank notification bubbles when there is an ampersand in the message. Did a quick test from both Twitter and Identi.ca, but the results weren't consistent. Most of the time I've noticed it, the messages were coming from Twitter.

Gwibber version 0.7
Intrepid
Gnome 2.24.1

Ryan Paul (segphault)
Changed in gwibber:
assignee: nobody → segphault
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Dan Klassen (danklassen) wrote :

I can confirm I have seen this issue as well on my Twitter account. Initially I thought it was related to string length, but it does seems more related to special characters.

Gwibber bzr 120
Intrepid
Gnome 2.24.1

Revision history for this message
Dominic Evans (oldmanuk) wrote :

Have also seen this with '&' in a tweet, just now, using Gwibber 0.7.2 from PPA

Revision history for this message
Dominic Evans (oldmanuk) wrote :

...presumably just needs translation of reserved characters into their equivalent character references

& --> &
< --> &lt;
> --> &gt;
' --> &apos;
" --> &quot;

etc.

Revision history for this message
Dominic Evans (oldmanuk) wrote :

the difficulty being that you only want to do that outside of any URLs which could have HTTP GET data appended as &f=22 etc.

Revision history for this message
Ryan Paul (segphault) wrote :

This bug has finally been fixed upstream, so we don't have to worry about it anymore: http://trac.galago-project.org/ticket/132 :-)

Changed in gwibber:
status: Confirmed → Invalid
Revision history for this message
Dominic Evans (oldmanuk) wrote :

hmm, unless I'm misreading the diff, I'm dubious if that fix is valid for the problem we've seen in gwibber?

all they seem to do is escape the reserved characters in the 'summary', and not the 'body' of the notification. In our case the summary is the message.sender value, and our body is the actual message content (e.g., tweet)

when I've seen empty notification bubbles its been because the body contained &, i've not seen a message.sender contain an ampersand

Revision history for this message
Ryan Paul (segphault) wrote :

Indeed, the upstream fix doesn't appear to really solve this. :-(

Changed in gwibber:
assignee: segphault → nobody
status: Invalid → Confirmed
Revision history for this message
Dominic Evans (oldmanuk) wrote :

Having got bored of this problem showing up recently, I played around with various regexps to try and fix it neatly. However, I eventually noticed that I could just replace all & with &amp; and the links still worked!

e.g., you can demo this with libnotify-bin

notify-send 'Bug 296953' 'Testing this bug showed we can &amp; as much as we like even in links like <a href="http://www.google.com/search?hl=en&amp;q=http://www.google.com/search?num=50&amp;hl=en&amp;q=%2Bgwibber+%2Bbug+%2B296953">http://www.google.com/search?hl=en&amp;q=http://www.google.com/search?num=50&amp;hl=en&amp;q=%2Bgwibber+%2Bbug+%2B296953</a>'

So a naive fix (for testing) is now available in lp:~oldman/gwibber/bug-296953

Please test!

Changed in gwibber:
assignee: nobody → oldman
status: Confirmed → In Progress
Revision history for this message
Dominic Evans (oldmanuk) wrote :

Fix release into mainline.

Changed in gwibber:
milestone: none → 1.0
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.