The scribus.desktop file does not specify a category.

Thanks for reporting this bug and attempting to patch it. To get your fix included in Ubuntu, it would help if you tried transforming it into a debdiff (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submit it for review (http://wiki.ubuntu.com/SponsorshipProcess). If you prefer somebody else to do that, that's fine - please just indicate if you're available to do that.

The current debian/scribus.desktop file also fails to validate with desktop-file-validate. It would be great if your debdiff could fix this, since you are already patching the .desktop file to add a Categories tag.

Since this is a minor and easy task I will keep trying until I work it out. I'll open questions and ask on IRC if I get stuck.

Scribus appears in Office for me. (Hardy)

This is with netbook remix.

Where does it appear for you?

Caroline: that affects 1.3.3.12 which isn't in Hardy

The following debdiff should do the trick, although I'm still getting the pbuilder env up and running. If it works I'll subscribe ubuntu-main-sponsors to this bug.

Łukasz Jernaś, thank you for submitting a patch for this bug. However, Duncan Lithgow was already assigned to the bug, and he also had made a comment stating that he intended to fix this bug. Also, since this is a relatively minor issue, there is no reason that we can't wait a few weeks for a fix. In the future, please pay attention to these pieces of information to avoid duplication of efforts. Also, your patch does not modify the .desktop file to validate with desktop-file-validate like I recommended doing in Comment 2.

$ desktop-file-validate debian/scribus.desktop
debian/scribus.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
debian/scribus.desktop: error: value "application/vnd.scribus" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
debian/scribus.desktop: error: file contains multiple keys named "Comment[fa]" in group "Desktop Entry"
debian/scribus.desktop: error: file contains multiple keys named "Comment[lo]" in group "Desktop Entry"

Argh, sorry. I'll wait till Duncan fixes it by himself then, although in a few weeks we'll have the beta freeze, so it can be harder to get this sorted out.
BTW there's a better fix for that issue IMHO, because Scribus is already shipping a .desktop file by itself, but the install procedure is messed up a bit (some KDE related hack). Just see the vnd.scribus.desktop file.

In intrepid I get scribus in 'other'. Soon we will be in beta freeze so I'd personally rather have a half fix than a perfect one.

Yes please, anyone submit a patch. I haven't found time to learn how
to do it properly.

I'll prepare a debdiff to resolve this issue.

It appears that this simple merge might take some time to complete. Like I stated in my earlier comment, I would like to make the .desktop file validate with desktop-file-validate as long as I am touching it. I was able to resolve all but two warnings. The two remaining warnings are caused by the fact that there are two comments for two locales. The comments are:

Comment[fa]=اسکریباس
Comment[lo]=ສະຄຣີບັດສ໌
Comment[fa]=نشر میزکار
Comment[lo]=ເດດທອບພັລບບີດຊິງ

Thanks to some help, I was able to figure out that these comments (as well as the other comments in the file) are actually the Generic Name. You can see this by looking at the .desktop file in Hardy. The upstream .desktop file also has this issue. I am now trying to figure out exactly what happened. I am also trying to figure out why we stopped using the upstream .desktop file, and if it is still necessary to not use it.

I have attached the debdiff that I have made. It should successfully patch debian/scribus.desktop to make it appear in the Office menu. It also resolves some desktop-file-validate warnings. I would prefer to keep working on this bug to resolve the Comment/GenericName issue. As a result, I ask that you do NOT upload this debdiff yet. Thank you.

Well we've now released beta and may struggle to get ANYTHING into Intrepid. Any news?

Nathan, have you got anything more? I'm ready to upload this, but we need to do it ASAP.

Sorry for the long delay, but I think I finally have the .desktop file sorted out. Since the .desktop file in the hardy version of scribus has it show up in the Graphics category, that is what I made this .desktop file do. I also made the .desktop file validate with desktop-file-validate.

scribus (1.3.3.12.dfsg-1ubuntu2) intrepid; urgency=low

  * debian/scribus.desktop:
    * Add "Categories" field to make it appear properly in menu (LP: #261615)
    * Replace Comment[XX] fields with GenericName[XX] and Name[XX] fields
    * Modify to validate with desktop-file-validate

 -- Nathan Handler <email address hidden> Sun, 05 Oct 2008 21:34:28 -0500

This bug was fixed in the package scribus - 1.3.3.12.dfsg-1ubuntu2

---------------
scribus (1.3.3.12.dfsg-1ubuntu2) intrepid; urgency=low

  * debian/scribus.desktop:
    * Add "Categories" field to make it appear properly in menu (LP: #261615)
    * Replace Comment[XX] fields with GenericName[XX] and Name[XX] fields
    * Modify to validate with desktop-file-validate

 -- Nathan Handler <email address hidden> Sun, 05 Oct 2008 21:34:28 -0500

Thanks for that Nathan - hopefully some time I'll get time to learn how to do it the proper way.
Is anyone able to forward this upstream to Scribus: http://bugs.scribus.net/my_view_page.php ?

Duncan, since we are not using the .desktop file provided by upstream, there is no point sending this upstream to Scribus. However, I just verified that the .desktop file in the Debian package is the same as the one in the Ubuntu package. As a result, I have sent the patch upstream to Debian. I have also linked this bug report to the Debian one to make it easy to track the progress.

WIhy are we using a different file to upstream? It sounds like Debian
should pass their changes upstream unless the only difference is
debian specific.

* Caroline Ford <email address hidden> [2008-10-12 14:42:35 -0000]:

> WIhy are we using a different file to upstream? It sounds like Debian
> should pass their changes upstream unless the only difference is
> debian specific.

I've already committed the changes to upstream svn.

Regards,

Alex.

Caroline, I am not completely sure why we diverged from the upstream .desktop file. There was line that I found in the Debian/Ubuntu .desktop file that was not present in the upstream .desktop file. This line, "X-Ubuntu-Gettext-Domain=Scribus", appears to be used for translations. I have tried asking around to see if it is still needed, but nobody appeared to be completely sure. In the end, it was suggested that I just keep it there.

Alex, by upstream, are you referring to the scribus svn, or a Debian svn? Also, what changes did you commit?

* Nathan Handler <email address hidden> [2008-10-13 14:08:50 -0000]:

> Caroline, I am not completely sure why we diverged from the upstream
> .desktop file. There was line that I found in the Debian/Ubuntu .desktop
> file that was not present in the upstream .desktop file. This line, "X
> -Ubuntu-Gettext-Domain=Scribus", appears to be used for translations. I
> have tried asking around to see if it is still needed, but nobody
> appeared to be completely sure. In the end, it was suggested that I just
> keep it there.
>
> Alex, by upstream, are you referring to the scribus svn, or a Debian
> svn? Also, what changes did you commit?

I commited the attached desktop file into the scribus svn for both 1.3.3.x
branch and the trunk (1.3.5) that I am in the process of switching scribus-ng
package to. The only difference between those is below. I am a bit perplexed as
the result of these changes is not completely satisfactory. Only ScribusNG entry
appears in the "Graphics" category of the Gnome menu. Scribus is still in the
Other category. If there are other changes you'd like me to commit into scribus
svn, so we don't have to use a debian/scribus.desktop anymore I'd be happy to do
it. My latest packages in the upstream repository already use the upstream
.desktop file, which simplifies the debian packaging. If
X-Ubuntu-Gettext-Domain=Scribus is not needed then the files can be completely
unified between debian and ubuntu as well.

--- scribus.desktop 2008-10-09 13:16:45.000000000 -0600
+++ scribus-ng.desktop 2008-10-09 13:15:31.000000000 -0600
@@ -1,12 +1,12 @@
 [Desktop Entry]
 Encoding=UTF-8
 Type=Application
-Name=Scribus
-GenericName=Page Layout - Stable
+Name=ScribusNG
+GenericName=Page Layout - Development
 Categories=Graphics;Publishing;Qt;
 MimeType=application/vnd.scribus-ng
-Icon=scribus
-Exec=scribus %f
+Icon=scribus-ng
+Exec=scribus-ng %f
 GenericName=Page Layout and Publication (Stable)
 GenericName[ar]=سكريبس
 GenericName[fa]=اسکریباس

Regards,

Alex.