TypeError: pull() got an unexpected keyword argument '_override_hook_target'

Bug #259893 reported by Barry Warsaw
4
Affects Status Importance Assigned to Milestone
Bazaar
Invalid
Undecided
Unassigned
Loom
Fix Released
Undecided
Unassigned
bzr-loom (Ubuntu)
Fix Released
High
Martin Pitt

Bug Description

Trying to push a loomified branch, after all commits and records, to devpad gives me the following exception:

/usr/lib/python2.5/site-packages/bzrlib/decorators.py:138: DeprecationWarning: bzrlib.lockable_files.LockableFiles.get was deprecated in version 1.5.
  result = unbound(self, *args, **kwargs)
bzr: ERROR: exceptions.TypeError: pull() got an unexpected keyword argument '_override_hook_target'

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 857, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 802, in run
    use_existing_dir=use_existing_dir)
  File "/usr/lib/python2.5/site-packages/bzrlib/push.py", line 172, in _show_push_branch
    stop_revision=revision_id)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 138, in read_locked
    result = unbound(self, *args, **kwargs)
  File "/home/barry/.bazaar/plugins/loom/branch.py", line 548, in push
    return target.pull(self, overwrite=overwrite, stop_revision=stop_revision)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/remote.py", line 1584, in pull
    _override_hook_target=self, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
TypeError: pull() got an unexpected keyword argument '_override_hook_target'

bzr 1.6rc3 on python 2.5.2 (linux2)
arguments: ['/usr/bin/bzr', 'push']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bisect /home/barry/.bazaar/plugins/bisect [1.1.0pre0]
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.5.0]
  gtk /usr/lib/python2.5/site-packages/bzrlib/plugins/gtk [0.93.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  loom /home/barry/.bazaar/plugins/loom [1.4.0dev0]
  lpreview /home/barry/.bazaar/plugins/lpreview [unknown]
  pqm /usr/lib/python2.5/site-packages/bzrlib/plugins/pqm [1.3.0]
  touch /home/barry/.bazaar/plugins/touch.py [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

Revision history for this message
Robert Collins (lifeless) wrote :

out of date loom plugin

Changed in bzr:
status: New → Invalid
Revision history for this message
Barry Warsaw (barry) wrote :

% bzr info
Repository tree (format: unnamed)
Location:
  shared repository: /home/barry/projects/launchpad
  repository branch: .

Related branches:
  public branch: bzr+ssh://devpad.canonical.com/code/barry/launchpad/bug-237210
    push branch: bzr+ssh://devpad.canonical.com/code/barry/launchpad/bug-237210
  parent branch: /home/barry/projects/launchpad/rocketfuel
  submit branch: sftp://devpad.canonical.com/code/rocketfuel/launchpad/devel

If i blow away the push branch, the traceback doesn't happen

Revision history for this message
Gary Wilson (gary-wilson) wrote :

@Robert: do you mean that the OP is using an out of date loom version or that loom trunk has not been updated to work with 1.6 yet?

I'm using loom trunk r86 and am seeing this error.

Revision history for this message
Jonathan Lange (jml) wrote :

I'm using loom trunk r87 and get this error. Incredibly frustrating.

Revision history for this message
Vincent Ladeuil (vila) wrote :

As of loom@88

Changed in bzr-loom:
status: New → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

This currently blocks my work as well, I'll update the Ubuntu package.

Changed in bzr-loom:
assignee: nobody → pitti
importance: Undecided → High
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Hm, I prepared an updated package from upstream r90, but I still get the same error. Deleting the branch on Launchpad and pushing again didn't help, on second push I still get the very same error. Any idea?

Changed in bzr-loom:
status: Fix Released → Confirmed
status: In Progress → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

Sorry, ignore me. PEBCAK.

Changed in bzr-loom:
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr-loom - 1.4.0~bzr90-0ubuntu1

---------------
bzr-loom (1.4.0~bzr90-0ubuntu1) jaunty; urgency=low

  * Update to bzr trunk, to fix pushing to Launchpad. Previously, it
    crashed with a TypeError. (LP: #259893)

 -- Martin Pitt <email address hidden> Tue, 23 Dec 2008 13:44:15 +0100

Changed in bzr-loom:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.