Mythbuntu control center VNC setup freezes if & in password

Confirmed. I am working on a resolution for this now. Its actually caused by a script to change the password that is included in mythbuntu-common.

Applied a fix in Mythbuntu-Control-Centre on the method used to pass the password to the script. Tested the fix and it no longer locks up

SRU time!

This SRU will fix three bugs:

* bug #241402 (this one).
  - reason: this needs to be fixed because the control center shouldn't ever freeze.
  - how it was fixed: quote the password string properly

TEST CASE: enable VNC server, use '&' in password and hit "Apply". It should show you the progress bar and return you to the UI after a while.

* bug #224780 ("Optimize tables" button doesn't work):
  - reason: this is a regression from Ubuntu Gutsy where it used to work. It's import that users can repair their database in a nice, GUI-ish way.
  - how it was fixed: add some quotation marks to make 'su' happy
 It is also possible to use this button without installing optimize_mythdb.pl as a cron job first, which is much more intuitive.

TEST CASE: click "Optimize tables" button in the "Advanced Management" tab. You should see a terminal window and output from optimize_mythdb.pl. Of course, you need to have mysql-server and mythtv-backend installed and running.

* bug #233904 (can't disable auto login in MCC):
  - reason: MCC will let you enable auto login, but it can't be disabled currently. This is very confusing and annoying for our users.
  - how it was fixed: basically, just un-indent an if clause in the code

TEST CASE: enable automatic login in the "Artwork & Login Behavior" tab. Apply your changes. Now, disable automatic login and apply your changes. It should tell you that automatic login will be disabled.

I have also updated the translations in this upload. While they're not complete, it's better than having nothing. I'll attach the debdiff in a few minutes.

In case you are wondering about the version number being 0.28-0ubuntu1+hardy1: we need to supersede 0.28-0ubuntu1 which was published in a PPA.

debdiff mythbuntu-control-centre_0.28-0ubuntu1~hardy2.dsc mythbuntu-control-centre_0.28-0ubuntu1+hardy1.dsc > bug_241402_0.28-0ubuntu1~hardy2_to_0.28-0ubuntu1+hardy1.dsc

I'll be attaching another debdiff which fixes two additional bugs. The list of bug fixes I've posted previously still applies.

* bug #231065 (Don't bail out on empty lines in /etc/passwd)
If /etc/password contains an empty line, mythbuntu-control-centre will crash.

TEST CASE: Add empty line to your /etc/passwd, start MCC and watch it fall over. After applying the patch, it should start just fine. *CAUTION* messing with your /etc/passwd can result in a broken system! Do not try this unless you really know what you're doing!

* bug ##252323 (/etc/ltsp/dhcpd.conf never created)
If you choose "Add DHCP server" in the "System Roles" tab and apply your changes, /etc/ltsp/dhcpd.conf is not created. This file is crucial for booting diskless clients. The problem is easily fixed by using the correct package names in the code.
I've also sanitized the UI to prevent installation of the DHCP server unless mythbuntu-diskless-server is installed as well - this is necessary to prevent further breakage now that the bug fix is in place.

TEST CASE: Choose "Add DHCP server" in the "System Roles" tab and hit apply. After applying the patch, /etc/ltsp/dhcpd.conf should be created on your system.

Here comes the next debdiff. Apply on top of ~hardy2.

ACK from motu-sru. Source code changes are safe and detailed in test cases. Martin is OK with .po translation updates but they need to be tested properly, so adding a test case about how to check them would be good.

Speaking of versioning, I'd suggest 0.28-0ubuntu1~hardy3.

Luca Falavigna schrieb:
> Speaking of versioning, I'd suggest 0.28-0ubuntu1~hardy3.
>
We had an "unofficial" SRU in a PPA. The version number was
0.28-0ubuntu1, so we need 0.28-0ubuntu1+hardy1 to have a safe upgrade
path for that.

Accepted into hardy-proposed, please test.

Ok - Downloaded Hardy-proposed MCC and tested against :-
* bug #224780 ("Optimize tables" button doesn't work):

I can confirm that after installing Hardy-poposed MCC, this problem does not occur. :)

* bug #241402 (this one).

Used "&" in password after enabling VNC. Package appeared to do what it should, ending with pop-up box informing me to :=
Log Out for Changes to take effect. :)

* bug #233904 (can't disable auto login in MCC):
 Yes, now appears to allow user to disable & re-enable auto login. :)

Sorry I do not feel comfortable testing the remaining bugs, but i hope to have helped a little!

Any further info needed let me know!
Thanks.

This fix was already released for intrepid.

Version 0.28-0ubuntu1+hardy1 fixes the problem for me.

Copied to hardy-updates.

If the ~/.vnc/passwd file is missing completely setup fails also.