New .desktop file for KoverArtist

I have begun working on an updated koverartist package that includes a working koverartist.desktop file for Gnome. I have added French, German and Spanish to the English and Russian provided by Kirill Chunaev,

Jonathan

Thank you Jonathan! Maybe it is necessary to upload your new version of desktop file instead of my old version?

I could upload my improved .desktop file, but what I really need to do is attach a .debdiff for a my proposed updated koverartist package. I'm close on that, but need to fix up one more packaging issue first (the current package contains out of date config.guess and config.sub files and so the packaging system flags that as a problem). I hope to have this all done this evening (maybe 10 to 12 hours from now). Then we can get a MOTU to sponsor the upload, and the fix will be in Intrepid :-)

Jonathan

Here is my improved koverartist.desktop file.

Jonathan

Here is a (working, but not yet lintian-error-free) .debdiff .

I need help getting rid of the lintian errors (about config.guess and config.sub being too old, and the existence of config.log) before this will be good enough to be accepted into Ubuntu.

Kirill: I see you are listed as a mentor for this bug. Can you "mentor" me on fixing up this packaging issue, please? Advice from anyone else who can help is also welcome, of course.

Thanks,

Jonathan

About your new desktop fiile: 1) Please, remove word "quickly" that you've added in all non-Russian "Comment" sections. This word is unnecessary. 2) Replace "CD / DVD" for "CD/DVD" everywhere for a unified style.
About lintian errors: please, mail to Siegfried Gevatter (see subscribers list), because he has more experience than me in such things at this time.

Some comments:

>> By the way we may capitalize first letter of first word in the "Description" section of KoverArtist's debian/control. Why sentense begins from low-case letter?

Because according to policy the short description should start with a lower-case character. Unlike the .desktop file, it doesn't need to start with a verb, neither. Something like "graphical application" would be more appropriate than "Allows", there.

>> ++Comment[es]=Diseñe e imprima rápidamente las tapas de CDs o DVDs

That should rather be "Diseñe e imprima tapas para CDs o DVDs".

About the lintian warnings, you don't really have to worry about those.

OK, I've made the requested changes.

I'm concerned about the E: lines from lintian, but you are a MOTU, I'm just a beginner at Ubuntu packaging, so if you say they are OK... :-)

Here is a revised .debdiff file.

Jonathan

Siegfried: Is this now acceptable? Could you "sponsor" this upload? If there is anything further I can do to move this forward, please let me know.

Jonathan

Siegfried, what's wrong? Jonathan has published a resulting .debdiff file. Please, subscribe someone else if you haven't enough time for this package. I want to study REVU service in the near future for making such uploads partially by myself, so please, be patient...

I tested the debdiff but the resulting package failed to build (I haven't said anything here as Jonathan contacted me on IRC and I spoke there with him). The problem seemed to be transient, so I'm trying again to see if it works now...

@ Kirill: It isn't usual to directly subscribe random MOTUs to bug reports. If you want to get something sponsored in the future, subscribe the group ubuntu-universe-sponsors (or ubuntu-main-sponsors if the package is in main or restricted) and so someone who has time will look at it. Also note that REVU is only for new packages, not for fixes or updates.

Thanks for your interest in contributing to Ubuntu :).

It's still failing to build: http://launchpadlibrarian.net/16432064/buildlog_ubuntu-intrepid-i386.koverartist_0.5-0ubuntu2_FAILEDTOBUILD.txt.gz

Status: Even the original sources obtained with apt-get source koverartist fail to build under Intrepid, both in my PPA and in a pbuilder chroot here locally. They build fine under Hardy.

I'd guess this is an Intrepid merge bug of some kind, possible for something qt3 related, but I'm not certain enough to file a bug...

At this point it looks like we are stuck until either (a) we figure out exactly what is failing and so can file a bug about it; or (b) someone else fixes the issue for us in Intrepid.

Jonathan

By the way, please forward your changes to Debian.

Dear friends, maybe we can try to build this package again? What do you think about it?
Incidentally, Siegfried, there isn't "koverartist" package in Debian...

> Dear friends, maybe we can try to build this package again?

OK, I've initiated retries of my July PPA builds, let's see if they work now.

Of course, since we now need to target Jaunty, I'll need to get updated development tools and then redo a package for that release, if this actually works...

It fails, see http://launchpadlibrarian.net/19452222/buildlog_ubuntu-intrepid-i386.koverartist_0.5-0ubuntu2~jmarsden1_FAILEDTOBUILD.txt.gz

Looks like a C++ compilation issue, which is odd, since we didn't do anything to the source code at all -- unless the new compilers in Intrepid pick up things that were not errors in earlier versions?

Any pointers on how to work around this are welcome.

You could try adding "#include <cstdlib>" to the header of the file which is failing to build.

OK, here is my latest debdiff with that #include in there. It seems to build OK for me. I'd still like to get rid of those pesky lintian errors if possible, though:

 W: koverartist source: configure-generated-file-in-source config.log
 E: koverartist source: outdated-autotools-helper-file admin/config.guess 2002-10-21
 E: koverartist source: outdated-autotools-helper-file admin/config.sub 2002-09-05

I've now posted an Intrepid version of this to my PPA. Apparently PPAs do not yet know how to build for Jaunty.

Kirill: If you want, you can add

  deb http://ppa.launchpad.net/jmarsden/ubuntu intrepid main
  deb-src http://ppa.launchpad.net/jmarsden/ubuntu intrepid main

to your /etc/apt/sources.list and then apt-get koverartist to download and install this version so you can test it.

I've tested your new package, Jonathan. In my opinion there aren't any problems. Try to build new package for official Ubuntu repository. Further I'll mail to the author of KoverArtist to ask him for new version (maybe KDE4-version).

You are right in that we should fix everything we can in this package, as it is maintained in Ubuntu. I had missed that before sorry.

About the lintian warning, you have already fixed it! Lintian still complains because it is fixed at build time, and the fix is reverted after that (which is good, as this way we don't pollute the .diff.gz). So, here we can either consider the warnings as fixed and ignore them, or tell lintian that we want it to ignore them (using an override). As lintian's complain don't harm anyone I think we are perfectly fine just leaving it like it is now :).

Anyway, back to your last debdiff. I've reviewed it and uploaded it with some little modifications. Between those, I added a Catalan translation to the new .desktop file and improved debian/copyright, but, most important of all I fixed this mistake:

- The version number should be 0ubuntu2, not 0ubuntu3 (you skipped a number) :).

Still, good work, and thanks for your contribution to Ubuntu!

This bug was fixed in the package koverartist - 0.5-0ubuntu2

---------------
koverartist (0.5-0ubuntu2) jaunty; urgency=low

  [ Jonathan Marsden ]
  * debian/patches/02_include_cstdlib_for_cddbquery.patch:
    - Included <cstdlib> in cddbquery.h so cddbquery.cpp will compile
  * debian/patches/01_replace_desktop_file.patch:
    - Replaced existing (auto-generated?) .desktop file with a
      koverartist-specific one
    - Added French, German, Spanish, Russian i18n to new .desktop file
    - Closes (LP: #236140)
  * debian/control:
    - Updated Standards-Version to 3.8.0
    - Improved description of the package
  * debian/rules:
    - Uncomment simple-patchsys include
    - Install .desktop file into /usr/share/applications/kde
    - Use current config.sub and config.guess files to keep lintian happy

  [ Siegfried-Angel Gevatter Pujals ]
  * debian/patches/01_replace_desktop_file.patch:
     - Add Catalan translation for GenericName and Description.
  * debian/copyright:
     - Add proper copyright declarations.

 -- Jonathan Marsden <email address hidden> Tue, 11 Nov 2008 00:43:29 +0100

Siegfried Gevatter (RainCT) wrote:

> About the lintian warning, you have already fixed it! Lintian still
> complains because it is fixed at build time, and the fix is reverted
> after that (which is good, as this way we don't pollute the .diff.gz).
> So, here we can either consider the warnings as fixed and ignore them,
> or tell lintian that we want it to ignore them (using an override). As
> lintian's complain don't harm anyone I think we are perfectly fine just
> leaving it like it is now :).

OK, thanks. I tried to fix it (apparently successfully!) but was
confused that lintian kept telling me the issue still existed :-)

> Anyway, back to your last debdiff. I've reviewed it and uploaded it with
> some little modifications. Between those, I added a Catalan translation
> to the new .desktop file and improved debian/copyright, but, most
> important of all I fixed this mistake:
>
> - The version number should be 0ubuntu2, not 0ubuntu3 (you skipped a
> number) :).

Well... yes. I made a 0ubuntu2 earlier (July?), and then bumped it
(using dch -i) to 0ubuntu3 recently, so the PPA wouldn't complain when I
uploaded the "newest" version of my fix there to test build it on
something other than my own machine... I didn't realize the version
numbering *had* to be sequential, as long as the newer one is bigger
than the previous one (and in the correct format). Thanks for catching
that.

Jonathan