Screenlets

unnecessary updates when screenlets are unmapped

Bug #211525 reported by criser on 2008-04-03

Affects		Status	Importance	Assigned to	Milestone
	Screenlets	Fix Released	Undecided	Unassigned
	screenlets (Ubuntu)	Fix Released	Low	Kjell Braden

Bug Description

when screenlets are used in conjunction with compiz's 'widget mode' they are only mapped and visible when compiz is in widget mode
so it is unnecessary and produces higher power consumption on machines that rely on battery to update the screenlets data
the patch included adds two new callback functions to a screenlet to notify them of map and unmap events so that each individual screenlet can disable/enable any polling in the corresponding functions
I already updated the SysmonitorScreenlet and the ClearCalendarScreenlet to make use of this feature

Revision history for this message

criser (devel-god) wrote on 2008-04-03:

patch to implement map/unmap events Edit (3.2 KiB, text/plain)

Revision history for this message

Kjell Braden (afflux) wrote on 2008-04-05:

Looks good to me. Will prepare a debdiff with this and other fixes in the next few days as ubuntu will freeze next week.

Changed in screenlets:
assignee:	nobody → afflux
importance:	Undecided → Low
status:	New → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2008-04-07:

This bug was fixed in the package screenlets - 0.0.12-0ubuntu4

---------------
screenlets (0.0.12-0ubuntu4) hardy; urgency=low

  * This is a bugfix upload. (LP: #213385)
  * debian/patches/10-problem-on-create-tmpfile.patch: dropped, didn't fix the
    issue
  * new patches from upstream:
    - debian/patches/15_better-daemon-running-check.patch: fix daemon starting
      multiple times (LP: #205526)
    - debian/patches/16_fix-option-theme-dialog-crashing.patch: fix a crash
      occuring in some theme dialogues (LP: #195036)
    - debian/patches/17_fix-crash-on-invalid-archive.patch: fix a crash
      occuring when trying to open broken screenlet packages (LP: #205526)
  * new patches from ubuntu:
    - debian/patches/14_no-unnecessary-updates-when-unmapped.patch: don't
      update the screenlets when they are not mapped, thanks criser
      (LP: #211525)
    - debian/patches/18_fix-crashing-on-invalid-sensor-type.patch: fix a crash
      occuring in the sensor applet when a bad device was selected for
      monitoring (LP: #198675)
    - debian/patches/19_fix-creating-tempfile.patch: improve the error
      handling when initializing the tempfile (LP: #197712, #212175)