DEP8 failures in noble, all arches

Bug #2060536 reported by Andreas Hasenack
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
crmsh (Debian)
Fix Released
Unknown
crmsh (Ubuntu)
Fix Released
Undecided
Athos Ribeiro

Bug Description

https://autopkgtest.ubuntu.com/packages/c/crmsh/noble/amd64

https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/amd64/c/crmsh/20240407_073428_9de69@/log.gz

Only test failing in testsuite.sh:
2859s ______________________ TestUtils.test_findln_by_timestamp ______________________
2859s
2859s self = <unittests.test_report_utils.TestUtils testMethod=test_findln_by_timestamp>
2859s
2859s def test_findln_by_timestamp(self):
2859s target_time = "Apr 03 13:10"
2859s target_time_stamp = crmutils.parse_to_timestamp(target_time+' 2023')
2859s with open('pacemaker.log') as f:
2859s data = f.read()
2859s constants.STAMP_TYPE = utils.determin_log_format(data)
2859s pacemaker_file_path = "pacemaker.log"
2859s result_line = utils.findln_by_timestamp(data, target_time_stamp, pacemaker_file_path)
2859s > result_line_stamp = utils.get_timestamp(data.split('\n')[result_line-1], pacemaker_file_path)
2859s E TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'
2859s
2859s test_report_utils.py:825: TypeError

Related branches

Changed in crmsh (Debian):
status: Unknown → New
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

The migration reference tests are also failing.

Reproducer:

From the source package root:

$ mkvirtualenv crmsh
$ pip install -r requirements.txt
$ pip install pytest
$ cd test/unittests/
$ PYTHONPATH=../../ python -m pytest

Changed in crmsh (Ubuntu):
status: New → Triaged
tags: added: server-todo
Changed in crmsh (Ubuntu):
assignee: nobody → Athos Ribeiro (athos-ribeiro)
Changed in crmsh (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package crmsh - 4.6.0-1ubuntu2

---------------
crmsh (4.6.0-1ubuntu2) noble; urgency=medium

    - d/p/fix-findln-by-timestamp-test.patch: fix failing unit test.
      (Closes: #1068562) (LP: #2060536)

 -- Athos Ribeiro <email address hidden> Wed, 10 Apr 2024 16:14:45 -0300

Changed in crmsh (Ubuntu):
status: Fix Committed → Fix Released
Changed in crmsh (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.