Improve ssh-gssapi DEP8 test

Bug #2058276 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openssh (Ubuntu)
Fix Released
High
Andreas Hasenack

Bug Description

The DEP8 test introduced in https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/2053146 could still show s PASS even when the login didn't work. This is because it's relying on `set -e` to work inside functions, but that's not the case.

For example, here I forced a failure by using an invalid user (I added "x" to the username):
```
## ssh'ing into localhost using gssapi-keyex auth
<email address hidden>: Permission denied (gssapi-keyex).

## checking that we got a service ticket for ssh (host/)
03/18/24 12:16:55 03/18/24 22:16:55 host/sshd-gssapi.example.fake@
 Ticket server: <email address hidden>

## Checking ssh logs to confirm gssapi-keyex auth was used
Mar 18 12:16:55 sshd-gssapi.example.fake sshd[22994]: Failed gssapi-keyex for invalid user testuser22924x from 127.0.0.1 port 39550 ssh2: <email address hidden>
## PASS test_gssapi_keyex_login

```

Furthermore, the --grep option used in journalctl is not specific enough, as can also be seen above. It's just looking for the authentication method name, not whether is succeeded or not.

Related branches

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package openssh - 1:9.6p1-3ubuntu11

---------------
openssh (1:9.6p1-3ubuntu11) noble; urgency=medium

  * d/t/ssh-gssapi: make the test a bit more rebust (LP: #2058276):
    - deal with return codes
    - match a more specific success expression from the logs
    - add klist output in the case of failure

 -- Andreas Hasenack <email address hidden> Mon, 18 Mar 2024 10:25:15 -0300

Changed in openssh (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.