2.14.0-2 FTBFS in hardy

Bug #203978 reported by Hanno Stock (hefe_bia)
2
Affects Status Importance Assigned to Milestone
Cedar Backup
Unknown
Unknown
cedar-backup2 (Ubuntu)
Fix Released
Medium
Luca Falavigna

Bug Description

Binary package hint: cedar-backup2

This seems to be a Python 2.4/2.5 problem:
 From the build log:

======================================================================
ERROR: testConstructor_004 (test.splittests.TestByteQuantity)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/splittests.py", line 224, in testConstructor_004
    quantity.quantity = "0xAC"
  File "./CedarBackup2/extend/split.py", line 173, in _setQuantity
    floatValue = float(value)
ValueError: invalid literal for float(): 0xAC

======================================================================
ERROR: testConstructor_006 (test.configtests.TestBlankBehavior)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/configtests.py", line 1086, in testConstructor_006
    behavior.blankFactor = "0xAC"
  File "./CedarBackup2/config.py", line 723, in _setBlankFactor
    floatValue = float(value)
ValueError: invalid literal for float(): 0xAC

----------------------------------------------------------------------
Ran 3049 tests in 38.621s

This is fixed in newer releases.

Revision history for this message
Hanno Stock (hefe_bia) (hanno-stock) wrote :

I'm working on a fix.

Changed in cedar-backup2:
assignee: nobody → hanno-stock
status: New → In Progress
Changed in cedar-backup:
importance: Undecided → Unknown
status: New → Unknown
Revision history for this message
Hanno Stock (hefe_bia) (hanno-stock) wrote :

Changes:
 cedar-backup2 (2.14.0-2ubuntu1) hardy; urgency=low
 .
   * Included patch for compatibility with Python 2.5 (LP: #203978)
   * Added quilt as a build dependency, updated debian/rules

The problem was that Python 2.5 does not accept hex literals for floats anymore, but this was tested in constructor tests.
The fix is taken from upstream. (It's a small, isolated code change)

Debdiff attached.

Changed in cedar-backup2:
assignee: hanno-stock → nobody
status: In Progress → Confirmed
Revision history for this message
Hanno Stock (hefe_bia) (hanno-stock) wrote :

Also see: http://sourceforge.net/project/shownotes.php?release_id=574617&group_id=210468 (Changelog)
"This was a test-only bug, and there
was no functional impact."

Revision history for this message
Hanno Stock (hefe_bia) (hanno-stock) wrote :

Sorry, forgot to attach the debdiff

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

It still FTBFS on my pbuilder. You have to adjust debian rules to apply quilt patches:
-build: build-stamp
+build: patch build-stamp
-clean:
+clean: unpatch

Also, you need to import hexFloatLiteralAllowed since your patch produce NameError exception:
NameError: global name 'hexFloatLiteralAllowed' is not defined

Changed in cedar-backup2:
assignee: nobody → hanno-stock
importance: Undecided → Medium
status: Confirmed → Incomplete
Revision history for this message
Hanno Stock (hefe_bia) (hanno-stock) wrote :

I'm sorry, I must have been overworked that day. I attached the wrong debdiff.
Here's the debdiff with quilt enabled and hexFloatLiteralAllowed imported.

Changed in cedar-backup2:
assignee: hanno-stock → nobody
status: Incomplete → Confirmed
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Now it's good, thanks ;)

Changed in cedar-backup2:
assignee: nobody → dktrkranz
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cedar-backup2 - 2.14.0-2ubuntu1

---------------
cedar-backup2 (2.14.0-2ubuntu1) hardy; urgency=low

  * Included patch for compatibility with Python 2.5 (LP: #203978)
  * Added quilt as a build dependency, updated debian/rules

 -- Hanno Stock <email address hidden> Wed, 19 Mar 2008 19:26:23 +0100

Changed in cedar-backup2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.