Ubuntu
ubiquity package

ftbfs with tzdata >= 2023c-8

Bug #2031838 reported by Michael Hudson-Doyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
High
Benjamin Drung

Bug Description

With https://code.launchpad.net/~mwhudson/ubiquity/+git/ubiquity/+merge/449391 applied, the ubiquity build now fails with:

test_city_entry (test_timezone.TimezoneTests.test_city_entry) ... /usr/lib/python3/dist-packages/mock/mock.py:1238: PyGIWarning: Soup was imported without specifying a version first. Use gi.require_version('Soup', '2.4') before import to ensure that the right version gets loaded.
  __import__(import_path)
Could not understand timezone Canada/Eastern
Could not understand timezone US/Eastern
FAIL

which is presumably related to the deprecation of these timezone names. I can think of a few ways to fix this (build-depend on tzdata-legacy, remove the functionality being tested here as these names have been deprecated for ages, probably some other things...) but I don't know which is right so I'm filing a bug.

Revision history for this message
Benjamin Drung (bdrung) wrote :

test_city_entry needs to be updated to not use a legacy timezone name, but sadly this is not enough.

Page.zones lacks several zones for that. The culprit lies in Page.build_timezone_list and Page.build_shortlist_timezone_pairs. Further investigation is needed.

Revision history for this message
Benjamin Drung (bdrung) wrote :

Found d-i/source/tzsetup which is a code copy of tzsetup 1:0.94ubuntu2 before it was removed from the archive. We probably have to merge 1:0.122 from Debian.

Revision history for this message
Benjamin Drung (bdrung) wrote :

We need to update the legcay timezones names (since they are only shipped by tzdata-legacy): https://salsa.debian.org/installer-team/tzsetup/-/merge_requests/4

Benjamin Drung (bdrung)
Changed in ubiquity (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 23.10.3

---------------
ubiquity (23.10.3) mantic; urgency=medium

  [ Michael Hudson-Doyle ]
  * Cherry pick the fix for Debian bug #1040048 to fix build with new
    ncurses-bin.

  [ David Mohammed ]
  * Don't display a panel for budgie-wm

  [ Benjamin Drung ]
  * Update legacy timezones in tzsetup (LP: #2031838)

 -- Benjamin Drung <email address hidden> Tue, 12 Sep 2023 14:40:23 +0200

Changed in ubiquity (Ubuntu):
status: Fix Committed → Fix Released
Benjamin Drung (bdrung)
tags: removed: foundations-todo
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.