fsck/usplash integration misbehaves without "quiet"

Attaching recommended fix. Additionally:
 - fixes needless CPU spin while waiting for fsck to start up.
 - uses usplash progress bar for fsck progress (since it will reset when rcS.d continues)

Hi Kees,

Kees Cook [2008-03-09 17:20 -0700]:
> Additionally, I have some changes to the fsck script I'd like to get you
> to look at. I've attached it to bug 200391. It contains several
> changes in the usplash behavior:
>
> 1:does not use "CLEAR" any more -- this is wrong when booting without
> "quiet", and seems like a problem for people trying to report issues
> in the fsck stage (the screen would get cleared after it finishes).

Makes sense.

> 2:only performs usplash clean-up if output was started (in the case that
> you don't like change #1, this keeps the text log from being cleared
> when all the filesystems are clean and you've booted without "quiet").

That too.

> 3:fixes needless spin while waiting for fsck to start up

Ah, thanks.

> 4:uses usplash progress bar instead of status line to report percentage.
> I personally think this is much more user-friendly, as they can see
> the progress much more clearly. Once the fsck finishes, the progress
> bar will return to the expected percentage when rcS.d continues.

That was in fact my first implementation, but after discussion with
mpt I changed it back to always keep the overall boot status in the
progress bar and report the fsck progress textually (IRC log below
FYI). Primary reason is that we cannot use a different color or other
indication that this is a 'sub'progressbar.

Thanks,

Martin

2008 Feb 12 11:30:19 <pitti> I currently hijack the progress bar to show the fsck progress
2008 Feb 12 11:30:25 <pitti> which means that it'll jump around a little
2008 Feb 12 11:30:39 <pitti> (i. e. used for init script progress, then fsck progress, then again init script
 progress
2008 Feb 12 11:30:52 <pitti> I'd like to use a different colour for fsck, but usplash currently doesn't allow
 that
2008 Feb 12 11:30:55 <TheMuso> Better than nothing.
2008 Feb 12 11:31:03 <pitti> it's probably good enough for a first upload
2008 Feb 12 11:31:08 <mpt> hrm
2008 Feb 12 11:31:15 <pitti> mpt: WDYT? should I use the progress bar or output some text
2008 Feb 12 11:31:19 <cjwatson> pitti: ooh, congratulations
2008 Feb 12 11:31:19 <pitti> (like percentage)
2008 Feb 12 11:31:24 <cjwatson> pitti: which fsck backends does it support?
2008 Feb 12 11:31:43 <pitti> cjwatson: only ext3 actually provides progress reading
2008 Feb 12 11:31:47 <mpt> pitti, how soon in the progress bar do/can you find out that you need to do fsck?
2008 Feb 12 11:31:56 <pitti> I'll check it in a bit how it looks with reiser and xfs
2008 Feb 12 11:32:25 <pitti> rcS.d/S30checkfs.sh
2008 Feb 12 11:32:36 <pitti> should be fairly early
2008 Feb 12 11:32:42 <pitti> I didn't run a complete boot yet
2008 Feb 12 11:32:47 <cjwatson> but only when fsck actually starts
2008 Feb 12 11:32:48 <mpt> pitti, I mean, do you know that you'll have to do a fsck before the progress bar begins?
2008 Feb 12 11:32:49 <pitti> I just start usplash and checkfs. manually
2008 Feb 12 11:33:02 <pitti> right, what cjwatson said
2008 Feb 12 11:33:39 <pitti> mpt: let me test this with a real boot and come back to describe how it looks li
ke in the entire boot sequence
2008 Feb 12 11:33:51 <mpt> ok
2008 Feb 12 11:40:52 <pitti> mp...

This bug was fixed in the package sysvinit - 2.86.ds1-14.1ubuntu40

---------------
sysvinit (2.86.ds1-14.1ubuntu40) hardy; urgency=low

  * debian/initscripts/lib/init/usplash-fsck-functions.sh:
    - Do not spin while waiting for fsck to start.
    - Do not clear usplash text ("quiet" may be disabled).
    - Fix status message if fsck was cancelled.
    - Based on Kees Cook's patch, thank you!
    - LP: #200391

 -- Martin Pitt <email address hidden> Wed, 12 Mar 2008 15:37:33 +0100