bionic upstream branch fails to build: missing autoconf files
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| update-notifier (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
| Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
[Original Description]
The bionic upstream branch of update-notifier[1] currently FTBFSs.
Compared to the source package in the ubuntu bionic archive (which builds just fine), it's missing the generated autoconf files:
$ git diff pkg/ubuntu/
Makefile.in | 808 ---
aclocal.m4 | 2290 ----------
b/.gitignore | 31
b/debian/changelog | 10
b/debian/control | 2
compile | 347 -
configure | 9127 -------
data/Makefile.in | 649 ---
depcomp | 791 ---
install-sh | 508 --
missing | 215 -
pixmaps/
pixmaps/
pixmaps/
pixmaps/
pixmaps/
pixmaps/
po/Makefile.in.in | 221 -
src/Makefile.in | 715 ---
ui/Makefile.in | 494 --
153 files changed, 17378 insertions(+), 32241 deletions(-)
All other upstream branches in update-notifier have those files removed, but d/rules was adapted to generate them:
$ git diff upstream/
diff --git a/debian/rules b/debian/rules
index c67232ec..73fe23e5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,7 +3,15 @@ export CFLAGS += -Wall -g -O$(if $(findstring noopt,$
export LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
%:
- dh $@ --with python3
+ dh $@ --with python3 --with autoreconf
+
+override_
+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
+
+override_
+ dh_auto_configure -- --libdir=/usr/lib
override_
cd tests && python3 test_package-
+ cd tests && python3 test_motd.py
+
We should either generate these files at build time, like the other upstream branches, or include them in the bionic repository, like the current package in the bionic ubuntu archive has it[1]
1. https:/
[Impact]
This will fix FTBFSs errors when building the package by bringing the autoconf file from the package in archive
[Test Case]
Check if the package can now build without FTBFSs errors
[Regression Potential]
We are just bringing autoconf files directly from the package in archive. Because of that, we believe regressions here are very unlikely. However,
if we have a problem, we believe this will affect the package build directly, which will prevent this SRU for taking place.
[Discussion]
In the previous SRU, those files were manually imported by the reviewer to make the build pass. Since we want to avoid this step in the future, we are bringing those files for this SRU now.
[Changelog]
* po/*.po: do no translate template variable needed for
package-
* Bring generated autoconf files from the archive package (LP: #1999897)
| summary: |
- bionic branch fails to build: missing autoconf files + bionic upstream branch fails to build: missing autoconf files |
| Andreas Hasenack (ahasenack) wrote | #1 |
| description: | updated |
| Changed in update-notifier (Ubuntu): | |
| status: | New → Invalid |
| Andreas Hasenack (ahasenack) wrote Please test proposed package | #2 |
| Changed in update-notifier (Ubuntu Bionic): | |
| status: | New → Fix Committed |
| tags: | added: verification-needed verification-needed-bionic |
| description: | updated |
| tags: |
added: verification-done verification-done-bionic removed: verification-needed verification-needed-bionic |
| Andreas Hasenack (ahasenack) wrote | #3 |
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in update-notifier (Ubuntu Bionic): | |
| status: | Fix Committed → Fix Released |
| Andreas Hasenack (ahasenack) wrote Update Released | #5 |
If calling autogen.sh in the bionic branch, there is another discrepancy: it wants gnome-common to be installed as a build-dep, but that is not declared in d/control.
It was dropped[1] in later commits to other branches. For example, focal:
commit 38a5a75dcd3586c
Author: Sebastien Bacher <email address hidden>
Date: Tue Mar 19 11:17:55 2019 +0100
* debian/control, autogen.sh:
- don't build-depends on gnome-common, that is deprecated and was
comment out in the autogen.sh already anyway
1. https:/