Retry "button" drops all-proposed flag

Bug #1999163 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Auto Package Testing
Triaged
Undecided
Unassigned

Bug Description

In https://autopkgtest.ubuntu.com/packages/h/htslib/lunar/amd64, you can see:

1) A test triggered by vorlon timestamped 2022-11-28 19:26:59 UTC (https://autopkgtest.ubuntu.com/results/autopkgtest-lunar/lunar/amd64/h/htslib/20221128_192659_ff93e@/log.gz)

2) A test triggered by racb timestamped 2022-11-30 10:20:55 UTC (https://autopkgtest.ubuntu.com/results/autopkgtest-lunar/lunar/amd64/h/htslib/20221130_102055_f8a4e@/log.gz)

racb's test was done by using the retry option next to vorlon's test. But they came out differently. You can see that the Version in the first column is different. But also, from the logs themselves:

autopkgtest [19:17:16]: host juju-4d1272-prod-proposed-migration-9; command line: /home/ubuntu/autopkgtest/runner/autopkgtest --output-dir /tmp/autopkgtest-work.bvx2d0es/out --timeout-copy=6000 --setup-commands /home/ubuntu/autopkgtest-cloud/worker-config-production/setup-canonical.sh --setup-commands /home/ubuntu/autopkgtest/setup-commands/setup-testbed --apt-pocket=proposed --apt-upgrade htslib --timeout-short=300 --timeout-copy=20000 --timeout-build=20000 '--env=ADT_TEST_TRIGGERS=xz-utils/5.2.8-0.0 zlib/1:1.2.13.dfsg-1ubuntu2 openssl/3.0.5-2ubuntu2 htscodecs/1.3.0-4 htslib/1.16+ds-3 libdeflate/1.14-1 perl/5.36.0-4ubuntu2' -- ssh -s /home/ubuntu/autopkgtest/ssh-setup/nova -- --flavor autopkgtest --security-groups <email address hidden> --name adt-lunar-amd64-htslib-20221128-191716-juju-4d1272-prod-proposed-migration-9 --image adt/ubuntu-lunar-amd64-server --keyname testbed-juju-4d1272-prod-proposed-migration-9 --net-id=net_prod-proposed-migration -e TERM=linux -e ''"'"'http_proxy=http://squid.internal:3128'"'"'' -e ''"'"'https_proxy=http://squid.internal:3128'"'"'' -e ''"'"'no_proxy=127.0.0.1,127.0.1.1,localhost,localdomain,novalocal,internal,archive.ubuntu.com,ports.ubuntu.com,security.ubuntu.com,ddebs.ubuntu.com,changelogs.ubuntu.com,launchpad.net,10.24.0.0/24'"'"'' --mirror=http://ftpmaster.internal/ubuntu/

autopkgtest [10:10:35]: host juju-4d1272-prod-proposed-migration-9; command line: /home/ubuntu/autopkgtest/runner/autopkgtest --output-dir /tmp/autopkgtest-work.1irbarlz/out --timeout-copy=6000 --setup-commands /home/ubuntu/autopkgtest-cloud/worker-config-production/setup-canonical.sh --setup-commands /home/ubuntu/autopkgtest/setup-commands/setup-testbed --apt-pocket=proposed=src:xz-utils,src:zlib,src:openssl,src:htscodecs,src:htslib,src:libdeflate,src:perl --apt-upgrade htslib --timeout-short=300 --timeout-copy=20000 --timeout-build=20000 '--env=ADT_TEST_TRIGGERS=xz-utils/5.2.8-0.0 zlib/1:1.2.13.dfsg-1ubuntu2 openssl/3.0.5-2ubuntu2 htscodecs/1.3.0-4 htslib/1.16+ds-3 libdeflate/1.14-1 perl/5.36.0-4ubuntu2' -- ssh -s /home/ubuntu/autopkgtest/ssh-setup/nova -- --flavor autopkgtest --security-groups <email address hidden> --name adt-lunar-amd64-htslib-20221130-101034-juju-4d1272-prod-proposed-migration-9 --image adt/ubuntu-lunar-amd64-server --keyname testbed-juju-4d1272-prod-proposed-migration-9 --net-id=net_prod-proposed-migration -e TERM=linux -e ''"'"'http_proxy=http://squid.internal:3128'"'"'' -e ''"'"'https_proxy=http://squid.internal:3128'"'"'' -e ''"'"'no_proxy=127.0.0.1,127.0.1.1,localhost,localdomain,novalocal,internal,archive.ubuntu.com,ports.ubuntu.com,security.ubuntu.com,ddebs.ubuntu.com,changelogs.ubuntu.com,launchpad.net,10.24.0.0/24'"'"'' --mirror=http://ftpmaster.internal/ubuntu/

You can see that the --apt-pocket=proposed parameter was different. In this thread the conclusion was that this appears to be a bug: https://lists.ubuntu.com/archives/ubuntu-devel/2022-December/042376.html

Expected behaviour: if I hit the retry button, the exact same parameters will be used for the retest.

Actual behaviour: different parameters were used; it seems like the "all-proposed" flag was dropped.

Tags: adt-179

Related branches

Revision history for this message
Paride Legovini (paride) wrote :

Hi Robie, I agree that all-proposed should be preserved in retries. This is unfortunately not as easy to fix as it may seem, as the status of the all-proposed flag is not saved in the autopkgtest database, so the web interface has no way to know if a test was triggered with all-proposed or not.

I think saving the status of all-proposed in the database is reasonable. To be discussed if it belongs to the 'test' table or 'result' table. I'd say 'test' as it's something that determines the test environment, but the triggers are saved in the 'result' table, despite not being results...

Changed in auto-package-testing:
status: New → Triaged
tags: added: adt-179
Revision history for this message
Tim Andersson (andersson123) wrote :

MP with a fix for this ready for review

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.