kselftest net/fib_nexthop_nongw.sh fails

Bug #1998244 reported by Thadeu Lima de Souza Cascardo
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux-kvm (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned
Lunar
Fix Released
Undecided
Unassigned

Bug Description

18272 03:33:07 DEBUG| Persistent state client._record_indent now set to 2
      18273 03:33:07 DEBUG| Persistent state client.unexpected_reboot now set to ('ubuntu_kernel_selftests.net:fib_nexthop_nongw.sh', 'ubuntu_kernel_selftests.net:fib_nexthop_nongw.sh')
      18274 03:33:07 DEBUG| Waiting for pid 58525 for 2700 seconds
      18275 03:33:07 WARNI| System python is too old, crash handling disabled
      18276 03:33:07 DEBUG| Running 'make run_tests -C net TEST_PROGS=fib_nexthop_nongw.sh TEST_GEN_PROGS='' TEST_CUSTOM_PROGS='''
      18277 03:33:07 DEBUG| [stdout] make: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net'
      18278 03:33:07 DEBUG| [stdout] make --no-builtin-rules ARCH=x86 -C ../../../.. headers_install
      18279 03:33:07 DEBUG| [stdout] make[1]: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux'
      18280 03:33:08 DEBUG| [stdout] INSTALL ./usr/include
      18281 03:33:08 DEBUG| [stdout] make[1]: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux'
      18282 03:33:08 DEBUG| [stdout] TAP version 13
      18283 03:33:08 DEBUG| [stdout] 1..1
      18284 03:33:08 DEBUG| [stdout] # selftests: net: fib_nexthop_nongw.sh
      18285 03:33:08 DEBUG| [stdout] # Error: Unknown device type.
      18286 03:33:08 DEBUG| [stdout] # Cannot find device "eth0"
      18287 03:33:08 DEBUG| [stdout] # Cannot find device "eth0"
      18288 03:33:08 DEBUG| [stdout] # TEST: nexthop: get route with nexthop without gw [ OK ]
      18289 03:33:18 DEBUG| [stdout] # TEST: nexthop: ping through nexthop without gw [FAIL]
      18290 03:33:18 DEBUG| [stdout] not ok 1 selftests: net: fib_nexthop_nongw.sh # exit=1
      18291 03:33:18 DEBUG| [stdout] make: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net'

--------------------------------------------------------------------------

SRU Justification:

[Impact]

* Without Kernel support for the Dummy net driver, it is not possible to successfully run selftests that use it. This includes as per this bug net/fib_nexthop_nongw.sh, but also could potentially include other such as rtnetlink.sh, fib_rule_tests.sh, forwarding/* etc.

[Fix]

* Custom patch to enable CONFIG_DUMMY=m

[Test Plan]

* Before the fix, the net/fib_nexthop_nongw.sh script will fail in the specific line which does

$ ip -n h1 link add name eth0 type dummy
Error: Unknown device type.

After the fix it does not fail.

[Where problems could occur]

* The regression can be considered as low, since we are adding functionality not previously present.

[Other Info]

* There does not seem to be a historical reason for removing it from linux-kvm.

summary: - fib_nexthop_nongw.sh
+ kselftest net/fib_nexthop_nongw.sh fails
Revision history for this message
Jose Ogando Justo (joseogando) wrote :

Hello!

I have investigated further on this bug.

It is failing because the kernel does not contain dummy net driver. Then adding a dummy interface fails.

Command:

$ ip -n h1 link add name eth0 type dummy
Error: Unknown device type.

Module missing (From generic example):

/lib/modules/5.15.0-57-generic/kernel/drivers/net/dummy.ko

Do we want to make an equivalent test, or include the module? I would say the latter.

description: updated
Changed in linux-kvm (Ubuntu Lunar):
status: New → Confirmed
Changed in linux-kvm (Ubuntu Kinetic):
status: New → Confirmed
Revision history for this message
Jose Ogando Justo (joseogando) wrote :

A fix has been proposed for Lunar.

https://lists.ubuntu.com/archives/kernel-team/2023-January/136387.html

Since the Config management has change between series, a similar patch/fix needs to be added for Kinetic and Jammy.

Revision history for this message
Jacob Martin (jacobmartin) wrote :
Changed in linux-kvm (Ubuntu Jammy):
status: New → Confirmed
Changed in linux-kvm (Ubuntu Jammy):
status: Confirmed → Fix Committed
Changed in linux-kvm (Ubuntu Kinetic):
status: Confirmed → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-kvm/5.15.0-1029.34 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-kvm verification-needed-jammy
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-kvm/5.19.0-1019.20 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-kinetic' to 'verification-done-kinetic'. If the problem still exists, change the tag 'verification-needed-kinetic' to 'verification-failed-kinetic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-kinetic-linux-kvm verification-needed-kinetic
Revision history for this message
Roxana Nicolescu (roxanan) wrote (last edit ):

Test passed on jammy:linux-kvm/5.19.9-1029.34

09:24:21 DEBUG| Running 'make run_tests -C net TEST_PROGS=fib_nexthop_nongw.sh TEST_GEN_PROGS='' TEST_CUSTOM_PROGS='''
      19349 09:24:21 DEBUG| [stdout] make: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net'
      19350 09:24:21 DEBUG| [stdout] make --no-builtin-rules ARCH=x86 -C ../../../.. headers_install
      19351 09:24:21 DEBUG| [stdout] make[1]: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux'
      19352 09:24:22 DEBUG| [stdout] INSTALL ./usr/include
      19353 09:24:22 DEBUG| [stdout] make[1]: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux'
      19354 09:24:22 DEBUG| [stdout] TAP version 13
      19355 09:24:22 DEBUG| [stdout] 1..1
      19356 09:24:22 DEBUG| [stdout] # selftests: net: fib_nexthop_nongw.sh
      19357 09:24:22 DEBUG| [stdout] # TEST: nexthop: get route with nexthop without gw [ OK ]
      19358 09:24:22 DEBUG| [stdout] # TEST: nexthop: ping through nexthop without gw [ OK ]
      19359 09:24:22 DEBUG| [stdout] ok 1 selftests: net: fib_nexthop_nongw.sh
      19360 09:24:22 DEBUG| [stdout] make: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net'
      19361 09:24:23 INFO | GOOD ubuntu_kernel_selftests.net:fib_nexthop_nongw.sh ubuntu_kernel_selftests.net:fib_nexthop_nongw.sh timestamp=1676021063 localtime=Feb 10 09:24:23 completed successfully
      19362 09:24:23 INFO | END GOOD ubuntu_kernel_selftests.net:fib_nexthop_nongw.sh ubuntu_kernel_selftests.net:fib_nexthop_nongw.sh timestamp=1676021063 localtime=Feb 10 09:24:23
      19363 09:24:23 DEBUG| Persistent state client._record_indent now set to 1
      19364 09:24:23 DEBUG| Persistent state client.unexpected_reboot deleted

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (51.6 KiB)

This bug was fixed in the package linux-kvm - 5.15.0-1029.34

---------------
linux-kvm (5.15.0-1029.34) jammy; urgency=medium

  * jammy/linux-kvm: 5.15.0-1029.34 -proposed tracker (LP: #2004333)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2023.01.30)

  * Jammy update: v5.15.81 upstream stable release (LP: #2003130)
    - [Config] kvm: updateconfigs for CC_HAS_ASM_GOTO_TIED_OUTPUT
    - [Config] kvm: updateconfigs for INET_TABLE_PERTURB_ORDER

  * kselftest net/fib_nexthop_nongw.sh fails (LP: #1998244)
    - [Config] kvm: Add support for dummy net driver

  [ Ubuntu: 5.15.0-66.73 ]

  * jammy/linux: 5.15.0-66.73 -proposed tracker (LP: #2004636)
  * CVE-2023-0461
    - SAUCE: Fix inet_csk_listen_start after CVE-2023-0461

  [ Ubuntu: 5.15.0-65.72 ]

  * jammy/linux: 5.15.0-65.72 -proposed tracker (LP: #2004344)
  * Packaging resync (LP: #1786013)
    - [Packaging] update variants
    - debian/dkms-versions -- update from kernel-versions (main/2023.01.30)
  * NFS: client permission error after adding user to permissible group
    (LP: #2003053)
    - NFS: Clear the file access cache upon login
    - NFS: Judge the file access cache's timestamp in rcu path
    - NFS: Fix up a sparse warning
  * Fix W6400 hang after resume of S3 stress (LP: #2000299)
    - drm/amd/display: Manually adjust strobe for DCN303
  * Rear Audio port sometimes has no audio output after reboot(Cirrus Logic)
    (LP: #1998905)
    - ALSA: hda/cirrus: Add extra 10 ms delay to allow PLL settle and lock.
  * CVE-2022-20369
    - NFSD: fix use-after-free in __nfs42_ssc_open()
  * CVE-2023-0461
    - net/ulp: prevent ULP without clone op from entering the LISTEN status
    - net/ulp: use consistent error code when blocking ULP
  * CVE-2023-0179
    - netfilter: nft_payload: incorrect arithmetics when fetching VLAN header bits
  * Jammy update: v5.15.85 upstream stable release (LP: #2003139)
    - udf: Discard preallocation before extending file with a hole
    - udf: Fix preallocation discarding at indirect extent boundary
    - udf: Do not bother looking for prealloc extents if i_lenExtents matches
      i_size
    - udf: Fix extending file within last block
    - usb: gadget: uvc: Prevent buffer overflow in setup handler
    - USB: serial: option: add Quectel EM05-G modem
    - USB: serial: cp210x: add Kamstrup RF sniffer PIDs
    - USB: serial: f81232: fix division by zero on line-speed change
    - USB: serial: f81534: fix division by zero on line-speed change
    - xhci: Apply XHCI_RESET_TO_DEFAULT quirk to ADL-N
    - igb: Initialize mailbox message for VF reset
    - usb: dwc3: pci: Update PCIe device ID for USB3 controller on CPU sub-system
      for Raptor Lake
    - HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk
    - selftests: net: Use "grep -E" instead of "egrep"
    - net: loopback: use NET_NAME_PREDICTABLE for name_assign_type
    - Linux 5.15.85
  * Jammy update: v5.15.84 upstream stable release (LP: #2003137)
    - x86/vdso: Conditionally export __vdso_sgx_enter_enclave()
    - vfs: fix copy_file_range() averts filesystem freeze protection
    - ASoC: fsl_micfil: explicitly clear software reset bit
  ...

Changed in linux-kvm (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Andrei Gherzan (agherzan) wrote :

I have validated this fix for kinetic:linux-kvm - from proposed:

# selftests: net: fib_nexthop_nongw.sh
# TEST: nexthop: get route with nexthop without gw [ OK ]
# TEST: nexthop: ping through nexthop without gw [ OK ]
ok 1 selftests: net: fib_nexthop_nongw.sh

Linux ubuntu-kinetic 5.19.0-1019-kvm #20-Ubuntu SMP Fri Feb 10 11:54:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

tags: added: verification-done-kinetic
removed: verification-needed-kinetic
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (52.8 KiB)

This bug was fixed in the package linux-kvm - 5.19.0-1019.20

---------------
linux-kvm (5.19.0-1019.20) kinetic; urgency=medium

  * kinetic/linux-kvm: 5.19.0-1019.20 -proposed tracker (LP: #2004289)

  * Kinetic update: upstream stable patchset 2023-01-27 (LP: #2004051)
    - [Config] updateconfigs following Ubuntu-5.19.0-35.36 rebase

  * kselftest net/fib_nexthop_nongw.sh fails (LP: #1998244)
    - [Config] kvm: Add support for dummy net driver

  [ Ubuntu: 5.19.0-35.36 ]

  * kinetic/linux: 5.19.0-35.36 -proposed tracker (LP: #2004652)
  * CVE-2023-0461
    - SAUCE: Fix inet_csk_listen_start after CVE-2023-0461

  [ Ubuntu: 5.19.0-34.35 ]

  * kinetic/linux: 5.19.0-34.35 -proposed tracker (LP: #2004299)
  * LXD containers using shiftfs on ZFS or TMPFS broken on 5.15.0-48.54
    (LP: #1990849)
    - [SAUCE] shiftfs: fix -EOVERFLOW inside the container
  * Kinetic update: upstream stable patchset 2023-01-27 (LP: #2004051)
    - ASoC: fsl_sai: use local device pointer
    - serial: Add rs485_supported to uart_port
    - serial: fsl_lpuart: Fill in rs485_supported
    - x86/sgx: Create utility to validate user provided offset and length
    - x86/sgx: Add overflow check in sgx_validate_offset_length()
    - binder: validate alloc->mm in ->mmap() handler
    - ceph: Use kcalloc for allocating multiple elements
    - ceph: fix NULL pointer dereference for req->r_session
    - wifi: mac80211: fix memory free error when registering wiphy fail
    - wifi: mac80211_hwsim: fix debugfs attribute ps with rc table support
    - riscv: dts: sifive unleashed: Add PWM controlled LEDs
    - audit: fix undefined behavior in bit shift for AUDIT_BIT
    - wifi: airo: do not assign -1 to unsigned char
    - wifi: mac80211: Fix ack frame idr leak when mesh has no route
    - wifi: ath11k: Fix QCN9074 firmware boot on x86
    - spi: stm32: fix stm32_spi_prepare_mbr() that halves spi clk for every run
    - selftests/bpf: Add verifier test for release_reference()
    - Revert "net: macsec: report real_dev features when HW offloading is enabled"
    - platform/x86: ideapad-laptop: Disable touchpad_switch
    - platform/x86: touchscreen_dmi: Add info for the RCA Cambio W101 v2 2-in-1
    - platform/x86/intel/pmt: Sapphire Rapids PMT errata fix
    - scsi: ibmvfc: Avoid path failures during live migration
    - scsi: scsi_debug: Make the READ CAPACITY response compliant with ZBC
    - drm: panel-orientation-quirks: Add quirk for Acer Switch V 10 (SW5-017)
    - block, bfq: fix null pointer dereference in bfq_bio_bfqg()
    - arm64/syscall: Include asm/ptrace.h in syscall_wrapper header.
    - nvmet: fix memory leak in nvmet_subsys_attr_model_store_locked
    - Revert "drm/amdgpu: Revert "drm/amdgpu: getting fan speed pwm for vega10
      properly""
    - ALSA: usb-audio: add quirk to fix Hamedal C20 disconnect issue
    - RISC-V: vdso: Do not add missing symbols to version section in linker script
    - MIPS: pic32: treat port as signed integer
    - xfrm: fix "disable_policy" on ipv4 early demux
    - xfrm: replay: Fix ESN wrap around for GSO
    - af_key: Fix send_acquire race with pfkey_register
    - ARM: dts: am335x-pcm-953: Define fixed regulators in root nod...

Changed in linux-kvm (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-kvm - 6.2.0-1002.2

---------------
linux-kvm (6.2.0-1002.2) lunar; urgency=medium

  * lunar/linux-kvm: 6.2.0-1002.2 -proposed tracker (LP: #2012486)

  * Miscellaneous Ubuntu changes
    - [Config] inherit debian.master annotation
    - [Config] updateconfigs following 6.2 rebase

  * Miscellaneous upstream changes
    - Revert "UBUNTU: [Config] updateconfigs following 6.2 rebase"

 -- Paolo Pisati <email address hidden> Wed, 22 Mar 2023 09:46:35 +0100

Changed in linux-kvm (Ubuntu Lunar):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.