Ubuntu
ubiquity package

restart button remains visible in the advanced partitioner after the bitlocker page is shown

Bug #1942648 reported by Sam van Kampen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Medium
Brian Murray
Ubuntu ubuntu-21.10
Focal
Fix Released
Medium
Brian Murray
Ubuntu ubuntu-20.04.4
Impish
Fix Released
Medium
Brian Murray
Ubuntu ubuntu-21.10

Bug Description

[Impact]
On a system where BitLocker is enabled, when choosing "Install Ubuntu
alongside Windows Boot Manager", a page is shown instructing us to
turn off BitLocker. On this page, a green "Restart" button is shown.

If we now go back and pick "Something else", the advanced partitioning
screen still displays the green restart button, even though clicking
on it acts like the expected "Install Now" button.

Whereas a user could think they are just restarting, but actually
clicking an "Install Now" button, the present state risks users losing
data.

[Test Plan]
* Acquire a VM or machine with a partition that is BitLockered.
* Run thru the Ubiquity installer:
  * Install Ubuntu
  * Appropriate keyboard layout and Continue
  * Accept defaults at "Updates and other software" Install screen,
    and Continue
  * At the Installation type screen, ensure that "Install Ubuntu
    alongside Windows Boot Manager" is selected, and Continue
  * The "Turn off bitlocker" screen should now be showing. Click the
    "Back" button
  * Select "Something else" and Continue
  * 3 buttons should be visible in the Bottom row. When the defect is
    present, the rightmost button is green and says "Restart". When
    the defect has been corrected, the rightmost button says "Install
    now" and is the same color as the other buttons.

[Where problems could occur]
* Any change to the installer must be treated with the highest level
  of care, as this is a place where users with less experience make
  changes to a system and can lose data if mistakes are made.

* Are there other code flows where the state variables are incorrect?
  Since the current code depends on the back button to reset the
  state, is it doing so completely?

See original description
Revision history for this message
Sam van Kampen (svkmpn) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Patch which makes the button look as expected." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Brian Murray (brian-murray)
tags: added: focal rls-ff-incoming
Matthieu Clemenceau (mclemenceau)
tags: added: fr-1706
Brian Murray (brian-murray)
tags: removed: rls-ff-incoming
Changed in ubiquity (Ubuntu Impish):
milestone: none → ubuntu-21.10
Dan Bungert (dbungert)
Changed in ubiquity (Ubuntu Impish):
status: New → Confirmed
Revision history for this message
Dan Bungert (dbungert) wrote :

I have verified the patch and it looks good to me. I suggest merging.

Note that when verifying this, it seems necessary in the manual partitioning step to select a disk to format in order to enable the green 'Restart' button that is functionally the 'Install Now' button.

Brian Murray (brian-murray)
Changed in ubiquity (Ubuntu Focal):
milestone: none → ubuntu-20.04.4
Brian Murray (brian-murray)
Changed in ubiquity (Ubuntu Impish):
assignee: nobody → Brian Murray (brian-murray)
status: Confirmed → In Progress
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 21.10.10

---------------
ubiquity (21.10.10) impish; urgency=medium

  * ubi-partman.py: Do not display a restart button in the advanced
    partitioning screen when installing alongside Windows Boot Manager. Thanks
    to Sam van Kampen for the patch. (LP: #1942648)

 -- Brian Murray <email address hidden> Tue, 12 Oct 2021 05:52:59 -0700

Changed in ubiquity (Ubuntu Impish):
status: In Progress → Fix Released
Revision history for this message
Dan Bungert (dbungert) wrote :

I ran this through my kvm test and it behaved as expected. LGTM.

Brian Murray (brian-murray)
Changed in ubiquity (Ubuntu Focal):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Brian Murray (brian-murray)
Dan Bungert (dbungert)
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Sam, or anyone else affected,

Accepted ubiquity into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/20.04.15.18 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubiquity (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Dan Bungert (dbungert) wrote :

I repeated the test based on the package from proposed and things still look good.

Brian Murray (brian-murray)
tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 20.04.15.18

---------------
ubiquity (20.04.15.18) focal; urgency=medium

  * ubi-partman.py: Do not display a restart button in the advanced
    partitioning screen when installing alongside Windows Boot Manager. Thanks
    to Sam van Kampen for the patch. (LP: #1942648)
  * tests/test_timezone.py: The Bahamas moved their DST rules to sync with the
    U.S. in 2007 but tzdata only recently incorporated this change.
    (LP: #1951519)
  * Automatic update of included source packages: shim-signed 1.40.7.

 -- Brian Murray <email address hidden> Mon, 10 Jan 2022 10:39:31 -0800

Changed in ubiquity (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for ubiquity has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.