syncpackage: downloads .dsc when it really isn't needed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-dev-tools (Ubuntu) |
Fix Released
|
Low
|
Dan Streetman | ||
Hirsute |
Won't Fix
|
Low
|
Unassigned | ||
Impish |
Fix Released
|
Low
|
Dan Streetman |
Bug Description
[impact]
syncpackage saves the dsc file(s) to disk but doesn't need to
[test case]
ubuntu@
The use of --no-lp is not recommended for uploads targeted at Ubuntu. The archive-admins discourage its use, except for fakesyncs.
Downloading ubuntu-
Using existing file ubuntu-
Downloading ubuntu-
check if the dsc file(s) are now in $PWD:
ubuntu@
-rw-rw-r-- 1 ubuntu ubuntu 2356 Jun 2 15:40 ubuntu-
-rw-rw-r-- 1 ubuntu ubuntu 2219 Jun 2 15:40 ubuntu-
[regression potential]
any regression would likely cause incorrectly saved dsc files, or incorrect failure to save a dsc file to disk when using any of the various scripts included in the ubuntu-dev-tools pacakge, or other scripts that use the python3-ubuntutools package library
[scope]
this is needed only for h and later
this was introduced by commit fed562405d76ab8
[original description]
It seems that starting from a few versions, syncpackage downloads .dscs, stores them in ~, and leaves them there.
AFAIK there is no need to download anything to sync a package, as launchpad should be able to handle everything through its API, so I'd say the bug is threefold:
1) shouldn't download anything if not needed (when is it needed?!)
2) shouldn't store things in ~ at all, use a tempdir in TMPDIR instead
3) shouldn't leave temporary files around
Currently running version 0.181 under Debian unstable.
description: | updated |
Changed in ubuntu-dev-tools (Ubuntu Hirsute): | |
assignee: | nobody → Dan Streetman (ddstreet) |
status: | New → In Progress |
Changed in ubuntu-dev-tools (Ubuntu Impish): | |
status: | Confirmed → In Progress |
importance: | Undecided → Low |
Changed in ubuntu-dev-tools (Ubuntu Hirsute): | |
importance: | Undecided → Low |
Changed in ubuntu-dev-tools (Ubuntu Hirsute): | |
status: | In Progress → Won't Fix |
assignee: | Dan Streetman (ddstreet) → nobody |
autopkgtest fails on impish:
flake8. main.applicatio n MainProcess 2058 INFO Found a total of 16 violations and reported 1 archive. py:31:1: F401 'urllib. parse.urlparse' imported but unused
./ubuntutools/
so you need to fix the uploads