Mitigate libvirt: error : unable to set AppArmor profile 'libvirt-<vm-uuid>' for '/usr/bin/kvm-spice': No such file or directory

Thanks Ioanna for the bug.

In our discussion that we already had I've suggested how to fix it in code and I think this still is a valid approach to harden against whatever was causing it in the first place.

After initial creation the file is meant to stay as-is to allow users
to do customization e.g. special apparmor rules that only apply to
this particular guest.
Now while we conceptionally allow edits, we could argue that a 0-byte
file always surely is a consequence of an error and in that case
regenerate it as if it would not have been there.

Currently creation only happens within
 /* create the profile from TEMPLATE */
 if (ctl->cmd == 'c') {

But we could move that out to a function and call it here as well as
on the ctl->cmd == 'r' path IF the file does a) not exist or b) is of
size zero.

I got a proposed RFC for the fix from Ioanna (thanks!) which I have reviewed.
But there is nothing sent to upstream for discussion so far.

I'll bump the tag to 22.04 to manage expecations of anyone else looking at this, but I'm happy to apply if we can get it upstream before 21.10 feature freeze.

FYI - this is still being worked on by Ioanna (thanks) and a v2 patch set is up for review at the upstream mailing list.

Merged upstream, will be in v7.10.0 which will make it into Ubuntu 22.04 later this cycle.
From there we can consider SRUs

If the case is more urgent to you (need it earlier) we can consider adding it as individual upload now instead of waiting for >=7.10

We have at least a customer on Ubuntu Xenial who hits this somewhat
regularly and would very much appreciate this fix getting into SRU
as quickly as possible.

Would you please consider moving this forward using the fastest
path available?

Thanks Alejandro for letting me know, in that case let us apply it to Jammy now and SRU from there without waiting for the new version we will get into 22.04 later.

Working on this together with the slightly more complex 1948880 for Jammy now.
PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4710
MR: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/411755

FYI
libvirt regressed in release and is a FTBFS on s390x.
 88/162 virdrivermoduletest FAIL 0.04s exit status 1
128/162 storagepoolxml2argvtest FAIL 0.04s exit status 1
129/162 storagepoolxml2xmltest FAIL 0.03s exit status 1
132/162 virstoragetest FAIL 0.03s exit status 1
Unfortunately this will stall this a bit.

FYI the stall was due to an issue with glusterfs that is now fixed - see bug 1950777

Only waiting on bug 1948880 to be ready for the Jammy upload (code and tests done, waiting for review before an upload).

FYI - uploaded to Jammy

In jammy it seems this won't stop - I have finally unblocked glusterfs which blocked this (also the second glusterfs issue), but now it is entangled in the liburcu transition and that might be enough to get it into openssl3 then. But I've tested this from -proposed and there it is fine no matter if it is one or four weeks until it finally migrates.

For the SRU that is enough to get started, so let me prepare this now...

Backports done (mostly applied as-is or were trivial) and build in PPA:
- https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4717

MRs:
B: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/412064
F: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/412065
H: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/412066
I: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/412067

As if the glusterfs stall would not have been enough, it seems libvirt (without this change) regressed in release in Bionic and now FTFBS there which I need to resolve now.
I'll take a look and update here or ref a new bug.

FYI - Bionic stalled by bug 1951438 - It seems things can never be easy :-)

@Christian,

Thank you very much for uploading in Jammy and SRUs.
I am preparing the debdiffs for the UCA.

Debdiff for Queens

Debdiff for Stein.

Debdiff for Stein.

Debdiff for Stein.

Debdiff for Ussuri

The attachment "lp1927519_queens.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Finalized and ready for SRU:
- MPs reviewed
- Build issue of bug 1951438 resolved
- Extended test steps by the regression test
- Tested B/F/H/I vs the PPA (test steps work and fixes the issue)

=> Uploading to -unapproved now.

Hello Ioanna, or anyone else affected,

Accepted libvirt into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/7.6.0-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ioanna, or anyone else affected,

Accepted libvirt into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/7.0.0-2ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ioanna, or anyone else affected,

Accepted libvirt into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/6.0.0-0ubuntu8.15 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ioanna, or anyone else affected,

Accepted libvirt into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/4.0.0-1ubuntu8.20 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Upgrades to proposed

root@b:~# apt upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
  libparted2 libvirt-clients libvirt-daemon libvirt-daemon-driver-storage-rbd libvirt-daemon-system libvirt0 libx11-6 libx11-data login parted passwd python3-software-properties
  python3-update-manager software-properties-common uidmap update-manager-core
16 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 6239 kB of archives.
After this operation, 17.4 kB of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 login amd64 1:4.5-1ubuntu2.1 [307 kB]
Get:2 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libvirt-daemon-driver-storage-rbd amd64 4.0.0-1ubuntu8.20 [15.4 kB]
Get:3 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 parted amd64 3.2-20ubuntu0.3 [42.5 kB]
Get:4 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libparted2 amd64 3.2-20ubuntu0.3 [123 kB]
Get:5 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libvirt-daemon-system amd64 4.0.0-1ubuntu8.20 [81.0 kB]
Get:6 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libvirt-daemon amd64 4.0.0-1ubuntu8.20 [2177 kB]
Get:7 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libvirt-clients amd64 4.0.0-1ubuntu8.20 [596 kB]
Get:8 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libvirt0 amd64 4.0.0-1ubuntu8.20 [1249 kB]
Get:9 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 passwd amd64 1:4.5-1ubuntu2.1 [819 kB]
Get:10 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libx11-data all 2:1.6.4-3ubuntu0.5 [114 kB]
Get:11 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 libx11-6 amd64 2:1.6.4-3ubuntu0.5 [573 kB]
Get:12 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 python3-update-manager all 1:18.04.11.14 [35.0 kB]
Get:13 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 update-manager-core all 1:18.04.11.14 [8496 B]
Get:14 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 software-properties-common all 0.96.24.32.18 [10.1 kB]
Get:15 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 python3-software-properties all 0.96.24.32.18 [23.8 kB]
Get:16 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 uidmap amd64 1:4.5-1ubuntu2.1 [65.6 kB]
Fetched 6239 kB in 1s (7160 kB/s)
Preconfiguring packages ...
(Reading database ... 33218 files and directories currently installed.)
Preparing to unpack .../login_1%3a4.5-1ubuntu2.1_amd64.deb ...
Unpacking login (1:4.5-1ubuntu2.1) over (1:4.5-1ubuntu2) ...
Setting up login (1:4.5-1ubuntu2.1) ...
(Reading database ... 33218 files and directories currently installed.)
Preparing to unpack .../0-libvirt-daemon-driver-storage-rbd_4.0.0-1ubuntu8.20_amd64.deb ...
Unpacking libvirt-daemon-driver-storage-rbd (4.0.0-1ubuntu8.20) over (4.0.0-1ubuntu8.20~bionicppa4) ...
Preparing to unpack .../1-parted_3.2-20ubuntu0.3_amd64.deb ...
Unpacking parted (3.2-20ubuntu0.3) over (3.2-20ubuntu0.2) ...
Preparing to unpack .../...

root@f:~# apt upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
  command-not-found curl libcurl3-gnutls libcurl4 libvirt-clients libvirt-daemon libvirt-daemon-driver-qemu libvirt-daemon-driver-storage-rbd libvirt-daemon-system
  libvirt-daemon-system-systemd libvirt0 libx11-6 libx11-data python3-commandnotfound secureboot-db sosreport wget
17 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 4868 kB of archives.
After this operation, 93.2 kB of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 command-not-found all 20.04.5 [5244 B]
Get:2 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 python3-commandnotfound all 20.04.5 [10.2 kB]
Get:3 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libx11-data all 2:1.6.9-2ubuntu1.3 [113 kB]
Get:4 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libx11-6 amd64 2:1.6.9-2ubuntu1.3 [577 kB]
Get:5 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 wget amd64 1.20.3-1ubuntu2 [348 kB]
Get:6 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 curl amd64 7.68.0-1ubuntu2.8 [161 kB]
Get:7 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libcurl4 amd64 7.68.0-1ubuntu2.8 [234 kB]
Get:8 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libcurl3-gnutls amd64 7.68.0-1ubuntu2.8 [233 kB]
Get:9 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon-driver-storage-rbd amd64 6.0.0-0ubuntu8.15 [28.3 kB]
Get:10 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon-driver-qemu amd64 6.0.0-0ubuntu8.15 [605 kB]
Get:11 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon-system amd64 6.0.0-0ubuntu8.15 [67.8 kB]
Get:12 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-clients amd64 6.0.0-0ubuntu8.15 [344 kB]
Get:13 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt0 amd64 6.0.0-0ubuntu8.15 [1450 kB]
Get:14 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon amd64 6.0.0-0ubuntu8.15 [404 kB]
Get:15 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon-system-systemd amd64 6.0.0-0ubuntu8.15 [8292 B]
Get:16 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 secureboot-db amd64 1.6~20.04.1 [14.2 kB]
Get:17 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 sosreport amd64 4.2-1ubuntu0.20.04.1 [265 kB]
Fetched 4868 kB in 1s (6355 kB/s)
Preconfiguring packages ...
(Reading database ... 48075 files and directories currently installed.)
Preparing to unpack .../00-command-not-found_20.04.5_all.deb ...
Unpacking command-not-found (20.04.5) over (20.04.4) ...
Preparing to unpack .../01-python3-commandnotfound_20.04.5_all.deb ...
Unpacking python3-commandnotfound (20.04.5) over (20.04.4) ...
Preparing to unpack .../02-libx11-data_2%3a1.6.9-2ubuntu1.3_all.deb ...
Unpacking libx11-data (2:1.6.9-2ubuntu1.3) over (2:1.6.9-2ubuntu1.2) ...
Preparing to unpack .../03-libx11-6_2%3a1.6.9-2ubuntu1.3_amd64.deb ...
...

root@h:~# apt upgrade
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
  command-not-found libvirt-clients libvirt-daemon libvirt-daemon-config-network libvirt-daemon-config-nwfilter libvirt-daemon-driver-qemu libvirt-daemon-system
  libvirt-daemon-system-systemd libvirt0 python3-commandnotfound python3-update-manager update-manager-core
12 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 3111 kB of archives.
After this operation, 1024 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 command-not-found all 20.10.2 [5240 B]
Get:2 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 python3-commandnotfound all 20.10.2 [10.2 kB]
Get:3 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 python3-update-manager all 1:21.04.11 [38.0 kB]
Get:4 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 update-manager-core all 1:21.04.11 [11.3 kB]
Get:5 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt-daemon-config-network all 7.0.0-2ubuntu2.2 [10.6 kB]
Get:6 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt-clients amd64 7.0.0-2ubuntu2.2 [352 kB]
Get:7 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt-daemon-driver-qemu amd64 7.0.0-2ubuntu2.2 [648 kB]
Get:8 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt0 amd64 7.0.0-2ubuntu2.2 [1550 kB]
Get:9 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt-daemon amd64 7.0.0-2ubuntu2.2 [362 kB]
Get:10 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt-daemon-system amd64 7.0.0-2ubuntu2.2 [48.4 kB]
Get:11 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt-daemon-config-nwfilter all 7.0.0-2ubuntu2.2 [13.3 kB]
Get:12 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libvirt-daemon-system-systemd all 7.0.0-2ubuntu2.2 [61.5 kB]
Fetched 3111 kB in 1s (6076 kB/s)
Preconfiguring packages ...
(Reading database ... 49637 files and directories currently installed.)
Preparing to unpack .../00-command-not-found_20.10.2_all.deb ...
Unpacking command-not-found (20.10.2) over (20.10.1) ...
Preparing to unpack .../01-python3-commandnotfound_20.10.2_all.deb ...
Unpacking python3-commandnotfound (20.10.2) over (20.10.1) ...
Preparing to unpack .../02-python3-update-manager_1%3a21.04.11_all.deb ...
Unpacking python3-update-manager (1:21.04.11) over (1:21.04.10) ...
Preparing to unpack .../03-update-manager-core_1%3a21.04.11_all.deb ...
Unpacking update-manager-core (1:21.04.11) over (1:21.04.10) ...
Preparing to unpack .../04-libvirt-daemon-config-network_7.0.0-2ubuntu2.2_all.deb ...
Unpacking libvirt-daemon-config-network (7.0.0-2ubuntu2.2) over (7.0.0-2ubuntu2.2~hirsuteppa1) ...
Preparing to unpack .../05-libvirt-clients_7.0.0-2ubuntu2.2_amd64.deb ...
Unpacking libvirt-clients (7.0.0-2ubuntu2.2) over (7.0.0-2ubuntu2.2~hirsuteppa1) ...
Preparing to unpack .../06-libvirt-daemon-driver-qemu_7.0.0-2ubuntu2.2_amd64.deb ...
U...

root@i:~# apt upgrade
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
  libpulse0 libvirt-clients libvirt-daemon libvirt-daemon-config-network libvirt-daemon-config-nwfilter libvirt-daemon-driver-qemu libvirt-daemon-system libvirt-daemon-system-systemd
  libvirt0 python3-gi
10 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 3928 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 python3-gi amd64 3.40.1-1build2 [228 kB]
Get:2 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libpulse0 amd64 1:15.0+dfsg1-1ubuntu2.1 [300 kB]
Get:3 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt-daemon-config-network all 7.6.0-0ubuntu1.1 [11.2 kB]
Get:4 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt-clients amd64 7.6.0-0ubuntu1.1 [389 kB]
Get:5 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt-daemon-driver-qemu amd64 7.6.0-0ubuntu1.1 [735 kB]
Get:6 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt0 amd64 7.6.0-0ubuntu1.1 [1724 kB]
Get:7 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt-daemon amd64 7.6.0-0ubuntu1.1 [408 kB]
Get:8 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt-daemon-system amd64 7.6.0-0ubuntu1.1 [51.1 kB]
Get:9 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt-daemon-config-nwfilter all 7.6.0-0ubuntu1.1 [14.1 kB]
Get:10 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 libvirt-daemon-system-systemd all 7.6.0-0ubuntu1.1 [67.1 kB]
Fetched 3928 kB in 1s (5667 kB/s)
Preconfiguring packages ...
(Reading database ... 49520 files and directories currently installed.)
Preparing to unpack .../0-python3-gi_3.40.1-1build2_amd64.deb ...
Unpacking python3-gi (3.40.1-1build2) over (3.40.1-1build1) ...
Preparing to unpack .../1-libpulse0_1%3a15.0+dfsg1-1ubuntu2.1_amd64.deb ...
Unpacking libpulse0:amd64 (1:15.0+dfsg1-1ubuntu2.1) over (1:15.0+dfsg1-1ubuntu2) ...
Preparing to unpack .../2-libvirt-daemon-config-network_7.6.0-0ubuntu1.1_all.deb ...
Unpacking libvirt-daemon-config-network (7.6.0-0ubuntu1.1) over (7.6.0-0ubuntu1.1~impishppa1) ...
Preparing to unpack .../3-libvirt-clients_7.6.0-0ubuntu1.1_amd64.deb ...
Unpacking libvirt-clients (7.6.0-0ubuntu1.1) over (7.6.0-0ubuntu1.1~impishppa1) ...
Preparing to unpack .../4-libvirt-daemon-driver-qemu_7.6.0-0ubuntu1.1_amd64.deb ...
Unpacking libvirt-daemon-driver-qemu (7.6.0-0ubuntu1.1) over (7.6.0-0ubuntu1.1~impishppa1) ...
Preparing to unpack .../5-libvirt0_7.6.0-0ubuntu1.1_amd64.deb ...
Unpacking libvirt0:amd64 (7.6.0-0ubuntu1.1) over (7.6.0-0ubuntu1.1~impishppa1) ...
Preparing to unpack .../6-libvirt-daemon_7.6.0-0ubuntu1.1_amd64.deb ...
Unpacking libvirt-daemon (7.6.0-0ubuntu1.1) over (7.6.0-0ubuntu1.1~impishppa1) ...
Preparing to unpack .../7-libvirt-daemon-system_7.6.0-0ubuntu1.1_amd64.deb ...
Unpacking libvirt-daemon-system (7.6.0-0ubuntu1.1) over (7.6.0-0ubuntu1.1~im...

That all LGTM, the one oddity is in Focal with the mention of a failed service.

But that is just focals debhelpers not able to understand an already started socket/service.

Nov 23 11:27:00 f systemd[1]: libvirtd-ro.socket: Socket service libvirtd.service already active, refusing.
Nov 23 11:27:00 f systemd[1]: Failed to listen on Libvirt local read-only socket.

The upgrade still went fine and the service runs correctly.

root@f:~# systemctl status libvirtd
● libvirtd.service - Virtualization daemon
     Loaded: loaded (/lib/systemd/system/libvirtd.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2021-11-23 11:27:00 UTC; 3min 1s ago
TriggeredBy: ● libvirtd.socket
             ● libvirtd-admin.socket
             ● libvirtd-ro.socket
       Docs: man:libvirtd(8)
             https://libvirt.org
   Main PID: 15624 (libvirtd)
      Tasks: 19 (limit: 32768)
     Memory: 40.2M
     CGroup: /system.slice/libvirtd.service
             ├─ 3643 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/lib/libvirt/libvirt_leaseshelper
             ├─ 3644 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/lib/libvirt/libvirt_leaseshelper
             └─15624 /usr/sbin/libvirtd

Nov 23 11:27:00 f systemd[1]: Starting Virtualization daemon...
Nov 23 11:27:00 f systemd[1]: Started Virtualization daemon.
Nov 23 11:27:00 f dnsmasq[3643]: read /etc/hosts - 7 addresses
Nov 23 11:27:00 f dnsmasq[3643]: read /var/lib/libvirt/dnsmasq/default.addnhosts - 0 addresses
Nov 23 11:27:00 f dnsmasq-dhcp[3643]: read /var/lib/libvirt/dnsmasq/default.hostsfile

And finally this isn't new/changed by this upload

The documented testcase for this issue also LGTM.

Bionic
root@b:~# virsh dominfo f
Id: -
Name: f
UUID: 18ad0964-736e-4c8d-869b-13083e66beca
OS Type: hvm
State: shut off
CPU(s): 1
Max memory: 524288 KiB
Used memory: 524288 KiB
Persistent: yes
Autostart: disable
Managed save: no
Security model: apparmor
Security DOI: 0

root@b:~# cat /dev/null | sudo tee /etc/apparmor.d/libvirt/libvirt-18ad0964-736e-4c8d-869b-13083e66beca
root@b:~# ll /etc/apparmor.d/libvirt/libvirt-18ad0964-736e-4c8d-869b-13083e66beca
-rw-r--r-- 1 root root 0 Nov 23 11:31 /etc/apparmor.d/libvirt/libvirt-18ad0964-736e-4c8d-869b-13083e66beca
root@b:~# virsh start f
Domain f started

Focal
root@f:~# virsh dominfo f
Id: -
Name: f
UUID: f4c2021f-14bf-4e04-af31-0667908320f1
OS Type: hvm
State: shut off
CPU(s): 1
Max memory: 524288 KiB
Used memory: 524288 KiB
Persistent: yes
Autostart: disable
Managed save: no
Security model: apparmor
Security DOI: 0

root@f:~# cat /dev/null | sudo tee /etc/apparmor.d/libvirt/libvirt-f4c2021f-14bf-4e04-af31-0667908320f1
root@f:~# ll /etc/apparmor.d/libvirt/libvirt-f4c2021f-14bf-4e04-af31-0667908320f1
-rw-r--r-- 1 root root 0 Nov 23 11:31 /etc/apparmor.d/libvirt/libvirt-f4c2021f-14bf-4e04-af31-0667908320f1
root@f:~# virsh start f
Domain f started

Hirsute
root@h:~# virsh dominfo f
Id: -
Name: f
UUID: 1ceac8db-c1e9-40b2-8ada-a60349454fc1
OS Type: hvm
State: shut off
CPU(s): 1
Max memory: 524288 KiB
Used memory: 524288 KiB
Persistent: yes
Autostart: disable
Managed save: no
Security model: apparmor
Security DOI: 0

root@h:~# cat /dev/null | sudo tee /etc/apparmor.d/libvirt/libvirt-1ceac8db-c1e9-40b2-8ada-a60349454fc1
root@h:~# ll /etc/apparmor.d/libvirt/libvirt-1ceac8db-c1e9-40b2-8ada-a60349454fc1
-rw-r--r-- 1 root root 0 Nov 23 11:31 /etc/apparmor.d/libvirt/libvirt-1ceac8db-c1e9-40b2-8ada-a60349454fc1
root@h:~# virsh start f
Domain 'f' started

Impish
root@i:~# virsh dominfo f
Id: -
Name: f
UUID: c2cf5436-c7c3-402e-9593-ad7dca047ceb
OS Type: hvm
State: shut off
CPU(s): 1
Max memory: 524288 KiB
Used memory: 524288 KiB
Persistent: yes
Autostart: disable
Managed save: no
Security model: apparmor
Security DOI: 0

root@i:~# cat /dev/null | sudo tee /etc/apparmor.d/libvirt/libvirt-c2cf5436-c7c3-402e-9593-ad7dca047ceb
root@i:~# ll /etc/apparmor.d/libvirt/libvirt-ll /etc/apparmor.d/libvirt/libvirt-c2cf5436-c7c3-402e-9593-ad7dca047ceb
ls: cannot access '/etc/apparmor.d/libvirt/libvirt-ll': No such file or directory
-rw-r--r-- 1 root root 0 Nov 23 11:31 /etc/apparmor.d/libvirt/libvirt-c2cf5436-c7c3-402e-9593-ad7dca047ceb
root@i:~# virsh start f
Domain 'f' started

Almost all complete, scheduling general regression tests now.

Regression tests completed as well on x86 and s390x
I only had:
- 8 fails in known-flaky tests which re-ran and worked fine.
- x86 second level VMs failed to start (But tests confirmed that this is not related to this upload)
- needed some fixup for LXD 4.20 behavior
The other slightly more than 2k tests worked all fine.

Marking verified.

The verification of the Stable Release Update for libvirt has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package libvirt - 7.0.0-2ubuntu2.2

---------------
libvirt (7.0.0-2ubuntu2.2) hirsute; urgency=medium

  * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
    avoid issues due to corrupted apparmor profiles (LP: #1927519)

 -- Christian Ehrhardt <email address hidden> Thu, 18 Nov 2021 10:22:28 +0100

This bug was fixed in the package libvirt - 6.0.0-0ubuntu8.15

---------------
libvirt (6.0.0-0ubuntu8.15) focal; urgency=medium

  * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
    avoid issues due to corrupted apparmor profiles (LP: #1927519)

 -- Christian Ehrhardt <email address hidden> Thu, 18 Nov 2021 10:23:11 +0100

This bug was fixed in the package libvirt - 4.0.0-1ubuntu8.20

---------------
libvirt (4.0.0-1ubuntu8.20) bionic; urgency=medium

  * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
    avoid issues due to corrupted apparmor profiles (LP: #1927519)
  * d/p/u/skip-new-pdwtags.patch: avoid issues with backported
    dwarves 1.21 (LP: #1951438)

 -- Christian Ehrhardt <email address hidden> Thu, 18 Nov 2021 10:24:01 +0100

This bug was fixed in the package libvirt - 7.6.0-0ubuntu1.1

---------------
libvirt (7.6.0-0ubuntu1.1) impish; urgency=medium

  * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
    avoid issues due to corrupted apparmor profiles (LP: #1927519)

 -- Christian Ehrhardt <email address hidden> Thu, 18 Nov 2021 10:19:58 +0100

Hello Ioanna, or anyone else affected,

Accepted libvirt into ussuri-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ussuri-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ussuri-needed to verification-ussuri-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ussuri-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Ioanna, or anyone else affected,

Accepted libvirt into stein-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:stein-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-stein-needed to verification-stein-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-stein-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Ioanna, or anyone else affected,

Accepted libvirt into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

VERIFICATION QUEENS

Installed libvirt form queens-proposed

dpkg -l | grep libvirt

ii libvirt-bin 4.0.0-1ubuntu8.20~cloud0 amd64 programs for the libvirt library
ii libvirt-clients 4.0.0-1ubuntu8.20~cloud0 amd64 Programs for the libvirt library
ii libvirt-daemon 4.0.0-1ubuntu8.20~cloud0 amd64 Virtualization daemon
ii libvirt-daemon-driver-storage-rbd 4.0.0-1ubuntu8.20~cloud0 amd64 Virtualization daemon RBD storage driver
ii libvirt-daemon-system 4.0.0-1ubuntu8.20~cloud0 amd64 Libvirt daemon configuration files
ii libvirt0:amd64 4.0.0-1ubuntu8.20~cloud0 amd64 library for interfacing with different virtualization systems

# virsh dominfo ctest1
Id: -
Name: ctest1
UUID: 2fadfa2d-28d8-4bbc-8b31-dfb871881b7e
OS Type: hvm
State: shut off
CPU(s): 1
Max memory: 1048576 KiB
Used memory: 1048576 KiB
Persistent: yes
Autostart: disable
Managed save: no
Security model: apparmor
Security DOI: 0

# cat /dev/null | sudo tee /etc/apparmor.d/libvirt/libvirt-2fadfa2d-28d8-4bbc-8b31-dfb871881b7e

# virsh start ctest1
Domain ctest1 started

VERIFICATION STEIN

Installed libvirt form stein-proposed

dpkg -l | grep libvirt

ii libvirt-clients 5.0.0-1ubuntu2.6~cloud3 amd64 Programs for the libvirt library
ii libvirt-daemon 5.0.0-1ubuntu2.6~cloud3 amd64 Virtualization daemon
ii libvirt-daemon-driver-storage-rbd 5.0.0-1ubuntu2.6~cloud3 amd64 Virtualization daemon RBD storage driver
ii libvirt-daemon-system 5.0.0-1ubuntu2.6~cloud3 amd64 Libvirt daemon configuration files
ii libvirt0:amd64 5.0.0-1ubuntu2.6~cloud3 amd64 library for interfacing with different virtualization systems

# virsh dominfo debiantesting
Id: -
Name: debiantesting
UUID: 47340dd6-80e2-4d14-bdc9-bb2c7564079a
OS Type: hvm
State: shut off
CPU(s): 1
Max memory: 1048576 KiB
Used memory: 1048576 KiB
Persistent: yes
Autostart: disable
Managed save: no
Security model: apparmor
Security DOI: 0

# cat /dev/null | sudo tee /etc/apparmor.d/libvirt/libvirt-47340dd6-80e2-4d14-bdc9-bb2c7564079a

# virsh start debiantesting
Domain debiantesting started

VERIFICATION USSURI

Installed libvirt form ussuri-proposed

dpkg -l | grep libvirt

ii libvirt-clients 6.0.0-0ubuntu8.15~cloud0 amd64 Programs for the libvirt library
ii libvirt-daemon 6.0.0-0ubuntu8.15~cloud0 amd64 Virtualization daemon
ii libvirt-daemon-driver-qemu 6.0.0-0ubuntu8.15~cloud0 amd64 Virtualization daemon QEMU connection driver
ii libvirt-daemon-driver-storage-rbd 6.0.0-0ubuntu8.15~cloud0 amd64 Virtualization daemon RBD storage driver
ii libvirt-daemon-system 6.0.0-0ubuntu8.15~cloud0 amd64 Libvirt daemon configuration files
ii libvirt-daemon-system-systemd 6.0.0-0ubuntu8.15~cloud0 amd64 Libvirt daemon configuration files (systemd)
ii libvirt0:amd64 6.0.0-0ubuntu8.15~cloud0 amd64 library for interfacing with different virtualization systems

# virsh dominfo debiantesting
Id: -
Name: debiantesting
UUID: 47340dd6-80e2-4d14-bdc9-bb2c7564079a
OS Type: hvm
State: shut off
CPU(s): 1
Max memory: 1048576 KiB
Used memory: 1048576 KiB
Persistent: yes
Autostart: disable
Managed save: no
Security model: apparmor
Security DOI: 0

# cat /dev/null | sudo tee /etc/apparmor.d/libvirt/libvirt-47340dd6-80e2-4d14-bdc9-bb2c7564079a

# virsh start debiantesting
Domain debiantesting started

The verification of the Stable Release Update for libvirt has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package libvirt - 6.0.0-0ubuntu8.15~cloud0
---------------

 libvirt (6.0.0-0ubuntu8.15~cloud0) bionic-ussuri; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 libvirt (6.0.0-0ubuntu8.15) focal; urgency=medium
 .
   * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
     avoid issues due to corrupted apparmor profiles (LP: #1927519)

The verification of the Stable Release Update for libvirt has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package libvirt - 4.0.0-1ubuntu8.20~cloud0
---------------

 libvirt (4.0.0-1ubuntu8.20~cloud0) xenial-queens; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 libvirt (4.0.0-1ubuntu8.20) bionic; urgency=medium
 .
   * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
     avoid issues due to corrupted apparmor profiles (LP: #1927519)
   * d/p/u/skip-new-pdwtags.patch: avoid issues with backported
     dwarves 1.21 (LP: #1951438)

The verification of the Stable Release Update for libvirt has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package libvirt - 5.0.0-1ubuntu2.6~cloud3
---------------

 libvirt (5.0.0-1ubuntu2.6~cloud3) bionic-stein; urgency=medium
 .
   * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
     avoid issues due to corrupted apparmor profiles (LP: #1927519)

This bug was fixed in the package libvirt - 7.6.0-0ubuntu3

---------------
libvirt (7.6.0-0ubuntu3) jammy; urgency=medium

  * d/libvirt-daemon-system.postinst: create user/group swtpm if not present
    due to swtpm-tools (LP: #1951975)

 -- Christian Ehrhardt <email address hidden> Wed, 24 Nov 2021 07:50:53 +0100

This bug was fixed in the package libvirt - 8.0.0-1ubuntu6~cloud0
---------------

 libvirt (8.0.0-1ubuntu6~cloud0) focal-yoga; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 libvirt (8.0.0-1ubuntu6) jammy; urgency=medium
 .
   * d/control: recommend swtpm-tools (LP: #1948748)
 .
 libvirt (8.0.0-1ubuntu5) jammy; urgency=medium
 .
   * apparmor: Fix QEMU access for UEFI variable files. Backported from
     upstream master commit 7aec69b7fb9d0c. (Closes: #1006324, LP: #1962035)
     Refresh apparmor_profiles_local_include.patch to resolve the conflict.
 .
 libvirt (8.0.0-1ubuntu4) jammy; urgency=medium
 .
   * No-change rebuild against libwireshark15.
 .
 libvirt (8.0.0-1ubuntu3) jammy; urgency=medium
 .
   * Revert "d/rules, d/libvirt-daemon-system.{postinst,prerm}: never stop
     system services and sockets."
     Due to the fix being in debhelper we no more need this mitigation now.
     (LP: #1959054)
 .
 libvirt (8.0.0-1ubuntu2) jammy; urgency=medium
 .
   * No-change rebuild to update maintainer scripts, see LP: 1959054
 .
 libvirt (8.0.0-1ubuntu1) jammy; urgency=medium
 .
   * Merge 8.0.0 from Debian unstable (LP: #1946869)
     Among many other fixes and improvements this fixes ceph usage
     in regard to apparmor (LP: #1588576)
     Remaining changes:
     - libvirt-uri.sh: Automatically switch default libvirt URI for users
       via user profile (xen URI on dom0, qemu:///system otherwise)
       [contains lintian fixups of 6.6.0-1ubuntu1]
     - Disable libssh2 support (universe dependency)
     - d/control: add libzfslinux-dev to build-deps
     - d/control: drop libvirt-lxc, vbox and xen drivers to suggest
     - d/control: breaks replaces for augeas lenses move in 6.0.0-1
       (follows Debian, droppable >22.04)
     - debian/patches/ubuntu/ovmf_paths.patch: adjust paths to secboot.fd UEFI
       Secure Boot enabled variants of the OVMF firmware and variable store for
       the paths where we ship these files in Ubuntu.
     - Set qemu-group to kvm (for compat with older ubuntu)
     - Additional apport package-hook
     - Autostart default bridged network (As upstream does, but not Debian).
       In addition to just enabling it our solution provides:
       + do not autostart if subnet is already taken (e.g. in guests).
       + iterate some alternative subnets before giving up
     - d/p/ubuntu/Allow-libvirt-group-to-access-the-socket.patch: This is
       the group based access to libvirt functions as it was used in Ubuntu
       for quite a long time.
       + d/p/ubuntu/daemon-augeas-fix-expected.patch fix some related tests
         due to the group access change.
       + d/libvirt-daemon-system.postinst: add users in sudo to the libvirt
         group.
     - d/p/u/parallel-shutdown.patch: set parallel shutdown by default.
     - Update README.Debian with Ubuntu changes
     - d/p/ubuntu/ubuntu_machine_type.patch: accept ubuntu types as pci440fx
     - fix autopkgtests (LP 1899180)
       + d/t/control, d/t/smoke-qemu-session: fixup smoke-qemu-session by making
         vmlinuz available and accessible (Debian bug 848314)
       + d/t/control: fix smoke-qemu-session by ensuring the service will r...