Ubuntu
libiscsi package

libiscsi FTBFS with gcc 10

Bug #1894129 reported by Brian Murray
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libiscsi (Debian)
Fix Released
Unknown
libiscsi (Ubuntu)
Fix Released
Undecided
Christian Ehrhardt 

Bug Description

Imported from Debian bug http://bugs.debian.org/969074:

Source: libiscsi
Version: 1.19.0-2
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/package.php?p=libiscsi

...
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:782: multiple definition of `local_iscsi_queue_pdu'; iscsi-test-cu.o:./test-tool/iscsi-support.h:782: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.c:122: multiple definition of `real_iscsi_queue_pdu'; iscsi-test-cu.o:./test-tool/iscsi-test-cu.c:66: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:63: multiple definition of `copy_aborted_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:63: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:62: multiple definition of `miscompare_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:62: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:61: multiple definition of `removal_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:61: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:60: multiple definition of `sanitize_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:60: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:59: multiple definition of `write_protect_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:59: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:58: multiple definition of `unsupp_desc_code_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:58: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:57: multiple definition of `too_many_desc_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:57: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:56: multiple definition of `param_list_len_err_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:56: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:55: multiple definition of `invalid_cdb_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:55: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:54: multiple definition of `lba_oob_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:54: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:53: multiple definition of `no_medium_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:53: first defined here
...
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:1186: iscsi-test-cu] Error 1

Related branches

~paelzer/ubuntu/+source/libiscsi:fix-FTBFS-1894129-GROOVY
Lucas Kanashiro (community): Approve
Canonical Server: Pending requested
Canonical Server packageset reviewers: Pending requested
Diff: 989 lines (+889/-1)
15 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/lp-1894129-test-tool-BlockEraseReserved-override-driver-queue_p.patch (+74/-0)
debian/patches/lp-1894129-test-tool-BlockEraseReserved-skip-unless-iSCSI.patch (+39/-0)
debian/patches/lp-1894129-test-tool-Compare-Write-override-driver-queue_pdu-ca.patch (+71/-0)
debian/patches/lp-1894129-test-tool-Compare-Write-skip-InvalidDataOutSize-unle.patch (+39/-0)
debian/patches/lp-1894129-test-tool-CryptoEraseReserved-override-driver-queue_.patch (+74/-0)
debian/patches/lp-1894129-test-tool-CryptoEraseReserved-skip-unless-iSCSI.patch (+39/-0)
debian/patches/lp-1894129-test-tool-OverwriteReserved-override-driver-queue_pd.patch (+68/-0)
debian/patches/lp-1894129-test-tool-Use-extern-int-in-headers.patch (+58/-0)
debian/patches/lp-1894129-test-tool-iSCSICmdSnTooHigh-override-driver-queue_pd.patch (+68/-0)
debian/patches/lp-1894129-test-tool-iSCSICmdSnTooLow-override-driver-queue_pdu.patch (+69/-0)
debian/patches/lp-1894129-test-tool-iSCSIDataSnInvalid-override-driver-queue_p.patch (+166/-0)
debian/patches/lp-1894129-test-tool-remove-unused-iscsi_queue_pdu-symbol-overl.patch (+104/-0)
debian/patches/series (+12/-0)
Brian Murray (brian-murray)
tags: added: update-excuse
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI:
- https://github.com/sahlberg/libiscsi/issues/340
- https://github.com/sahlberg/libiscsi/commit/dd17293bcc188dbefc420ee23b77bc9bb7c5e9a2

tags: added: server-next
Christian Ehrhardt  (paelzer)
Changed in libiscsi (Ubuntu):
assignee: nobody → Christian Ehrhardt  (paelzer)
Christian Ehrhardt  (paelzer)
Changed in libiscsi (Ubuntu):
status: New → Triaged
status: Triaged → In Progress
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Actually a full set (of structurally the same changes):
dd17293b
2ae45ac1
77279dd4
c830a3b5
fdc45fad
153ca193
575ba224
c067eef9
310e9ace
60a5856f

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

And b705f9e5 after fdc45fad
Let us hope we don't need cc3ddbf as well since that has a lot of mismatches when applying.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

With the above we are now at:
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:63: multiple definition of `copy_aborted_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:63: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:62: multiple definition of `miscompare_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:62: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:61: multiple definition of `removal_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:61: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:60: multiple definition of `sanitize_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:60: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:59: multiple definition of `write_protect_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:59: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:58: multiple definition of `unsupp_desc_code_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:58: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:57: multiple definition of `too_many_desc_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:57: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:56: multiple definition of `param_list_len_err_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:56: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:55: multiple definition of `invalid_cdb_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:55: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:54: multiple definition of `lba_oob_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:54: first defined here
/usr/bin/ld: iscsi-support.o:./test-tool/iscsi-support.h:53: multiple definition of `no_medium_ascqs'; iscsi-test-cu.o:./test-tool/iscsi-support.h:53: first defined here

Which repeats for every header used (looong list)

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Combined fix found and presented in MP:
https://code.launchpad.net/~paelzer/ubuntu/+source/libiscsi/+git/libiscsi/+merge/390397

Also submitted to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969074

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libiscsi - 1.19.0-2ubuntu1

---------------
libiscsi (1.19.0-2ubuntu1) groovy; urgency=medium

  * d/p/lp-1894129-*: fix FTBFS (LP: #1894129)

 -- Christian Ehrhardt <email address hidden> Tue, 08 Sep 2020 14:31:03 +0200

Changed in libiscsi (Ubuntu):
status: In Progress → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in libiscsi (Debian):
importance: Undecided → Unknown
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.