update-locale not perform correctly sanity checks

Bug #1892825 reported by bs
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glibc (Ubuntu)
Fix Released
Medium
Gunnar Hjalmarsson
Bionic
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Hirsute
Won't Fix
Undecided
Unassigned
Impish
Won't Fix
Undecided
Unassigned
pam (Ubuntu)
New
Undecided
Unassigned
Bionic
New
Undecided
Unassigned
Focal
New
Undecided
Unassigned
Hirsute
New
Undecided
Unassigned
Impish
Won't Fix
Undecided
Unassigned

Bug Description

[impact]
A simple typo using the update-locale script can render a system inoperable without booting into single user mode or similar:

$ sudo update-locale LANGUAGE = en_US.UTF-8
$ sudo -s
sudo: pam_open_session: Bad item passed to pam_*_item()
sudo: policy plugin failed session initialization

[test case]
$ cp /etc/default/locale /tmp/locale
$ update-locale --locale-file /tmp/locale LANGUAGE = en_US.UTF-8

"diff -u /etc/default/locale /tmp/locale" should be empty.

$ update-locale --locale-file /tmp/locale LANGUAGE=en_US.UTF-8

The LANGUAGE=en_US.UTF-8 line should have been replaced by LANGUAGE=en_GB.UTF-8.

$ update-locale --locale-file /tmp/locale LANGUAGE

The LANGUAGE setting is now commented out.

[regression potential]
Apart from the general concerns about a glibc rebuild, this is a simple change to a simple script. Performing the test as in the test case section is enough to ensure it still works.

[original description]
By passing wrong input as following:
 sudo update-locale LANGUAGE = en_US.UTF-8
result is:
...
#LANGUAGE=en
=

This "equal" sign that was added makes system completely unusable(can't run sudo anymore):

bentzy@bentzy-nb:~$ sudo vim /etc/default/locale
sudo: pam_open_session: Bad item passed to pam_*_item()
sudo: policy plugin failed session initialization

Fixed it booting from installation disk and fixing corrupted /etc/default/locale

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: locales 2.31-0ubuntu9
Uname: Linux 5.5.4-050504-generic x86_64
ApportVersion: 2.20.11-0ubuntu27.6
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: KDE
Date: Tue Aug 25 09:36:03 2020
InstallationDate: Installed on 2020-08-17 (7 days ago)
InstallationMedia: Kubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
PackageArchitecture: all
SourcePackage: glibc
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
bs (bentzy-sagiv) wrote :
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks for your report. Submitted merge request which ought to prevent this from happening.

https://salsa.debian.org/glibc-team/glibc/-/merge_requests/1

Changed in glibc (Ubuntu):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
importance: Undecided → Medium
status: New → In Progress
Mathew Hodson (mhodson)
tags: added: patch-forwarded-debian
Revision history for this message
Dan Bungert (dbungert) wrote :

It would be nice to merge something, the failure case listed above is pretty nasty.
Please see the launchpad MP, I have a suggestion.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks Dan, I changed the MR in accordance with your suggestion.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Adding a pam task, pam_env does some sanity checking of the input (e.g. %=1 in /etc/default/locale gets ignored) so I don't see why an empty variable name should cause a total failure. But will fix the update-locale script too.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@Michael: I could easily reproduce the issue at the time (a year ago).

Good that it's about to be fixed. As you can see in comment #2 I first turned to Debian, but the response was a bit disappointing. Any chance that you can handle this on the Debian side too?

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Fwiw I reported this as a pam bug too https://github.com/linux-pam/linux-pam/issues/395

description: updated
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello bs, or anyone else affected,

Accepted glibc into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glibc/2.31-0ubuntu9.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in glibc (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I verified the test case using locales 2.31-0ubuntu9.4 from focal-proposed.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glibc/2.31-0ubuntu9.4)

All autopkgtests for the newly accepted glibc (2.31-0ubuntu9.4) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

snapd-glib/1.58-0ubuntu0.20.04.0 (armhf)
apt/2.0.6 (armhf)
libmath-mpfr-perl/4.13-1 (armhf)
art-nextgen-simulation-tools/20160605+dfsg-4 (armhf)
ruby-nokogiri/1.10.7+dfsg1-2build1 (armhf)
r-cran-rgdal/1.4-8-1build2 (armhf)
arrayfire/3.3.2+dfsg1-4ubuntu4 (armhf)
libpango-perl/1.227-3build1 (armhf)
libimage-sane-perl/5-1 (s390x)
ruby-bootsnap/1.4.6-1 (arm64)
mle/1.4.3-1 (ppc64el, arm64)
libsyntax-keyword-try-perl/0.11-1build1 (armhf)
awesome/4.3-4 (armhf)
cysignals/1.10.2+ds-4 (arm64)
gvfs/1.44.1-1ubuntu1 (ppc64el)
libuv1/1.34.2-1ubuntu1.3 (amd64)
bali-phy/3.4.1+dfsg-2build1 (arm64, s390x)
g10k/0.5.7-1 (armhf)
litl/0.1.9-7 (amd64)
ruby-libxml/3.1.0-2 (armhf)
ffmpeg/7:4.2.4-1ubuntu0.1 (armhf)
yorick/2.2.04+dfsg1-10 (ppc64el, s390x)
linux-ibm/5.4.0-1010.11 (amd64)
liborcus/0.15.3-3build2 (armhf)
node-nodedbi/1.0.13+dfsg-1build1 (amd64)
r-bioc-delayedarray/0.12.2+dfsg-1 (armhf)
postgresql-unit/7.2-2 (armhf)
python-freecontact/1.1-5build2 (armhf)
r-cran-rwave/2.4-8-2 (armhf)
libproc-fastspawn-perl/1.2-1build2 (armhf)
linux-hwe-5.11/5.11.0-44.48~20.04.2 (armhf)
foo2zjs/20171202dfsg0-4 (armhf)
r-cran-erm/1.0-0-1 (armhf)
libsys-cpuload-perl/0.03-8build5 (armhf)
libhttp-parser-xs-perl/0.17-1build5 (armhf)
php-luasandbox/3.0.3-2build2 (armhf)
pynfft/1.3.2-3build1 (armhf)
r-cran-processx/3.4.2-1 (ppc64el)
r-bioc-multtest/2.42.0-1 (armhf)
linux-hwe-5.13/5.13.0-23.23~20.04.2 (armhf)
python-blosc/1.7.0+ds1-2ubuntu2 (armhf)
gyoto/1.4.4-3 (armhf)
r-cran-sem/3.1.9-2build1 (armhf)
libtext-reflow-perl/1.17-1build3 (armhf)
python3.9/3.9.5-3ubuntu0~20.04.1 (armhf)
r-cran-samr/3.0-1 (armhf)
r-cran-dplyr/0.8.4-1 (armhf)
python3.8/3.8.10-0ubuntu1~20.04.2 (armhf)
findent/3.1.1-1build1 (armhf)
mercurial/5.3.1-1ubuntu1 (amd64)
libmemcached-libmemcached-perl/1.001801+dfsg-2build4 (armhf)
openbabel/3.0.0+dfsg-3ubuntu3 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#glibc

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Verified:

root@focal:~# dpkg-query -W libc6
libc6:amd64 2.31-0ubuntu9.2
root@focal:~# cp /etc/default/locale /tmp/locale
root@focal:~# update-locale --locale-file /tmp/locale LANGUAGE = en_US.UTF-8
root@focal:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2019-10-21 18:01:06.000000000 +0000
+++ /tmp/locale 2022-01-25 07:54:27.491679519 +0000
@@ -1 +1,2 @@
 LANG=C.UTF-8
+=
root@focal:~# apt install libc6/focal-proposed libc-bin/focal-proposed locales/focal-proposed libc6-dev/focal-proposed libc6-dbg/focal-proposed libc-dev-bin/focal-proposed
[...]
root@focal:~# cp /etc/default/locale /tmp/locale
root@focal:~# update-locale --locale-file /tmp/locale LANGUAGE = en_US.UTF-8
root@focal:~# diff -u /etc/default/locale /tmp/locale
root@focal:~#

tags: added: verification-done
removed: verification-needed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Oh heh Gunnar had done that already :) Doubly verified then.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello bs, or anyone else affected,

Accepted glibc into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glibc/2.31-0ubuntu9.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-focal
removed: verification-done verification-done-focal
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glibc/2.31-0ubuntu9.5)

All autopkgtests for the newly accepted glibc (2.31-0ubuntu9.5) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

garli/2.1-3build1 (armhf)
fpc/3.0.4+dfsg-23 (armhf)
lazarus/2.0.6+dfsg-3 (armhf)
libuv1/1.34.2-1ubuntu1.3 (i386)
ikiwiki-hosting/0.20180719-2 (armhf)
rtags/2.37-1 (amd64)
mercurial/5.3.1-1ubuntu1 (amd64, ppc64el)
foo2zjs/20171202dfsg0-4 (armhf)
frameworkintegration/5.68.0-0ubuntu1 (armhf)
hilive/2.0a-3build2 (arm64)
ruby-libxml/3.1.0-2 (s390x)
plasma-framework/5.68.0-0ubuntu1 (armhf)
feersum/1.407-2 (s390x)
r-bioc-delayedarray/0.12.2+dfsg-1 (armhf)
php-luasandbox/3.0.3-2build2 (ppc64el)
snapd-glib/1.58-0ubuntu0.20.04.0 (armhf)
bolt/0.8-4ubuntu1 (ppc64el)
threadweaver/5.68.0-0ubuntu1 (armhf)
python3.8/3.8.10-0ubuntu1~20.04.2 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#glibc

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

description: updated
Changed in glibc (Ubuntu Hirsute):
status: New → Won't Fix
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello bs, or anyone else affected,

Accepted glibc into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glibc/2.31-0ubuntu9.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glibc/2.31-0ubuntu9.8)

All autopkgtests for the newly accepted glibc (2.31-0ubuntu9.8) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

ruby-stackprof/0.2.15-2 (arm64)
sphinxbase/0.8+5prealpha+1-8 (armhf)
r-cran-ps/1.3.2-2 (s390x)
linux-hwe-5.13/5.13.0-37.42~20.04.1 (armhf)
mercurial/5.3.1-1ubuntu1 (armhf, ppc64el)
linux-hwe-5.11/5.11.0-61.61 (armhf)
mbedtls/2.16.4-1ubuntu2 (s390x)
libreoffice/1:6.4.7-0ubuntu0.20.04.4 (armhf)
ruby-ferret/0.11.8.7-2 (amd64)
cross-toolchain-base/43ubuntu3.1 (ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#glibc

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello bs, or anyone else affected,

Accepted glibc into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glibc/2.31-0ubuntu9.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glibc/2.31-0ubuntu9.9)

All autopkgtests for the newly accepted glibc (2.31-0ubuntu9.9) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

hilive/2.0a-3build2 (arm64)
tomb/2.7+dfsg2-1 (arm64)
linux-hwe-5.13/5.13.0-40.45~20.04.1 (armhf)
bali-phy/3.4.1+dfsg-2build1 (s390x, arm64)
smalt/0.7.6-9 (ppc64el)
mariadb-10.3/1:10.3.34-0ubuntu0.20.04.1 (armhf)
feersum/1.407-2 (s390x)
kopanocore/8.7.0-7ubuntu1 (amd64)
r-cran-ps/1.3.2-2 (s390x, ppc64el)
libreoffice/1:6.4.7-0ubuntu0.20.04.4 (amd64)
imagemagick/8:6.9.10.23+dfsg-2.1ubuntu11.4 (armhf)
ruby-stackprof/0.2.15-2 (amd64)
gnome-photos/3.34.1-1 (ppc64el)
linux-azure-5.11/5.11.0-1029.32~20.04.2 (amd64)
linux-intel-5.13/5.13.0-1010.10 (amd64)
php-luasandbox/3.0.3-2build2 (armhf, arm64)
mbedtls/2.16.4-1ubuntu2 (amd64, ppc64el)
cross-toolchain-base/43ubuntu3.1 (ppc64el)
rtags/2.37-1 (amd64)
gvfs/1.44.1-1ubuntu1 (arm64, ppc64el)
linux-oem-5.14/5.14.0-1033.36 (amd64)
linux-azure-cvm/5.4.0-1076.79+cvm1 (amd64)
mercurial/5.3.1-1ubuntu1 (armhf)
r-cran-satellite/1.0.2-1build1 (armhf)
s3ql/3.3.2+dfsg-1ubuntu1 (armhf)
snapd/2.54.3+20.04.1ubuntu0.2 (s390x, arm64, amd64, ppc64el)
sphinxbase/0.8+5prealpha+1-8 (armhf)
gemma/0.98.1+dfsg-1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#glibc

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Verified:

root@focal-vm:~# dpkg -l locales | grep ^ii
ii locales 2.31-0ubuntu9.7 all GNU C Library: National Language (locale) data [support]
root@focal-vm:~# cp /etc/default/locale /tmp/locale
root@focal-vm:~# update-locale --locale-file /tmp/locale LANGUAGE = en_US.UTF-8
root@focal-vm:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-04-19 18:07:15.583098433 +0000
+++ /tmp/locale 2022-04-26 00:56:47.140767044 +0000
@@ -1 +1,2 @@
 LANG=en_US.UTF-8
+=
root@focal-vm:~# apt install -y -t focal-proposed libc6 locales libc-bin
[snip]

root@focal-vm:~# dpkg -l locales | grep ^ii
ii locales 2.31-0ubuntu9.9 all GNU C Library: National Language (locale) data [support]
root@focal-vm:~# cp /etc/default/locale /tmp/locale
root@focal-vm:~# update-locale --locale-file /tmp/locale LANGUAGE = en_US.UTF-8
root@focal-vm:~# diff -u /etc/default/locale /tmp/locale
root@focal-vm:~# update-locale --locale-file /tmp/locale LANGUAGE=en_US.UTF-8
root@focal-vm:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-04-26 00:58:34.429027581 +0000
+++ /tmp/locale 2022-04-26 00:58:39.333040731 +0000
@@ -1 +1,2 @@
 LANG=en_US.UTF-8
+LANGUAGE=en_US.UTF-8
root@focal-vm:~# update-locale --locale-file /tmp/locale LANGUAGE=en_GB.UTF-8
root@focal-vm:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-04-26 00:58:34.429027581 +0000
+++ /tmp/locale 2022-04-26 00:58:58.457092930 +0000
@@ -1 +1,2 @@
 LANG=en_US.UTF-8
+LANGUAGE=en_GB.UTF-8
root@focal-vm:~# update-locale --locale-file /tmp/locale LANGUAGE
root@focal-vm:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-04-26 00:58:34.429027581 +0000
+++ /tmp/locale 2022-04-26 00:59:11.493129343 +0000
@@ -1 +1,2 @@
 LANG=en_US.UTF-8
+#LANGUAGE=en_GB.UTF-8

tags: added: verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for glibc has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package glibc - 2.31-0ubuntu9.9

---------------
glibc (2.31-0ubuntu9.9) focal; urgency=medium

  * Disable testsuite on riscv64. It is failing maths tests intermittently in
    ways that cannot be a glibc regression and is disabled in later series
    anyway.

glibc (2.31-0ubuntu9.8) focal; urgency=medium

  * Update for 20.04. (LP: #1951033)

  [ Balint Reczey ]
  * Cherry-pick upstream patch to fix building with -moutline-atomics
  * Prevent rare deadlock in pthread_cond_signal (LP: #1899800)

  [ Matthias Klose ]
  * Revert: Use DH_COMPAT=8 for dh_strip to fix debug sections for valgrind.
    Enables debugging ld.so related issues. (LP: #1918035)
  * Don't strip ld.so on armhf. (LP: #1927192)

  [ Gunnar Hjalmarsson ]
  * d/local/usr_sbin/update-locale: improve sanity checks. (LP: #1892825)

  [ Heitor Alves de Siqueira ]
  * d/p/u/git-lp1928508-reversing-calculation-of-__x86_shared_non_temporal.patch:
    - Fix memcpy() performance regression on x86 AMD systems (LP: #1928508)

  [ Aurelien Jarno ]
  * debian/debhelper.in/libc.preinst: drop the check for kernel release
    > 255 now that glibc and preinstall script are fixed. (LP: #1962225)

  [ Michael Hudson-Doyle ]
  * libc6 on arm64 is now built with -moutline-atomics so libc6-lse can now be
    an empty package that is safe to remove. (LP: #1912652)
  * d/patches/u/aarch64-memcpy-improvements.patch: Backport memcpy
    improvements. (LP: #1951032)
  * Add test-float64x-yn to xfails on riscv64.

 -- Michael Hudson-Doyle <email address hidden> Thu, 07 Apr 2022 13:24:41 +1200

Changed in glibc (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

This was fixed in devel (and with that jammy) through the upload of glibc 2.35-0ubuntu1, even if it wasn't mentioned in d/changelog. So marking as fixed.

Changed in glibc (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello bs, or anyone else affected,

Accepted glibc into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glibc/2.27-3ubuntu1.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in glibc (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Verified that the new version does not generated bogus lines on bionic:

root@lp-1892825-bionic:~# cp /etc/default/locale /tmp/locale
root@lp-1892825-bionic:~# update-locale --locale-file /tmp/locale LANG = C.UTF-8
root@lp-1892825-bionic:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-05-09 15:53:23.000000000 +0000
+++ /tmp/locale 2022-05-13 03:05:13.859996448 +0000
@@ -1 +1 @@
-LANG=C.UTF-8
+#LANG=C.UTF-8
root@lp-1892825-bionic:~# update-locale --locale-file /tmp/locale LANG=en_US.UTF-8
root@lp-1892825-bionic:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-05-09 15:53:23.000000000 +0000
+++ /tmp/locale 2022-05-13 03:05:36.008238719 +0000
@@ -1 +1 @@
-LANG=C.UTF-8
+LANG=en_US.UTF-8
root@lp-1892825-bionic:~# update-locale --locale-file /tmp/locale LANG=
root@lp-1892825-bionic:~# update-locale --locale-file /tmp/locale LANG
root@lp-1892825-bionic:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-05-09 15:53:23.000000000 +0000
+++ /tmp/locale 2022-05-13 03:05:43.680321932 +0000
@@ -1 +1 @@
-LANG=C.UTF-8
+#LANG=
root@lp-1892825-bionic:~# cp /etc/default/locale /tmp/locale
root@lp-1892825-bionic:~# update-locale --locale-file /tmp/locale LANG
root@lp-1892825-bionic:~# diff -u /etc/default/locale /tmp/locale
--- /etc/default/locale 2022-05-09 15:53:23.000000000 +0000
+++ /tmp/locale 2022-05-13 03:05:56.384458949 +0000
@@ -1 +1 @@
-LANG=C.UTF-8
+#LANG=C.UTF-8
root@lp-1892825-bionic:~# dpkg-query -W locales
locales 2.27-3ubuntu1.6

tags: added: verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glibc/2.27-3ubuntu1.6)

All autopkgtests for the newly accepted glibc (2.27-3ubuntu1.6) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

docker.io/20.10.7-0ubuntu5~18.04.3 (i386, amd64, s390x, arm64, ppc64el)
sbd/1.3.1-2 (amd64)
chromium-browser/100.0.4896.127-0ubuntu0.18.04.1 (armhf)
pymol/1.8.4.0+dfsg-1build1 (s390x, ppc64el)
nvidia-graphics-drivers-390/390.147-0ubuntu0.18.04.1 (i386)
pgbouncer/1.8.1-1build1 (amd64)
r-cran-urltools/1.7.0-1ubuntu1 (arm64, ppc64el)
firefox/100.0+build2-0ubuntu0.18.04.1 (arm64)
python-llfuse/1.3.3+dfsg-3 (arm64)
c-icap/1:0.4.4-1 (ppc64el)
givaro/4.0.2-8ubuntu1 (armhf)
apport/2.20.9-0ubuntu7.27 (amd64)
threadweaver/5.44.0-0ubuntu1 (i386)
apt/1.6.14 (arm64)
containerd/1.5.5-0ubuntu3~18.04.2 (amd64, arm64)
glibc/2.27-3ubuntu1.6 (armhf)
cura-engine/1:3.1.0-2 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#glibc

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package glibc - 2.27-3ubuntu1.6

---------------
glibc (2.27-3ubuntu1.6) bionic; urgency=medium

  [ Gunnar Hjalmarsson ]
  * d/local/usr_sbin/update-locale: improve sanity checks. (LP: #1892825)

  [ Aurelien Jarno ]
  * debian/debhelper.in/libc.preinst: drop the check for kernel release
    > 255 now that glibc and preinstall script are fixed. (LP: #1962225)

 -- Michael Hudson-Doyle <email address hidden> Tue, 03 May 2022 22:19:39 +1200

Changed in glibc (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

Ubuntu 21.10 (Impish Indri) has reached end of life, so this bug will not be fixed for that specific release.

Changed in glibc (Ubuntu Impish):
status: New → Won't Fix
Changed in pam (Ubuntu Impish):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.