dist upgrade process passes a number along with package to apport

It looks to me like the hook which is supposed to report package installation failures is now not working likely because '-p' is expecting or being passed the wrong value. Here are some examples:

/usr/bin/python3 /usr/share/apport/package_hook -p 016-google-chrome-stable --tags dist-upgrade ...
/usr/bin/python3 /usr/share/apport/package_hook -p 364-openjdk-11-jdk-headless --tags dist-upgrade ...
/usr/bin/python3 /usr/share/apport/package_hook -p 687-pop-icon-theme --tags dist-upgrade ...

Here's the traceback too:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 297, in __getitem__
    rawpkg = self._cache[key]
KeyError: '23-gimp-data'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apport/packaging_impl.py", line 156, in _apt_pkg
    return self._cache()[package]
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 299, in __getitem__
    raise KeyError('The cache has no package named %r' % key)
KeyError: "The cache has no package named '23-gimp-data'"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/share/apport/package_hook", line 48, in <module>
    pr['SourcePackage'] = apport.packaging.get_source(options.package)
  File "/usr/lib/python3/dist-packages/apport/packaging_impl.py", line 189, in get_source
    if self._apt_pkg(package).installed:
  File "/usr/lib/python3/dist-packages/apport/packaging_impl.py", line 158, in _apt_pkg
    raise ValueError('package %s does not exist' % package)
ValueError: package 23-gimp-data does not exist

I was able to recreate this during a distribution upgrade from 18.04 LTS to 20.04 LTS with pure-ftpd installed.

This bug was fixed in the package ubuntu-release-upgrader - 1:20.10.3

---------------
ubuntu-release-upgrader (1:20.10.3) groovy; urgency=medium

  [ Dimitri John Ledkov ]
  * Use ubuntu-archive-keyring to verify upgrades, irrespective of how
    apt-key is configured.

  [ Brian Murray ]
  * utils/demotions.py: also use the ubuntu-archive-keyring when determining
    packages that were demoted.

 -- Brian Murray <email address hidden> Tue, 30 Jun 2020 09:15:09 -0700

Hello errors.ubuntu.com, or anyone else affected,

Accepted ubuntu-release-upgrader into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:20.04.20 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

All autopkgtests for the newly accepted ubuntu-release-upgrader (1:20.04.20) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:20.04.10.1 (armhf)
update-motd/3.6-0ubuntu6 (armhf, ppc64el, amd64, arm64, s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#ubuntu-release-upgrader

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Using the version of the dist-upgrader from focal-proposed I did not encounter a Traceback and did end up with a crash file about the installation of pure-ftpd-common. So I'm setting this to verification-done.

bdmurray@clean-bionic-amd64:/tmp/u-r-u$ ls /var/crash/
pure-ftpd-common.0.crash
bdmurray@clean-bionic-amd64:/tmp/u-r-u$ head /var/log/dist-upgrade/main.log
2020-07-02 09:55:51,371 INFO Using config files '['./DistUpgrade.cfg.bionic']'
2020-07-02 09:55:51,371 INFO uname information: 'Linux clean-bionic-amd64 4.15.0-109-generic #110-Ubuntu SMP Tue Jun 23 02:39:32 UTC 2020 x86_64'
2020-07-02 09:55:51,759 INFO apt version: '1.6.12ubuntu0.1'
2020-07-02 09:55:51,759 INFO python version: '3.6.9 (default, Apr 18 2020, 01:56:04)
[GCC 8.4.0]'
2020-07-02 09:55:51,761 INFO release-upgrader version '20.04.20' started
2020-07-02 09:55:51,766 INFO locale: 'en_US' 'UTF-8'
2020-07-02 09:55:51,872 DEBUG Using 'DistUpgradeViewText' view
2020-07-02 09:55:51,912 DEBUG enable dpkg --force-overwrite
2020-07-02 09:55:51,941 DEBUG creating statefile: '/var/log/dist-upgrade/apt-clone_system_state.tar.gz'
bdmurray@clean-bionic-amd64:/tmp/u-r-u$ cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04 LTS"

All autopkgtests for the newly accepted ubuntu-release-upgrader (1:20.04.20) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:20.04.10.1 (armhf)
update-motd/3.6-0ubuntu6 (armhf, s390x, amd64, arm64, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#ubuntu-release-upgrader

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Hello errors.ubuntu.com, or anyone else affected,

Accepted ubuntu-release-upgrader into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:20.04.21 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

The verification in comment #7 is still valid as 1:20.04.21 just changed the motd file 91-release-upgrade.

This bug was fixed in the package ubuntu-release-upgrader - 1:20.04.21

---------------
ubuntu-release-upgrader (1:20.04.21) focal; urgency=medium

  * debian/91-release-upgrade: make it work in dash. (LP: #1873545)

ubuntu-release-upgrader (1:20.04.20) focal; urgency=medium

  * debian/91-release-upgrade: exit 0 if run as a non-root user.
    (LP: #1873545)
  * Only pass the package name to apport in the event that there is a dpkg
    error during a distribution upgrade. (LP: #1884148)

 -- Brian Murray <email address hidden> Mon, 06 Jul 2020 08:42:50 -0700

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.