Ubuntu
python-certbot package

FTBFS in focal due to build-time test failures

Bug #1876933 reported by Andreas Hasenack
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-certbot (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
Christian Ehrhardt 

Bug Description

[SRU Information]

N/A, since this is a built time test failure only.

[Original Description]
==================================== ERRORS ====================================
_______________ ERROR collecting certbot/plugins/common_test.py ________________
certbot/plugins/common_test.py:26: in <module>
    challenges.TLSSNI01(token=b'token1'), "pending"),
E AttributeError: module 'acme.challenges' has no attribute 'TLSSNI01'
=============================== warnings summary ===============================
certbot/plugins/disco.py:183
  /home/ubuntu/deb/python-certbot/python-certbot-0.40.0/certbot/plugins/disco.py:183: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    class PluginsRegistry(collections.Mapping):

/usr/lib/python3/dist-packages/requests_toolbelt/_compat.py:11
  /usr/lib/python3/dist-packages/requests_toolbelt/_compat.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    from collections import Mapping, MutableMapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
===================== 2 warnings, 1 error in 1.33 seconds ======================
make[1]: *** [debian/rules:35: override_dh_auto_test] Error 2

This is due to python-acme's version bump which removed TLSSNI01.

The commit below fixes it, but has impacts in other packages, see https://bugs.launchpad.net/ubuntu/+source/python-certbot-nginx/+bug/1875471/comments/8 for details:

https://github.com/certbot/certbot/commit/4b488614cf7749c8139c11f0983fe4b71e29827f

See original description

Related branches

~racb/ubuntu/+source/python-certbot:acmev1-config-focal
Christian Ehrhardt  (community): Approve
Brad Warren (community): Approve
Canonical Server: Pending requested
Diff: 260 lines (+222/-1)
5 files modified
debian/changelog (+10/-0)
debian/control (+2/-1)
debian/patches/0002-renewal-disregard-acme-v01-in-renewal-configs.patch (+82/-0)
debian/patches/0003-remove-failing-test.patch (+126/-0)
debian/patches/series (+2/-0)
Robie Basak (racb)
Changed in python-certbot (Ubuntu):
status: New → In Progress
assignee: nobody → Robie Basak (racb)
status: In Progress → Invalid
assignee: Robie Basak (racb) → nobody
Changed in python-certbot (Ubuntu Focal):
status: New → In Progress
assignee: nobody → Robie Basak (racb)
description: updated
Christian Ehrhardt  (paelzer)
Changed in python-certbot (Ubuntu Focal):
assignee: Robie Basak (racb) → Christian Ehrhardt  (paelzer)
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Andreas, or anyone else affected,

Accepted python-certbot into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-certbot/0.40.0-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in python-certbot (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

https://launchpad.net/ubuntu/+source/python-certbot/0.40.0-1ubuntu0.1 built fine in proposed.
Since this part of the upload was just the FTBFS this is hereby "validated" to work.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-certbot - 0.40.0-1ubuntu0.1

---------------
python-certbot (0.40.0-1ubuntu0.1) focal; urgency=medium

  * Interpret the Let's Encrypt ACMEv1 endpoint in renewal configs as Let's
    Encrypt's ACMEv2 endpoint instead, as the former is deprecated and will
    stop being functional soon (LP: #1893274).
  * Remove failing test since TLSSNI01 objects are no longer exported by
    python3-acme (LP: #1876933).

 -- Robie Basak <email address hidden> Mon, 26 Oct 2020 14:42:45 +0000

Changed in python-certbot (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for python-certbot has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.