Ubuntu
liquidsoap package

Wrong liquidsoap installation, libs are missed

Bug #1875414 reported by HF on 2020-04-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	liquidsoap (Ubuntu)	Fix Released	Undecided	Unassigned
	Focal	Fix Released	Undecided	Graham Inggs

Bug Description

[Impact]

The package ships the pervasive libraries /usr/share/liquidsoap/libs, while liquidsoap searches for them in /usr/share/liquidsoap/1.4.1/libs. These libraries are used to implement much of the built-in modules used within liquidsoap scripts. The fix here would fix scripts using these pervasive libraries. The fix has been working in Debian unstable and testing without issue.

[Test Plan]

Here is a short script to replicate it:
  #!/usr/bin/liquidsoap --check
  stream = playlist("")
  source = output.icecast(%mp3, host="localhost", port=8000, mount="listen.m3u", password="hackme")
  mksafe(source(mksafe(stream)))

Then ran the check against the liq file:
liquidsoap --check ./radio.liq

This should terminate successfully. If the libs are not in the correct position, this command will error out.

[Where problems could occur]

This patch creates a symlink, which could cause issues if the user has used the workaround described below. Liquidsoap searches for the libs in a subdirectory of /usr/share/liquidsoap that corresponds with the version of the package, so for Ubuntu 20.04, this should be 1.4.1. An incorrect symlink would result in no-change of the status-quo

-------------------------------
Original Bug report
-------------------------------

Could not use several script commands in liquidsoap, because liquidsoap could not find several .liq - files.

Following

sudo mkdir /usr/share/liquidsoap/1.4.1
sudo ln -s /usr/share/liquidsoap/libs /usr/share/liquidsoap/1.4.1/

fixed it, like described here: https://github.com/radiorabe/centos-rpm-liquidsoap/issues/3

See original description

Tags:

William Grant (wgrant) on 2020-04-28

no longer affects:

launchpad

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-05-22:

This bug was fixed in the package liquidsoap - 1.4.2-1

---------------
liquidsoap (1.4.2-1) unstable; urgency=low

  * Link pervasive libraries into expected directory
    (Closes: #956564, LP: #1875414)
  * New upstream version 1.4.2

-- Kyle Robbertze <email address hidden> Fri, 22 May 2020 12:12:19 +0200

Changed in liquidsoap (Ubuntu):
status:	New → Fix Released

Kyle Robbertze (krobbertze) on 2021-08-15

description:	updated
description:	updated

Kyle Robbertze (krobbertze) on 2021-08-15

description:

updated

Graham Inggs (ginggs) on 2021-08-17

Changed in liquidsoap (Ubuntu):
assignee:	nobody → Graham Inggs (ginggs)
assignee:	Graham Inggs (ginggs) → nobody
Changed in liquidsoap (Ubuntu Focal):
assignee:	nobody → Graham Inggs (ginggs)

Revision history for this message

Kyle Robbertze (krobbertze) wrote on 2021-08-17:

debdiff.patch Edit (921 bytes, text/plain)

Debdiff against 1.4.1-1build1

Revision history for this message

Chris Halse Rogers (raof) wrote on 2021-08-18: Please test proposed package

Hello HF, or anyone else affected,

Accepted liquidsoap into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/liquidsoap/1.4.1-1ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in liquidsoap (Ubuntu Focal):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-focal

Revision history for this message

Kyle Robbertze (krobbertze) wrote on 2021-09-03:

I've tested version 1.4.1-1ubuntu0.20.04.1 from focal-proposed with the test described in the bug report. It works as expected, correctly making a symlink and allowing the pervasive libraries to be found

tags:

added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-09-07:

This bug was fixed in the package liquidsoap - 1.4.1-1ubuntu0.20.04.1

---------------
liquidsoap (1.4.1-1ubuntu0.20.04.1) focal; urgency=medium

* Link pervasive libraries to the correct location expected by liquidsoap
(LP: #1875414)

-- Kyle Robbertze <email address hidden> Sun, 15 Aug 2021 21:46:44 +0200

Changed in liquidsoap (Ubuntu Focal):
status:	Fix Committed → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-09-07: Update Released

The verification of the Stable Release Update for liquidsoap has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.