[focal] pacemaker v2.0.3 last upstream fixes

Bug #1870235 reported by Rafael David Tinoco
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pacemaker (Ubuntu)
Fix Released
High
Rafael David Tinoco

Bug Description

[Impact]

* Idea here is latest release stabilization with backports of fixes released after the current version.

* Since this is a LTS, it is worth applying "straightforward" fixes before the final release.

[Test Case]

* https://discourse.ubuntu.com/t/ubuntu-high-availability-corosync-pacemaker-shared-disk-environments/

[Regression Potential]

Areas of potential regression: stonith, pengine, crmservice:

* stonith: I have regression tests and they look good.

* pengine: could not identify bad decisions when fencing resources but haven't explored in detail as there are many possible combinations and decisions that pengine can take -> changes are very minimal here.

* crmservice: pacemaker tests don't show regressions, resource agents start/stop/probe/migrate correctly afaik so the fix looks good.

[Other Info]

* This bug backport/cherrypick fixes released after 2.0.3 release.

* The correct patches are going to be defined within this bug comments.

Related branches

Changed in pacemaker (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Rafael David Tinoco (rafaeldtinoco)
description: updated
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Cherry-picks that seem to make sense after 2.0.3 release are:

Fix: tools: Fix definition of curses_indented_printf.
Fix: iso8601: Fix crm_time_parse_offset() to parse offset with plus sign.
Log: libcrmcommon: correctly raise detail log line length
Low: libcrmservice: handle child wait errors appropriately
Log: libcrmservice: improve messages when waiting for child process
Refactor: libcrmservice: isolate SIGCHLD handling
Fix: libstonithd, tools: Fix arguments to stonith-event.
Fix: libpengine: Options should be unsigned int, not long.
Fix: libstonithd: Some validate arguments should be non-const.
Fix: scheduler: make sure cluster-wide maintenance-mode=true overrides per-resource settings
Fix: tools: Correct the crm_mon man page.

There are too many fixes but mostly related to in-development refactorings so it's hard to distinguish if a fix is fixing something that exists already in v2.0.3.

I preferred to be conservative and pick the ones that made more sense - core parts - and were solved right after the release (and of course didn't introduce new features and major code refactoring).

A list of all commits after v2.0.3 can be seen at:

https://paste.ubuntu.com/p/pGzWc2qZpB/

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

There is an on-going merge request for this bug.

description: updated
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

PPA successfully built pacemaker fixes:

https://launchpad.net/~ubuntu-server-ha/+archive/ubuntu/staging

and the merge request has been +1.

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pacemaker - 2.0.3-3ubuntu3

---------------
pacemaker (2.0.3-3ubuntu3) focal; urgency=medium

  * Post 2.0.3 release fixes backported to Ubuntu (LP: #1870235)
    debian/patches/ubuntu-2.0.3-fixes/:
    - lp1870235-0a8e789f9-Fix-libpengine-Options-should-be-uint.patch
    - lp1870235-186042bcb-Ref-libcrmservice-SIGCHLD-handling.patch
    - lp1870235-28bfd00e9-Low-libcrmservice-handle-child-wait-errors.patch
    - lp1870235-426f06cc0-Fix-tools-Fix-curses_indented_printf.patch
    - lp1870235-4f5207a28-Fix-tools-Correct-crm_mon-man-page.patch
    - lp1870235-5afe84e45-Fix-libstonithd-validate-arg-non-const.patch
    - lp1870235-c98987824-Fix-iso8601-Fix-crm_time_parse_offset.patch
    - lp1870235-dec326391-Log-libcrmcommon-correct-log-line-length.patch
    - lp1870235-e35908c79-Log-libcrmservice-impr-msgs-wait-child.patch
    - lp1870235-eaaa20949-Fix-libstonithd-tools-Fix-arg-stonith-event.patch
    - lp1870235-f0fe45806-Fix-scheduler-cluster-maint-mode-true.patch

 -- Rafael David Tinoco <email address hidden> Mon, 06 Apr 2020 10:48:48 -0300

Changed in pacemaker (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.