Ubuntu
livecd-rootfs package

SRU: Use a snap cohort key for consistent parallel builds in Xenial

Bug #1866159 reported by Robert C Jennings
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
High
Brian Murray

Bug Description

[Impact]

We have snap cohort key support in bionic and later since bug #1864252. Adding cohort support in Xenial gives us the ability to create images in parallel LP builds with consistent results across all suites.

[Test Case]

* Build an image which contains snaps with and without a cohort key specified and inspect the image to ensure that the expected snaps are preseeded.

* Ensure that the snaps in the image are not attached to the cohort key once installed on first boot with 'snap info --verbose $snap_name'

[Regression Potential]

 * For images built without a cohort key specified we could fail the snap download command, and the build, if this were not tested (it has been)

[Other Info]

 * none

Related branches

~rcj/livecd-rootfs/+git/livecd-rootfs:feature/snap_cohort_key-xenial
Robert C Jennings (community): Abstain
Brian Murray: Needs Fixing
Philip Roche (community): Approve
Diff: 26 lines (+7/-0)
2 files modified
debian/changelog (+6/-0)
live-build/functions (+1/-0)
Brian Murray (brian-murray)
Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
Changed in livecd-rootfs (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → High
Brian Murray (brian-murray)
Changed in livecd-rootfs (Ubuntu Xenial):
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.408.58 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Robert C Jennings (rcj) wrote :

This has been verified using 2.408.58 in xenial-proposed.

I have built the qcow2 image target of the ubuntu-cpc project with and without a cohort key.

I added the following to the qcow2 binary hook:
 . /build/config/binary
 mkdir qcowmp
 mount_disk_image binary/boot/disk-uefi.ext4 qcowmp
 snap_preseed qcowmp/ lxd
 umount_disk_image qcowmp
 rmdir qcowmp

Booting the resulting livecd.ubuntu-cpc.uefi1.img which came out of the builds with/without the snap cohort key shows that both boot and 'systemctl is-system-running' gets to 'running' (no failed units). The output of 'snap list' shows lxd and core as expected and 'snap info --verbose' run against each of the snaps in either image confirms that the cohort key did not persist into the resulting image as expected.

Based on this testing I will mark the bug as verification-done.

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.408.58

---------------
livecd-rootfs (2.408.58) xenial; urgency=medium

  * Use a snap cohort key for consistent parallel builds (LP: #1866159)

 -- Robert C Jennings <email address hidden> Fri, 21 Feb 2020 21:32:37 -0600

Changed in livecd-rootfs (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.