gnome-keyring-daemon upgrades cause error 9 searching the keyring

Bug #185880 reported by Robert Collins
18
Affects Status Importance Assigned to Milestone
Gnome-GPG
Fix Released
Undecided
Unassigned
gnome-gpg (Ubuntu)
Fix Released
Low
Robert Collins

Bug Description

The recent g-k-d change to report GNOME_KEYRING_RESULT_NO_MATCH causes gnome-gpg to break.

Revision history for this message
Robert Collins (lifeless) wrote :
Revision history for this message
Robert Collins (lifeless) wrote :

Fix uploaded, waiting on queue

Changed in gnome-gpg:
status: New → Confirmed
assignee: nobody → lifeless
importance: Undecided → Low
status: New → Confirmed
Changed in gnome-gpg:
status: Confirmed → Fix Released
Revision history for this message
James Henstridge (jamesh) wrote :

Hi Robert,

I've applied a version of your fix to the development version of gnome-gpg (bzr branch lp:gnome-gpg). I've added an autoconf check for the new NO_MATCH enumeration value, and made your change conditional on it. It compiles okay on my gutsy box (which lacks NO_MATCH). Could you check if things work okay on your end?

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 185880] Re: gnome-keyring-daemon upgrades cause error 9 searching the keyring

On Sun, 2008-02-17 at 09:56 +0000, James Henstridge wrote:
> Hi Robert,
>
> I've applied a version of your fix to the development version of gnome-
> gpg (bzr branch lp:gnome-gpg). I've added an autoconf check for the new
> NO_MATCH enumeration value, and made your change conditional on it. It
> compiles okay on my gutsy box (which lacks NO_MATCH). Could you check
> if things work okay on your end?

checking for GNOMEGPG... yes
checking for GNOME_KEYRING_RESULT_NO_MATCH... no
checking for glib-genmarshal... /usr/bin/glib-genmarshal

Hmmm, let me check my CFLAGS :)

checking for GNOMEGPG... yes
checking for GNOME_KEYRING_RESULT_NO_MATCH... yes
checking for glib-genmarshal... /usr/bin/glib-genmarshal

So, test for GNOME_KEYRING_RESULT_NO_MATCH won't compile with "-g -O2
-Wall -Werror -fno-strict-aliasing".

Separately, I see
./configure: line 5125: syntax error near unexpected token `-Wall'
./configure: line 5125: `JH_ADD_CFLAG(-Wall)'

Later in the configure, but thats likely something missing on my system;
I'm not using the debian package code to test your fix.

Your .c file changes look trivially correct, so I think its all good
(unless you care about your tests working with -Werror :) (I do)).

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
>

Revision history for this message
James Henstridge (jamesh) wrote :

Fix released in gnome-gpg-0.6.0

Changed in gnome-gpg:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.