Gnome-GPG

  1. Bug #185880
  2. Comment #4

Comment 4 for bug 185880

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 185880] Re: gnome-keyring-daemon upgrades cause error 9 searching the keyring

On Sun, 2008-02-17 at 09:56 +0000, James Henstridge wrote:
> Hi Robert,
>
> I've applied a version of your fix to the development version of gnome-
> gpg (bzr branch lp:gnome-gpg). I've added an autoconf check for the new
> NO_MATCH enumeration value, and made your change conditional on it. It
> compiles okay on my gutsy box (which lacks NO_MATCH). Could you check
> if things work okay on your end?

checking for GNOMEGPG... yes
checking for GNOME_KEYRING_RESULT_NO_MATCH... no
checking for glib-genmarshal... /usr/bin/glib-genmarshal

Hmmm, let me check my CFLAGS :)

checking for GNOMEGPG... yes
checking for GNOME_KEYRING_RESULT_NO_MATCH... yes
checking for glib-genmarshal... /usr/bin/glib-genmarshal

So, test for GNOME_KEYRING_RESULT_NO_MATCH won't compile with "-g -O2
-Wall -Werror -fno-strict-aliasing".

Separately, I see
./configure: line 5125: syntax error near unexpected token `-Wall'
./configure: line 5125: `JH_ADD_CFLAG(-Wall)'

Later in the configure, but thats likely something missing on my system;
I'm not using the debian package code to test your fix.

Your .c file changes look trivially correct, so I think its all good
(unless you care about your tests working with -Werror :) (I do)).

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
>