Ubuntu
haproxy package

Won't build with py2, since python-marko is gone

Bug #1858485 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
haproxy (Debian)
Fix Released
Unknown
haproxy (Ubuntu)
Fix Released
High
Andreas Hasenack

Bug Description

haproxy runs debian/dconv/haproxy-dconv.py when building its documentation. That script is py2, and requires python2 and python-marko.

python-marko is gone and is an NBS currently. The src:marko package now only builds the python3 version, so we need to convert haproxy-dconv.py to py3.

haprox-dconv.py comes from https://github.com/cbonte/haproxy-dconv and already supports py3, so this boils down to updating the copy of haproxy-dconv in the debian package and updating the debian/patches/debianize-dconv.patch patch

Related branches

~ahasenack/ubuntu/+source/haproxy:focal-haproxy-py3
Bryce Harrington (community): Approve
Canonical Server packageset reviewers: Pending requested
Diff: 321 lines (+41/-30)
10 files modified
debian/changelog (+9/-0)
debian/control (+1/-1)
debian/dconv/haproxy-dconv.py (+15/-15)
debian/dconv/parser/arguments.py (+3/-3)
debian/dconv/parser/example.py (+1/-1)
debian/dconv/parser/keyword.py (+2/-2)
debian/dconv/parser/table.py (+5/-5)
debian/dconv/templates/parser/table/row.tpl (+1/-1)
debian/patches/debianize-dconv.patch (+3/-1)
debian/rules (+1/-1)
~ahasenack/ubuntu/+source/haproxy:focal-haproxy-py2-explicit
Andreas Hasenack: Disapprove
Canonical Server packageset reviewers: Pending requested
Diff: 41 lines (+9/-2)
3 files modified
debian/changelog (+7/-0)
debian/control (+1/-1)
debian/rules (+1/-1)
Andreas Hasenack (ahasenack)
tags: added: update-excuse
Bug Watch Updater (bug-watch-updater)
Changed in haproxy (Debian):
status: Unknown → New
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

python-marko (py2) was reinstated, using it.

Changed in haproxy (Ubuntu):
status: New → In Progress
assignee: nobody → Andreas Hasenack (ahasenack)
importance: Undecided → High
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Oops, back pedalling on this:
<ahasenack> doko: I'm taking advantage of you reintroducing python-mako (py2), to build haproxy with it (not a runtime dep). Is that why you reintroduced it, or are other packages needing it?
<doko> ahasenack, ginggs: I just removed python2-scipy, so it's not needed for that anymore

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package haproxy - 2.0.12-1ubuntu2

---------------
haproxy (2.0.12-1ubuntu2) focal; urgency=medium

  * Use python3 to build the documentation (LP: #1858485, Closes: #948296):
    - d/control, d/rules: switch to python3
    - d/dconv/*: convert to python3
    - d/p/debianize-dconv.patch: small update for python3

 -- Andreas Hasenack <email address hidden> Fri, 17 Jan 2020 18:54:13 +0000

Changed in haproxy (Ubuntu):
status: In Progress → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in haproxy (Debian):
status: New → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in haproxy (Debian):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.