[SRU]Not able to adjust Audio input UI volume after connecting headset

1. Still can reproduce this issue in 18.04.3
2. can not reproduce this issue in 19.04 and 19.10

Thank you for your bug report. Closing since it works in newer Ubuntu series, we can add a Bionic target if a SRU is needed. It would require to first identify the buggy component/patch to backport.
Can you change the settings using pavucontrol or does that has the same problem?

pavucontrol works good, I will try to backport this package to bionic, thanks.

What package? Bionic does include pavucontrol already no?

If the pulseaudio tools works fine so it might be a gnome-control-center issue

@Sebastien

Yes, What I meant was gnome-control-center

@Sebastien,

please take a look of this patch

Thank for the patch, is that backport from some upstream work/what they did in newer version? Could you give some more explanations about what the patch is doing and why?

@Sebastien,

No, it's not from upstream, due to the code is quite different from upstream.

If there is only one input device with only one input port, and this input port is active_port, e.g. there is no internal mic, just a mic jack on the machine, this issue will happen.

For this kind of machines, if users plug mic in the jack, the function active_input_update() is called ahead of the function add_input_ui_entry(), then we will see "No devices in the tree, so cannot set the active output" from syslog, this issue will be reproduced.

On other machines, the add_input_ui_entry() is called ahead of active_input_update(), then there is no problem.

So for this patch, just checking if there is only one input item in the treeview, call active_input_update(). And call gtk_widget_set_sensitive() to gray out the input volume bar if there isn't any input item in the treeview.

Ccing Robert who is one of the gnome-control-center maintainer. Robert, could you look if the patch makes sense to you?

@hugh - can you do this as a merge request on https://gitlab.gnome.org/GNOME/gnome-control-center ? It will be much easier to review there.

First thing to note, this can be simplified:

if (gtk_tree_model_iter_n_children (model, NULL) == 1)
          active_input_update (dialog, input);

I'd also change the second part of the patch to be clearer, i.e.

if (gtk_tree_model_iter_n_children (model, NULL) == 0)
                gtk_widget_set_sensitive (dialog->input_bar, FALSE);

The first part of the patch is a workaround for a bug elsewhere which is reporting things in the wrong order. The second part is a fix for a case that wasn't being handled correctly. So both seem correct to me.

If you make a merge request upstream, please make these changes as two separate commits.

@Robert,

Is this the right branch?
https://gitlab.gnome.org/GNOME/gnome-control-center/tree/gnome-3-28/panels/sound

Yes, that is the correct branch.

https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/641

@Robert,

Is there any chance you can review this mp in #15? many thanks

The regression potential field does not provide enough information. I will accept it into -proposed, but could you please include some regression potential analysis in the description before we start looking into releasing it to updates? Thank you!

Hello hugh, or anyone else affected,

Accepted gnome-control-center into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.28.2-0ubuntu0.18.04.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tried gnome-control-center 1:3.28.2-0ubuntu0.18.04.6 in a built-in speaker/microphone laptop[0], still works well, didn't find any Regression potential.

[0] https://support.hp.com/ro-en/document/c05994943

tried gnome-control-center 1:3.28.2-0ubuntu0.18.04.6 in a hp desktop mini machine[0], can fix this issue

[0] http://h20195.www2.hp.com/v2/GetDocument.aspx?docname=c06339658

tried gnome-control-center 1:3.28.2-0ubuntu0.18.04.6 in a hp Small Form Factor PC[0], can fix this issue

[0] https://www8.hp.com/us/en/desktops/product-details/21353680

tried gnome-control-center 1:3.28.2-0ubuntu0.18.04.6 in a LG Thin Client[0], can fix this issue

[0] https://www.lg.com/global/business/monitor/monitor-products/lg-CK500W

This bug was fixed in the package gnome-control-center - 1:3.28.2-0ubuntu0.18.04.6

---------------
gnome-control-center (1:3.28.2-0ubuntu0.18.04.6) bionic; urgency=medium

  [ hugh chao ]
  * debian/patches/git_audio_input.patch:
    - fix audio input controls not being selectable (lp: #1853584)

 -- Sebastien Bacher <email address hidden> Mon, 13 Jan 2020 11:16:31 +0100

The verification of the Stable Release Update for gnome-control-center has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.