[SRU] Backport 2.62.4-1

Bug #1850932 reported by Iain Lane
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glib2.0 (Ubuntu)
Fix Released
Undecided
Unassigned
Eoan
Fix Released
Undecided
Iain Lane

Bug Description

[ Description ]

I'm creating this bug report to have a place to describe the proposed backport of glib2.0 2.62.4-1 from focal.

One purpose of this backport is to fix bug #1844853.

But there are several other changes. Here's the diff of NEWS:

+Overview of changes in GLib 2.62.4
+==================================
+
+* Apply recursion depth limits to variants in D-Bus messages (!1290)
+
+* Bugs fixed:
+ - #1938 GDateTime doesn't support leap seconds
+ - !1240 Backport !1233 “gdatetime: Handle leap seconds in ISO8601 dates” +to glib-2-62
+ - !1257 Backport !1232 “kqueue: Do not return early from _kqsub_cancel” +to glib-2-62
+ - !1266 Backport !1265 “build: don't check for protected visibility” to +glib-2-62
+ - !1276 Backport !1274 “trash portal: Don't follow symlinks” to glib-2-62
+ - !1290 Backport !1201 “gdbusmessage: Limit recursion of variants in +D-Bus messages” to glib-2-62
+
+Overview of changes in GLib 2.62.3
+==================================
+
+* Use `poll()` in `g_spawn_sync()` rather than `select()`, which is subject to
+ FD limits (#954)
+
+* Fix undefined behaviour with `g_utf8_find_prev_char()` (#1917)
+
+* Bugs fixed:
+ - #954 The g_spawn_sync() function uses select() which has limitations
+ - #1318 rare failure in gdbus-peer test: invalid uninstantiatable type '(null)' in cast to 'GDBusServer'
+ - #1897 glib 2.62.0 fails test 'test_writev_no_vectors' wih gcc7
+ - #1903 use-after-free in mimeapps test causes intermittent segfault during testing
+ - #1916 objcopy not used from cross-compilation file in GIO tests
+ - #1917 Test utf8-pointer fails with static build, LTO, optimisations, and new GCC
+ - !1174 Backport !1164 “use-after-free fix in mimeapps test” to glib-2-62
+ - !1184 Backport !1173 “gvariant: Limit recursion in g_variant_parse()” to glib-2-62
+ - !1194 Backport !1176, !1183, !1188, !1191 to `glib-2-62`
+ - !1203 Backport !1192, !1193, !1197 Fixes for gdbus-peer tests to glib-2-62
+ - !1207 Backport !1206 “goption: Relax assertion to avoid being broken by kdeinit5” to glib-2-62
+ - !1215 [2.62] gdbus-peer: Specifically listen on 127.0.0.1
+ - !1219 Backport !1218 “gdb: Fix GHashTable pretty printer off-by-one error”
+ - !1222 Backport !1221 “Add NOTE_REVOKE to the list of the monitoring events” to glib-2-62
+ - !1228 Backport !1199 “gunicode: Fix UB in gutf8.c and utf8-pointer test” to glib-2-62
+
+
+Overview of changes in GLib 2.62.2
+==================================
+
+* Bugs fixed:
+ - #1896 Use after free when calling g_dbus_connection_flush_sync() in a dedicated thread
+ - !1154 Backport !1152 “gwinhttpvfs: Handle g_get_prgname() returning NULL” to glib-2-62
+ - !1156 Backport !1146 Solaris fixes to glib-2-62

This release can be considered to be tested under https://wiki.ubuntu.com/StableReleaseUpdates/GNOME

There are patches from the upstream master branch rather than this stable release:

+ Add-a-test-for-GDBusServer-authentication.patch
+ gdbus-server-auth-test-Create-temporary-directory-for-Uni.patch
+ gdbus-server-auth-test-Include-gcredentialsprivate.h.patch
+ Make-ld-executable-configurable.patch

They are sensible backports which I hope are appropriate for SRU.

[ QA ]

The testsuite fixes will verify themselves during the build and autopkgtest.

For the rest of the fixes, please exercise the desktop thoroughly. Log in, log out, run many applications and make sure there are no regressions.

[ Regression potential ]

test fixes> Build failures or autopkgtest failures.

GLib is a central desktop library. Regressions could break any part of the desktop - so QA is important, the SRU exception notwithstanding.

Iain Lane (laney)
Changed in glib2.0 (Ubuntu):
status: New → Fix Released
Changed in glib2.0 (Ubuntu Eoan):
status: New → Triaged
status: Triaged → In Progress
assignee: nobody → Iain Lane (laney)
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Iain, or anyone else affected,

Accepted glib2.0 into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glib2.0/2.62.2-2~ubuntu19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in glib2.0 (Ubuntu Eoan):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-eoan
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote : Re: [SRU] Backport 2.62.2-2

Bug #1844853 was explicitly verified (comment #15). Didn't observe any unexpected behavior due to the glib2.0 upgrade.

tags: added: verification-done verification-done-eoan
removed: verification-needed verification-needed-eoan
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glib2.0/2.62.2-2~ubuntu19.10.1)

All autopkgtests for the newly accepted glib2.0 (2.62.2-2~ubuntu19.10.1) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

indicator-session/17.3.20+19.10.20190921-0ubuntu1 (arm64)
sbd/1.4.0-18-g5e3283c-1ubuntu1 (i386)
cairo/unknown (armhf)
netplan.io/0.98-0ubuntu1 (ppc64el)
apport/2.20.11-0ubuntu8.2 (amd64)
snapd-glib/unknown (armhf)
firefox/70.0.1+build1-0ubuntu0.19.10.1 (armhf)
bumblebee/unknown (armhf)
glib2.0/2.62.2-2~ubuntu19.10.1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#glib2.0

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Iain Lane (laney)
summary: - [SRU] Backport 2.62.2-2
+ [SRU] Backport 2.62.3-2
Revision history for this message
Iain Lane (laney) wrote : Re: [SRU] Backport 2.62.3-2

glib2.0/i386 was pretty consistently failing for me. It looks like the new version in unstable is better (https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-laney-ppa/eoan/i386/g/glib2.0/20191216_173854_41ef9@/log.gz), so I'm uploading that as a new backport to replace the SRU currently in eoan-proposed.

description: updated
tags: removed: verification-done verification-done-eoan
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Iain, or anyone else affected,

Accepted glib2.0 into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glib2.0/2.62.3-2~ubuntu19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-eoan
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glib2.0/2.62.3-2~ubuntu19.10.1)

All autopkgtests for the newly accepted glib2.0 (2.62.3-2~ubuntu19.10.1) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

automake-1.16/1:1.16.1-4ubuntu3 (s390x)
libreoffice/1:6.3.4-0ubuntu0.19.10.1 (ppc64el)
umockdev/0.13.2-1 (armhf, i386)
asterisk/1:16.2.1~dfsg-2build2 (arm64)
tracker/2.3.0-1 (armhf)
glib2.0/2.62.3-2~ubuntu19.10.1 (i386)
cmake-extras/1.3+17.04.20170310-5 (armhf)
netplan.io/0.98-0ubuntu1 (ppc64el, i386)
dbus-test-runner/15.04.0+19.04.20190115-0ubuntu1 (armhf, i386)
sbd/1.4.0-18-g5e3283c-1ubuntu1 (amd64, i386)
ocaml-cairo2/unknown (armhf)
netplan.io/unknown (armhf)
gvfs/1.42.1-1ubuntu1 (arm64)
openssh/1:8.0p1-6build1 (amd64, armhf, arm64, s390x, i386, ppc64el)
snapd-glib/1.49-0ubuntu1.19.10.0 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#glib2.0

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Iain Lane (laney) wrote : Re: [SRU] Backport 2.62.3-2

It looks like the glib2.0/i386 regressions are actually real. I tried locally and reproduced them. I then tried 2.62.4 and the tests pass there. So I think I'll rev this SRU.

description: updated
Changed in glib2.0 (Ubuntu Eoan):
status: Fix Committed → In Progress
Revision history for this message
Iain Lane (laney) wrote :

New backport uploaded to the queue

summary: - [SRU] Backport 2.62.3-2
+ [SRU] Backport 2.62.4-1
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Iain, or anyone else affected,

Accepted glib2.0 into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glib2.0/2.62.4-1~ubuntu19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in glib2.0 (Ubuntu Eoan):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glib2.0/2.62.3-2~ubuntu19.10.1)

All autopkgtests for the newly accepted glib2.0 (2.62.3-2~ubuntu19.10.1) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

tracker/2.3.0-1 (armhf)
snapd-glib/1.49-0ubuntu1.19.10.0 (armhf)
sbd/1.4.0-18-g5e3283c-1ubuntu1 (amd64)
gvfs/1.42.1-1ubuntu1 (arm64)
glib2.0/2.62.3-2~ubuntu19.10.1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#glib2.0

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glib2.0/2.62.4-1~ubuntu19.10.1)

All autopkgtests for the newly accepted glib2.0 (2.62.4-1~ubuntu19.10.1) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

openssh/1:8.0p1-6build1 (i386, ppc64el, amd64, arm64, s390x, armhf)
openjdk-8/unknown (amd64, armhf)
libreoffice/unknown (i386)
dbus-python/unknown (armhf)
modemmanager-qt/unknown (amd64)
graphene/1.10.0-1 (arm64)
firefox/73.0+build3-0ubuntu0.19.10.1 (arm64)
gvfs/1.42.1-1ubuntu1 (arm64)
cmake-extras/1.3+17.04.20170310-5 (armhf)
glib2.0/2.62.4-1~ubuntu19.10.1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#glib2.0

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Iain Lane (laney) wrote :

I ran glib2.0/eoan/i386 myself locally, and it passed:

autopkgtest [14:37:57]: @@@@@@@@@@@@@@@@@@@@ summary
build PASS (superficial)
build-static PASS (superficial)
installed-tests PASS
flaky PASS
qemu-system-x86_64: terminating on signal 15 from pid 2692138 (/usr/bin/python3)

I'm not sure what happens on the production infrastructure, but given that this works in focal and that eoan is "only" an interim release, I'd say this SRU could probably be released ...

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Bug #1844853 was explicitly verified (again, comment #31 this time). Didn't observe any unexpected behavior due to the glib2.0 upgrade.

tags: added: verification-done verification-done-eoan
removed: verification-needed verification-needed-eoan
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.8 KiB)

This bug was fixed in the package glib2.0 - 2.62.4-1~ubuntu19.10.1

---------------
glib2.0 (2.62.4-1~ubuntu19.10.1) eoan; urgency=medium

  * No-change backport from unstable to eoan (LP: #1850932).
    + Contains fix for LP: #1844853 - "IBus no longer works in Qt applications
      after upgrade"

glib2.0 (2.62.4-1) unstable; urgency=medium

  * Team upload

  [ Steve Langasek ]
  * debian/tests/build: Make cross-test friendly (Closes: #946355)

  [ Iain Lane ]
  * debian/tests/build: Style fixes

  [ Simon McVittie ]
  * New upstream release

glib2.0 (2.62.3-2) unstable; urgency=medium

  * Team upload
  * Rename pkg.glib2.0.noinsttest build profile to noinsttest.
    This is now registered on <https://wiki.debian.org/BuildProfileSpec>.

glib2.0 (2.62.3-1) unstable; urgency=medium

  * Team upload
  * New upstream release
    - Drop patches that were applied upstream
  * Don't build libglib2.0-tests under pkg.glib2.0.noinsttest build profile.
    This is a prototype of the proposed standard build profile noinsttest.
    If the build profiles include both nocheck and pkg.glib2.0.noinsttest,
    we can drop the libdbus-1-dev build-dependency without harming test
    coverage or altering the contents of binary packages.
  * d/gbp.conf: Use upstream/2.62.x branch

glib2.0 (2.62.2-3) unstable; urgency=medium

  * Team upload

  [ Iain Lane ]
  * control: Drop `debian/experimental` from Vcs-*

  [ Simon McVittie ]
  * Build-depend on libdbus-1-dev for better test coverage
  * Update to upstream commit 2.62.2-28-g3cf25070e:
    - d/p/goption-Relax-assertion-to-avoid-being-broken-by-kdeinit5.patch:
      Fix assertion failure when called from a process that overwrites its
      argv, such as kdeinit5
    - d/p/gdbus-peer-Specifically-listen-on-127.0.0.1.patch:
      Improve reliability of gdbus-peer test in some container environments
    - d/p/gdbusserver-Delete-socket-and-nonce-file-when-stopping-se.patch,
      d/p/gdbusserver-Keep-a-strong-reference-to-the-server-in-call.patch,
      d/p/gdbusauthmechanismsha1-Remove-unnecessary-g_warning-calls.patch,
      d/p/gdbusauthmechanismsha1-Create-.dbus-keyrings-directory-re.patch,
      d/p/tests-Move-main-loop-and-test-GUID-into-test-functions-in.patch,
      d/p/tests-Isolate-directories-in-gdbus-peer-test.patch,
      d/p/gdbus-peer-test-Improve-diagnostics-if-g_rmdir-fails.patch,
      d/p/gdbus-peer-test-Stop-GDBusServer-before-tearing-down-temp.patch,
      d/p/gdbus-peer-test-Use-unix-dir-address-if-exact-format-does.patch,
      d/p/gdbus-server-auth-test-Create-temporary-directory-for-Uni.patch:
      Mark as applied upstream in 2.62.x branch
  * d/p/gdbus-server-auth-test-Include-gcredentialsprivate.h.patch:
    Apply patch from 2.63.x to fix missing coverage in test for #941018
  * d/p/Make-ld-executable-configurable.patch:
    Apply patch from 2.63.x to use cross ld where necessary
  * d/p/gdbus-server-auth-test-Create-temporary-directory-for-Uni.patch:
    Mark as applied upstream in 2.63.x branch
  * Improve patch metadata: use more URLs for bug references

glib2.0 (2.62.2-2) unstable; urgency=medium

  * Team upload
  * Update to upstream commit 2.62.2-14-gfcbb88823:
    - d/p/gdeskto...

Read more...

Changed in glib2.0 (Ubuntu Eoan):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for glib2.0 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.