memory leaks in open-vm-tools

Thanks for this. Will there be a new 10.3.x release with these fixes?

Are these the 3 fixes that should be applied?

26b9edbe (HEAD -> stable-10.3.10-vix-memory-leaks, origin/stable-10.3.10-vix-memory-leaks) Fix leaks in ListAliases and ListMappedAliases (9bc72f0b09702754b429115658a85223cb3058bd from devel)
7b874f37 End VGAuth impersonation in the case of error.
015db4c0 Fix memory leaks in 'vix' tools plugin.

Currently we do not have any plans to release any new version of open-vm-tools from the 10.3.x branch.

The list of commits to be applied is correct.

The first two changes (015db4c0 and 7b874f37) are part of 11.0. The last one (26b9edbe) is in the devel branch, and will be part of any upcoming 11.0.x and greater releases.

Thanks Oliver for the ping.

Going further in 20.04 we will merge 11.0 rather soon.
But for the 10.3.10 series that means we will add some delta now.

I have prepared that for Eoan in [1].

Once it is complete there we will prep SRUs, but for that you could already help providing some config/use-case/test that we could use to show the mem-leaking behavior?

[1]: https://code.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/373871

Heads up: Due to Eoan being in the last stages of its release the upload of this might take a while to appear user-visible.

Reviewed and Uploaded to Eoan, waiting in the queue there due to the release freeze.

@Release Team, since this fixes a leak (generally bad) and people can forever access the initial Eoan isos&images I'd think that upload should go into to Release asap to be part of those iso builds.

This bug was fixed in the package open-vm-tools - 2:10.3.10-3ubuntu1

---------------
open-vm-tools (2:10.3.10-3ubuntu1) eoan; urgency=medium

  * Fix memory leaks in vix plugin (LP: #1847157)
    - d/p/lp-1847157-End-VGAuth-impersonation-in-the-case-of-error.patch
    - d/p/lp-1847157-Fix-leaks-in-ListAliases-and-ListMappedAliases-9bc72.patch
    - d/p/lp-1847157-Fix-memory-leaks-in-vix-tools-plugin.patch

 -- Christian Ehrhardt <email address hidden> Wed, 09 Oct 2019 14:06:46 +0200

I prepared MPs for the changes to Disco and Bionic.

@Oliver - two questions to you:

1. soon when the 20.04 cycle starts I expect 11.0 to be pushed everywhere. Is this fix already in the most recent release https://github.com/vmware/open-vm-tools/releases/tag/stable-11.0.0 ?

2. could you either outline how one could exercise and test these leaks or confirm/commit that you could do so when these SRUs are accepted and need verification?

I'm still waiting on the reporter to help making the test steps "better", but at the same time think we can already upload this to the SRU Teams review which I have now done.

ping @ SRU Team?

and ping @ Oliver - outlining a better test and/or confirming that you will do it might help here.

Hello Oliver, or anyone else affected,

Accepted open-vm-tools into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/open-vm-tools/2:10.3.10-1ubuntu0.19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Oliver, or anyone else affected,

Accepted open-vm-tools into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/open-vm-tools/2:10.3.10-1~ubuntu0.18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I'm a bit worried that the reporter from upstream seems no longer active in this bug. Looking at the changes, those seem like good memory-leak fixes (especially from upstream) so I have accepted them into -proposed.

As for releasing those into -updates, I'd prefer if we got an actual verification from upstream here. Christian, could we make this the acceptance criteria then? Would you be able to chase down some proper verification?

Yes Lukasz I agree.
Oliver isn't inactive for sure he most likely just didn't track LP updates or on vacation or something like it.

I'll send him a direct mail and worst case we have a monthly call where I can ask.

Note (to myself): I have checked 11.0 myself, the changes are in

Note: to be overwritten by 11.0 MRE which is in -unapproved for quite a while already.
Do we need to tag/mark this somehow to make it clear that the 11.0 upload is supposed to go over this (I'd prefer to release just 11.0 and not this one as interim update)?

11.0 accepted to disco, you need to handle this bug manually.. maybe test the new version and mark this fixed

I have tested it in general, as outlined before there is no hard-test for the leaks known.
But since this is part of the general MRE to go to open-vm-tools v11 lets call it complete as the code matches what upstream applied to fix this issue.

Marking verified

What's the status of this? I don't see open-vm-tools in the SRU report (https://people.canonical.com/~ubuntu-archive/pending-sru.html), nor do I see this package in the bionic unapproved queue (https://launchpad.net/ubuntu/bionic/+queue?queue_state=1&queue_text=open-vm-tools), nor disco. And disco is EOL this month.

This got superseded by bug 1844834 which is Fix-Released for quite a while now.
Set state to Fix-Released here as well.