[ui, websocket-api] New data shape for node testing statuses
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Undecided
|
Lee Trager | ||
Bug Description
There's been an update to how the test statuses are surfaced on the summary page for each test type. Instead of a string, it's a traffic light with a number beside each:
https:/
The websocket api currently returns tooltips for each test type, which is a string that contains the number of each hardware type result e.g. "3 tests have passed, 1 has failed installing dependencies, 4 have failed."
For the new design to work without a ton of calculation on the front end we just need the number for each "combined" script status on that node, e.g:
test_status_
'failed': 3,
'pending': 2,
'success': 4
}
Or to keep it more flexible we could just have the number of all 12 script statuses and do the collating on the front end.
Related branches
- Blake Rouse (community): Approve
- Caleb Ellis (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 916 lines (+137/-387)14 files modifiedsrc/maasserver/static/js/angular/controllers/node_details.js (+1/-1)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+4/-2)
src/maasserver/static/js/angular/directives/machines_table.js (+3/-3)
src/maasserver/static/js/angular/directives/tests/test_machines_table.js (+6/-6)
src/maasserver/static/partials/cards/cpu.html (+3/-3)
src/maasserver/static/partials/cards/machine-overview.html (+45/-7)
src/maasserver/static/partials/cards/memory.html (+3/-3)
src/maasserver/static/partials/cards/storage.html (+2/-2)
src/maasserver/static/partials/machines-table.html (+7/-7)
src/maasserver/static/partials/node-details.html (+4/-4)
src/maasserver/static/partials/nodedetails/node-details-summary.html (+6/-6)
src/maasserver/websockets/handlers/machine.py (+11/-36)
src/maasserver/websockets/handlers/node.py (+26/-45)
src/maasserver/websockets/handlers/tests/test_machine.py (+16/-262)
| Caleb Ellis (caleb-ellis) wrote | #1 |
| Lee Trager (ltrager) wrote | #2 |
| Changed in maas: | |
| status: | New → Incomplete |
| Caleb Ellis (caleb-ellis) wrote | #3 |
| Changed in maas: | |
| status: | Incomplete → In Progress |
| assignee: | nobody → Lee Trager (ltrager) |
| Lee Trager (ltrager) wrote | #4 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
Can you clarify if you need just one test_status for all types or if it should be broken down by type? e.g should we have cpu_test_status, memory_test_status, storage_