FTBFS in Eoan due to gcc9 "Deprecated pre-processor symbol" on GStaticMutex
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
open-vm-tools (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Disco |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
GStaticMutex is deprecated (a long time) [1][2]
gcc-9 with Werror detectas and breaks on this as an error nowadays:
fileLogger.c: In function ‘FileLoggerLog’:
fileLogger.
351 | g_static_
| ^~~~~~~
sysLogger.c: In function ‘SysLoggerUnref’:
sysLogger.c:108:13: error: Deprecated pre-processor symbol [-Werror]
108 | g_static_
| ^~~~~~~
Upstream is close to v11, but the github content has nothing yet :-/.
This should be mostly a global search and replace with some extra thought on the places the locks are initialized.
[1]: https:/
[2]: https:/
Changed in open-vm-tools (Ubuntu): | |
status: | New → Triaged |
Old init had multiple ocurrances which were not static anyway.
Two places had ... = G_STATIC_MUTEX_INIT
Per [2] just declaring them static will do it with the new GMutex.