[SRU] klavaro crash

Bug #184112 reported by Jérôme Guelfucci
2
Affects Status Importance Assigned to Milestone
klavaro (Ubuntu)
Fix Released
Wishlist
Unassigned
Feisty
Fix Released
Medium
Luca Falavigna
Gutsy
Fix Released
Medium
Luca Falavigna
Hardy
Fix Released
Wishlist
Unassigned

Bug Description

I propose the following SRU to fix a crash in klavaro 1.0.3-1 in Gutsy Universe. The bug concerned is bug 176462 : it has been fixed in Hardy with klavaro 1.0.6-1 synced from Debian.

TEST CASE:
1. Set the language to French (fr_FR) if it is not already done.
2. Do (and finish) a fluidness exercise ("fluidité" in French).
3. Klavaro crash.

A patch has been provided upstream against 1.0.5 but it applies correctly with 1.0.3, I'll attach it here. I tested it fixes the bug and does not show any regression for me.

Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote :

To get your fix (or workaround) included in Ubuntu, try transforming it into debdiff (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submitting it for review (http://wiki.ubuntu.com/SponsorshipProcess).

Revision history for this message
Daniel Holbach (dholbach) wrote :

Setting status to 'incomplete' for now. Please set back to 'new' once you attached the debdiff and subscribed the sponsors team.

Changed in klavaro:
status: New → Incomplete
Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :
description: updated
Changed in klavaro:
status: Incomplete → New
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Since klavaro does not segfault on startup, I think this bug is not SRU-worthy, a backport could be a better solution.

Revision history for this message
Daniel Holbach (dholbach) wrote :
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

After a quick discussion on #ubuntu-motu with John and Jordan, I clarified some aspects and I realized this is a good SRU candidate. Sorry for the noise.

Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

Do you need something else ? Or the debdiff is enough ?

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Debdiff looks good, a more detailed changelog entry could be advisable, though.
You can subscribe ubuntu-universe-sponsors as usual.

Changed in klavaro:
status: New → Fix Released
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Patch looks good, but you should adjust Maintainer field as described in https://wiki.ubuntu.com/DebianMaintainerField and provide a more detailed description in your changelog entry. Thanks.

Changed in klavaro:
assignee: nobody → jerome-guelfucci
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

I'll attach the new debdiff in a second, setting this to triaged and unassigning me.

Changed in klavaro:
assignee: jerome-guelfucci → nobody
status: In Progress → Triaged
Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

I verified Feisty is affected too, mind preparing (and checking) a debdiff for feisty-proposed too? If you are unable to do it, I'll take care myself.

Changed in klavaro:
importance: Undecided → Medium
Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

I can provide and test the build of a Feisty version but I can't test if it works, I don't have any feisty box available.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

No problem for that, I can test it if you want.

Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

Ok, I'll try to do that by the end of the week.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Thanks, uploading to gutsy-proposed in the meantime.

Changed in klavaro:
assignee: nobody → dktrkranz
Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

Attaching the debdiff in the next comment, it builds but I could not test.

Changed in klavaro:
status: New → Triaged
Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :
Revision history for this message
Jonathan Riddell (jr) wrote :

Accepted into gutsy-proposed, please test.

Changed in klavaro:
status: Triaged → Fix Committed
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Version 1.0.1-1ubuntu1 uploaded to feisty-proposed.

Changed in klavaro:
assignee: nobody → dktrkranz
Revision history for this message
Jonathan Riddell (jr) wrote :

accepted into feisty-proposed, please test.

Changed in klavaro:
status: Triaged → Fix Committed
Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

I tested the package in gutsy-proposed, everything works fine for me, the crash is fixed and there is no secondary effect.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

GUTSY VERIFICATION

Using version 1.0.3-1:
$ klavaro
** Message: loading text file: test.paragraphs
Paragraphs:
0 - 1 - 2 - BLANK! - end.
Text file loaded!

** Message: writing further fluidness results at:
 /home/ldktrkranz/.klavaro/deviation_fluid.txt
*** stack smashing detected ***: klavaro terminated
Aborted (core dumped)
$

Using version 1.0.3-1ubuntu1 (from gutsy-proposed):

$ klavaro
** Message: loading text file: test.paragraphs
Paragraphs:
0 - 1 - 2 - BLANK! - end.
Text file loaded!

** Message: writing further fluidness results at:
 /home/ldktrkranz/.klavaro/deviation_fluid.txt
[Program does not crash, but show fluidness results]
$

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

FEISTY VERIFICATION

Using version 1.0.1-1:
$ klavaro
** Message: writing further fluidness results at:
 /home/ldktrkranz/.klavaro/deviation_fluid.txt
*** stack smashing detected ***: klavaro terminated
Aborted (core dumped)
$

Using version 1.0.1-1ubuntu1 (from feisty-proposed):
$ klavaro
** Message: writing further fluidness results at:
 /home/ldktrkranz/.klavaro/deviation_fluid.txt
[Program does not crash, but show fluidness results]
$

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to feisty/gutsy-updates.

Changed in klavaro:
status: Fix Committed → Fix Released
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.