Ubuntu
virt-manager package

gtksourceview4 dependency is missing in virt-manager eoan package

Bug #1840677 reported by RussianNeuroMancer
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
virt-manager (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Steps to recreate:
- start virt-manager
- in extra console tail on ~/.cache/virt-manager/virt-manager.log
- enable "Enable XML editing" in "Edit"->"preferences"
- Then try to create a guest (or edit one that you have)
=> You might wonder why no window is opening, but in the log you will see the reported traceback.

---

Attempt to open virtual machine in virt-manager installed on Kubuntu 19.10 cause following traceback:

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/manager.py", line 489, in row_activated
    self.show_vm(_src)
  File "/usr/share/virt-manager/virtManager/manager.py", line 474, in show_vm
    vmmenu.VMActionUI.show(self, self.current_vm())
  File "/usr/share/virt-manager/virtManager/vmmenu.py", line 329, in show
    from .vmwindow import vmmVMWindow
  File "/usr/share/virt-manager/virtManager/vmwindow.py", line 15, in <module>
    from .details.details import vmmDetails
  File "/usr/share/virt-manager/virtManager/details/details.py", line 18, in <module>
    from ..addhardware import vmmAddHardware
  File "/usr/share/virt-manager/virtManager/addhardware.py", line 23, in <module>
    from .device.fsdetails import vmmFSDetails
  File "/usr/share/virt-manager/virtManager/device/fsdetails.py", line 14, in <module>
    from ..storagebrowse import vmmStorageBrowser
  File "/usr/share/virt-manager/virtManager/storagebrowse.py", line 11, in <module>
    from .hoststorage import vmmHostStorage
  File "/usr/share/virt-manager/virtManager/hoststorage.py", line 17, in <module>
    from .createpool import vmmCreatePool
  File "/usr/share/virt-manager/virtManager/createpool.py", line 18, in <module>
    from .xmleditor import vmmXMLEditor
  File "/usr/share/virt-manager/virtManager/xmleditor.py", line 6, in <module>
    gi.require_version('GtkSource', '4')
  File "/usr/lib/python3/dist-packages/gi/__init__.py", line 129, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace GtkSource not available

Installing gir1.2-gtksource-4 libgtksourceview-4-0 libgtksourceview-4-common solved this.

See original description

Related branches

~paelzer/ubuntu/+source/virt-manager:eoan-merge-2.2.1
Andreas Hasenack: Approve
Canonical Server: Pending requested
git-ubuntu developers: Pending requested
Diff: 76938 lines (+14520/-14984)
138 files modified
INSTALL.md (+2/-1)
NEWS.md (+7/-0)
PKG-INFO (+1/-1)
debian/changelog (+7/-0)
debian/control (+1/-0)
dev/null (+0/-11)
man/virt-install.pod (+17/-7)
po/as.po (+306/-327)
po/bg.po (+296/-303)
po/bn_IN.po (+308/-329)
po/bs.po (+294/-299)
po/ca.po (+310/-337)
po/cmn.po (+294/-299)
po/cs.po (+310/-336)
po/da.po (+299/-299)
po/de.po (+309/-327)
po/en_GB.po (+306/-333)
po/es.po (+309/-336)
po/fi.po (+298/-310)
po/fr.po (+309/-336)
po/gu.po (+307/-318)
po/hi.po (+296/-306)
po/hr.po (+296/-303)
po/hu.po (+300/-307)
po/is.po (+294/-299)
po/it.po (+309/-326)
po/ja.po (+309/-335)
po/kn.po (+307/-327)
po/ko.po (+307/-324)
po/ml.po (+306/-324)
po/mr.po (+306/-327)
po/ms.po (+294/-299)
po/nb.po (+294/-299)
po/nl.po (+309/-307)
po/or.po (+306/-304)
po/pa.po (+309/-304)
po/pl.po (+328/-340)
po/pt.po (+309/-326)
po/pt_BR.po (+309/-332)
po/ro.po (+294/-299)
po/ru.po (+306/-324)
po/sk.po (+296/-311)
po/sr.po (+296/-308)
po/sr@latin.po (+296/-303)
po/sv.po (+306/-333)
po/ta.po (+307/-328)
po/te.po (+306/-327)
po/tr.po (+304/-330)
po/uk.po (+330/-339)
po/vi.po (+294/-299)
po/zh_CN.po (+306/-324)
po/zh_TW.po (+302/-317)
setup.py (+17/-22)
tests/cli-test-xml/admin-password.txt (+1/-0)
tests/cli-test-xml/compare/virt-install-aarch64-graphics.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-aarch64-headless.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-aarch64-kvm-gic.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-aarch64-kvm-import.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-arm-defaultmach-f20.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-arm-kvm-import.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-arm-virt-f20.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-f21-kvm-remote.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-kvm-centos7.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-kvm-fedoralatest-url.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-kvm-session-defaults.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-location-iso.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-many-devices.xml (+24/-0)
tests/cli-test-xml/compare/virt-install-network-install-resources.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-osinfo-netinst-unattended.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-osinfo-url-unattended.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-osinfo-url-with-disk.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-osinfo-url.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-ppc64-graphics.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-ppc64-headless.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-ppc64-machdefault-f20.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-ppc64-pseries-f20.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-ppc64le-kvm-import.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-qemu-32-on-64.xml (+15/-3)
tests/cli-test-xml/compare/virt-install-riscv64-graphics.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-riscv64-headless.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-s390x-cdrom.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-s390x-graphics.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-s390x-headless.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-singleton-config-1.xml (+1/-1)
tests/cli-test-xml/compare/virt-install-singleton-config-2.xml (+2/-0)
tests/cli-test-xml/compare/virt-install-singleton-config-3.xml (+1/-1)
tests/cli-test-xml/compare/virt-install-x86_64-graphics.xml (+1/-0)
tests/cli-test-xml/compare/virt-install-x86_64-headless.xml (+1/-0)
tests/cli-test-xml/compare/virt-xml-edit-disable-memballoon.xml (+11/-0)
tests/cli-test-xml/compare/virt-xml-remove-memballoon.xml (+10/-0)
tests/cli-test-xml/user-password.txt (+3/-0)
tests/clitest.py (+53/-17)
tests/dist.py (+0/-67)
tests/storage-xml/pool-dir-volclone.xml (+2/-2)
tests/storage-xml/pool-dir.xml (+1/-1)
tests/storage-xml/pool-disk-volclone.xml (+2/-2)
tests/storage-xml/pool-disk.xml (+1/-2)
tests/storage-xml/pool-fs-volclone.xml (+2/-2)
tests/storage-xml/pool-fs.xml (+1/-1)
tests/storage-xml/pool-iscsi.xml (+1/-1)
tests/storage-xml/pool-logical-srcname.xml (+0/-4)
tests/storage-xml/pool-logical-target-srcname.xml (+0/-7)
tests/storage-xml/pool-logical.xml (+0/-4)
tests/storage-xml/pool-mpath.xml (+1/-1)
tests/storage-xml/pool-netfs-volclone.xml (+2/-2)
tests/storage-xml/pool-netfs.xml (+1/-1)
tests/storage-xml/pool-rbd.xml (+7/-0)
tests/storage-xml/pool-scsi.xml (+1/-1)
tests/storage.py (+41/-35)
tests/test_urls.ini (+6/-1)
tests/test_urls.py (+10/-15)
tests/uitests/createpool.py (+63/-5)
tests/uitests/newvm.py (+5/-0)
tests/xmlparse-xml/change-disk-out.xml (+1/-1)
tests/xmlparse-xml/pool-iscsi-out.xml (+1/-1)
tests/xmlparse.py (+1/-1)
ui/createpool.ui (+62/-30)
virt-install (+9/-0)
virt-manager.spec (+4/-1)
virt-manager.spec.in (+3/-0)
virtManager/clone.py (+3/-1)
virtManager/connection.py (+1/-2)
virtManager/createpool.py (+68/-124)
virtManager/createvol.py (+1/-1)
virtManager/device/addstorage.py (+1/-1)
virtManager/hoststorage.py (+4/-3)
virtManager/object/storagepool.py (+45/-2)
virtManager/xmleditor.py (+10/-1)
virtinst/buildconfig.py (+1/-1)
virtinst/cli.py (+51/-43)
virtinst/devices/disk.py (+1/-1)
virtinst/diskbackend.py (+7/-2)
virtinst/domain/numatune.py (+13/-2)
virtinst/guest.py (+33/-0)
virtinst/install/unattended.py (+43/-13)
virtinst/osdict.py (+6/-0)
virtinst/storage.py (+106/-215)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in virt-manager (Ubuntu):
status: New → Confirmed
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

On a 19.10 system without those packages:

root@e:~# apt-cache policy gir1.2-gtksource-4 libgtksourceview-4-0 libgtksourceview-4-common
gir1.2-gtksource-4:
  Installed: (none)
  Candidate: 4.3.1-2
  Version table:
     4.3.1-2 500
        500 http://archive.ubuntu.com/ubuntu eoan/main amd64 Packages
libgtksourceview-4-0:
  Installed: (none)
  Candidate: 4.3.1-2
  Version table:
     4.3.1-2 500
        500 http://archive.ubuntu.com/ubuntu eoan/main amd64 Packages
libgtksourceview-4-common:
  Installed: (none)
  Candidate: 4.3.1-2
  Version table:
     4.3.1-2 500
        500 http://archive.ubuntu.com/ubuntu eoan/main amd64 Packages

# dpkg -l '*gtksource*'
dpkg-query: no packages found matching *gtksource*

I couldn't break it, but I ran into different issues ... ?!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

virt-manager has code like:
  6 gi.require_version('GtkSource', '4')
in /usr/share/virt-manager/virtManager/xmleditor.py
matching the reported stack trace.

So I'd assume the bug should trigger on xml edit?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Never the less I found
https://github.com/virt-manager/virt-manager/commit/267f226134afb9dfef9091e3da5647441aebabbf
https://github.com/virt-manager/virt-manager/commit/033e97021e6654c9859776dedd9cd0504973f1d6

Which I think would solve this the right way.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

$ git tag --contains 267f226134afb9dfef9091e3da5647441aebabbf
v2.2.1
[✓]─[paelzer@Keschdeichel ~/work/virt-manager/virt-manager-ubuntu-git]──[99971]──[08:25 Di Aug 20]──(detached*)*
$ git tag --contains 033e97021e6654c9859776dedd9cd0504973f1d6
v2.2.1

So all those are in 2.2.1 release which has a bunch of other fixes as well.
I'd not yet make it pull in gir1.2-gtksource-4 and co (even thou that would be an option).
Instead I'd think I'm gonna try to wrap up 2.2.1 as a while for Eoan.

Since I fail to recreate your issue exactly, maybe you can give it a try if/once I have a PPA with that.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I think we need either gir1.2-gtksource-3 or gir1.2-gtksource-4 the rest comes in as dependency.
Both will work after the update.

I'll have to ask the desktop Team which is preferred.

Actually this is pretty clear:

apt-cache policy gir1.2-gtksource-3.0 gir1.2-gtksource-4
gir1.2-gtksource-3.0:
  Installed: 3.24.11-1
  Candidate: 3.24.11-1
  Version table:
 *** 3.24.11-1 500
        500 http://archive.ubuntu.com/ubuntu eoan/universe amd64 Packages
        100 /var/lib/dpkg/status
gir1.2-gtksource-4:
  Installed: 4.3.1-2
  Candidate: 4.3.1-2
  Version table:
 *** 4.3.1-2 500
        500 http://archive.ubuntu.com/ubuntu eoan/main amd64 Packages
        100 /var/lib/dpkg/status

v4 is in main, so this is what I will take.
Even no more needed 2.2.1 still makes sense IMHO.

Changed in virt-manager (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Note: I'm not entirely sure why ${python3:Depends} didn't pick it up.
It does so for
virtManager/details/viewers.py:17: gi.require_version('SpiceClientGtk', '3.0')
  => gir1.2-spiceclientgtk-3.0
virtManager/details/serialcon.py:16: gi.require_version("Vte", "2.91")
  => gir1.2-vte-2.91
virtManager/details/viewers.py:14:gi.require_version('GtkVnc', '2.0')
  => gir1.2-gtk-vnc-2.0
virt-manager:61: gi.require_version('Gtk', '3.0')
  => gir1.2-gtk-3.0
virt-manager:16:gi.require_version('LibvirtGLib', '1.0')
  => gir1.2-libvirt-glib-1.0

Just not:
  gir1.2-gtksource-4

Ah no, there is another one
  gir1.2-libosinfo-1.0
back from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=796723

Ok, lets add the dependency at the same level - that seems the right place.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

There is a test PPA [1] available now and I'd highly appreciate if you could give this PPA a try.
If it resolves your issue that would be great and we'd just slip in before feature freeze which is on this weeks Thursday.

[1]: https://launchpad.net/~paelzer/+archive/ubuntu/merge-virt-manager-2.2.1-eoan

Changed in virt-manager (Ubuntu):
importance: Undecided → High
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Further question, did you have to set "Enable XML editing" in "Edit"->"preferences" to run into this particular bug?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I was able to reproduce your issue now, added some details to the bug.
Thanks for your report, I think this is ready to upload as soon as one reviewed the MP.

Unfortunately I found another bug of a similar type that I need to resolve as well to make it work well in Eoan. See bug 1840754

description: updated
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The other bug was a big red herring, but to be entirely sure it would be great if you could update it on your system and give it a try.

Revision history for this message
RussianNeuroMancer (russianneuromancer) wrote :

Sorry for the delay, I will try to check this today or Friday.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

NP - I'm fine since I got a way to test it myself.
It already is in https://launchpad.net/ubuntu/+source/virt-manager/1:2.2.1-0ubuntu1

Which should soon migrate to the release pocket unless the only remaining test (armhf) runs into an error.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package virt-manager - 1:2.2.1-0ubuntu1

---------------
virt-manager (1:2.2.1-0ubuntu1) eoan; urgency=medium

  * Merge with new upstream release v2.2.1
    - d/control: add missing gir1.2-gtksource-4 dependency (LP: #1840677)

 -- Christian Ehrhardt <email address hidden> Tue, 20 Aug 2019 08:39:44 +0200

Changed in virt-manager (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
RussianNeuroMancer (russianneuromancer) wrote :

> Further question, did you have to set "Enable XML editing" in "Edit"->"preferences" to run into this particular bug?

No.

> but to be entirely sure it would be great if you could update it on your system and give it a try

I updated to virt-manager 2.2.1 and issue is no longer reproducible. Thank you for fixing this so fast :)

By any chance, maybe you know how this one https://bugs.launchpad.net/ubuntu/+source/virt-manager/+bug/1832395 can be fixed or at least workarounded?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote : Re: [Bug 1840677] Re: gtksourceview4 dependency is missing in virt-manager eoan package

> By any chance, maybe you know how this one
> https://bugs.launchpad.net/ubuntu/+source/virt-manager/+bug/1832395 can
> be fixed or at least workarounded?

I have looked at it and was the one who asked Rafael to take a look as
he has experience and access to this kind of HW.
But currently everything is really busy, so this gets postponed every week.

No quick fix available there sorry, but hopefully still good to know
that I can confirm it still is on his list.

Revision history for this message
RussianNeuroMancer (russianneuromancer) wrote :

> No quick fix available there sorry, but hopefully still good to know
that I can confirm it still is on his list.

No problem, thank you for checking this.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.