Ubuntu
software-properties package

[SRU] Move Livepatch in a different tab as in Disco

Bug #1823761 reported by Andrea Azzarone
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-properties (Ubuntu)
Fix Released
High
Unassigned
Bionic
Fix Released
High
Andrea Azzarone

Bug Description

* Impact
The livepatch graphical interfaces are currently limited in bionic, there is no easy way to know the current status and the details of the changes applied. The new design improves the user experience and we want that to benefit the LTS users

* Test case
Open software-properties-gtk, you should see a livepatch new tab which has the detail of the status (including the CVEs fixes with the applied livepatch where there is one)

* Regression potential
The changes are mostly new code so check that the livepatch tab works correctly.
There is some UI refactoring so it's best to check that the other tabs still look the same.
Note that the changes include some new strings. Those are translated in disco and have been announced to the translators in march as coming to bionic for a SRU
(https://lists.ubuntu.com/archives/ubuntu-translators/2019-March/007530.html).
Launchpad shares translations between series so we should get those translations included in the next bionic langpacks export.

-------------------------------

Backport the new Livepatch tab from Disco.

See original description

Related branches

~azzar1/software-properties:ubuntu/bionic-livepatch
Sebastien Bacher: Approve
Diff: 2640 lines (+1452/-626)
23 files modified
data/gtkbuilder/dialog-auth.ui (+93/-77)
data/gtkbuilder/dialog-livepatch-error.ui (+96/-15)
data/gtkbuilder/main.ui (+221/-81)
data/icons/scalable/apps/livepatch.svg (+1/-0)
data/software-properties-livepatch.desktop.in (+12/-0)
debian/changelog (+12/-0)
debian/control (+7/-2)
debian/gbp.conf (+3/-0)
debian/software-properties-gtk.install (+1/-0)
po/POTFILES.in (+6/-0)
setup.cfg (+1/-0)
softwareproperties/GoaAuth.py (+16/-5)
softwareproperties/LivepatchService.py (+254/-0)
softwareproperties/LivepatchSnap.py (+135/-0)
softwareproperties/SoftwareProperties.py (+0/-152)
softwareproperties/dbus/SoftwarePropertiesDBus.py (+8/-2)
softwareproperties/gtk/DialogAuth.py (+132/-117)
softwareproperties/gtk/DialogLivepatchError.py (+15/-6)
softwareproperties/gtk/LivepatchPage.py (+375/-0)
softwareproperties/gtk/SimpleGtkbuilderApp.py (+3/-0)
softwareproperties/gtk/SoftwarePropertiesGtk.py (+5/-168)
softwareproperties/gtk/utils.py (+56/-1)
tests/aptroot/etc/apt/apt.conf.d/.keep (+0/-0)
Andrea Azzarone (azzar1)
tags: added: rls-bb-incoming
Andrea Azzarone (azzar1)
summary: - [FFE] Move Livepatch in a different tab as in Disco
+ [SRU] Move Livepatch in a different tab as in Disco
Revision history for this message
Sebastien Bacher (seb128) wrote :

That's a software-properties change right? (assuming the component was just wrongly selected and changing that)

affects: update-notifier (Ubuntu) → software-properties (Ubuntu)
Changed in software-properties (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

Could you make the bug SRU compliant (having the impact/test case/regression potential)

Sebastien Bacher (seb128)
Changed in software-properties (Ubuntu Bionic):
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Andrea Azzarone (azzar1)
Sebastien Bacher (seb128)
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted software-properties into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.24.32.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-bionic
Brian Murray (brian-murray)
tags: removed: rls-bb-incoming
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hi Andrea,

Do you have an ETA on verifying this SRU? I have a software-properties SRU that is blocked from getting into bionic-proposed until this is released. https://bugs.launchpad.net/bugs/1829017

Thanks,
Corey

Revision history for this message
Sebastien Bacher (seb128) wrote :

I've had 0.96.24.32.8 installed on bionic for some days, it works fine and the livepatch tab matches the design and work as expected (activate/desactivate the service, list applied changes, ...), I'm marking the SRU as verified

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.96.24.32.8

---------------
software-properties (0.96.24.32.8) bionic; urgency=medium

  * debian/control: Update Vcs-*: URLs
  * debian/gbp.conf: Add default configuration
  * Add .keep files to preserve empty directories
  * Backport Livepatch changes from Disco (LP: #1823761):
    - Implement new design for authentication dialog.
    - Add livepatch desktop file and icon.
    - Move Livepatch UI in a diffrent tab.

 -- Andrea Azzarone <email address hidden> Mon, 08 Apr 2019 16:52:15 +0100

Changed in software-properties (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for software-properties has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.